From 27eea33efc80343d398a27b9c18a06f2170ac2cb Mon Sep 17 00:00:00 2001
From: donpat1to <patrick@inca-vikingo.de>
Date: Fri, 10 Oct 2025 18:33:13 +0200
Subject: [PATCH] removed notes as user attribute

---
 backend/src/controllers/employeeController.ts |  8 ++--
 backend/src/database/schema.sql               |  3 +-
 backend/src/models/Employee.ts                |  3 --
 .../Employees/components/EmployeeForm.tsx     | 38 -------------------
 frontend/src/types/employee.ts                |  3 --
 5 files changed, 5 insertions(+), 50 deletions(-)

diff --git a/backend/src/controllers/employeeController.ts b/backend/src/controllers/employeeController.ts
index 6a0abec..55a7305 100644
--- a/backend/src/controllers/employeeController.ts
+++ b/backend/src/controllers/employeeController.ts
@@ -73,7 +73,6 @@ export const createEmployee = async (req: AuthRequest, res: Response): Promise<v
       role, 
       employeeType, 
       isSufficientlyIndependent,
-      notes 
     } = req.body as CreateEmployeeRequest;
 
     // Validierung
@@ -107,8 +106,8 @@ export const createEmployee = async (req: AuthRequest, res: Response): Promise<v
     await db.run(
       `INSERT INTO users (
         id, email, password, name, role, employee_type, is_sufficiently_independent, 
-        notes, is_active
-      ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)`,
+        is_active
+      ) VALUES (?, ?, ?, ?, ?, ?, ?, ?)`,
       [
         employeeId, 
         email, 
@@ -117,7 +116,6 @@ export const createEmployee = async (req: AuthRequest, res: Response): Promise<v
         role, 
         employeeType, 
         isSufficientlyIndependent ? 1 : 0,
-        notes || null,
         1
       ]
     );
@@ -128,7 +126,7 @@ export const createEmployee = async (req: AuthRequest, res: Response): Promise<v
         id, email, name, role, is_active as isActive,
         employee_type as employeeType, 
         is_sufficiently_independent as isSufficientlyIndependent, 
-        notes, created_at as createdAt, 
+        created_at as createdAt, 
         last_login as lastLogin
       FROM users 
       WHERE id = ?
diff --git a/backend/src/database/schema.sql b/backend/src/database/schema.sql
index 19234c9..9e75351 100644
--- a/backend/src/database/schema.sql
+++ b/backend/src/database/schema.sql
@@ -8,7 +8,8 @@ CREATE TABLE IF NOT EXISTS users (
   employee_type TEXT CHECK(employee_type IN ('chef', 'neuling', 'erfahren')),
   is_sufficiently_independent BOOLEAN DEFAULT FALSE,
   is_active BOOLEAN DEFAULT TRUE,
-  created_at DATETIME DEFAULT CURRENT_TIMESTAMP
+  created_at DATETIME DEFAULT CURRENT_TIMESTAMP,
+  last_login DATETIME
 );
 
 -- Tabelle für Schichtvorlagen
diff --git a/backend/src/models/Employee.ts b/backend/src/models/Employee.ts
index afbc869..680dbe2 100644
--- a/backend/src/models/Employee.ts
+++ b/backend/src/models/Employee.ts
@@ -7,7 +7,6 @@ export interface Employee {
   employeeType: 'chef' | 'neuling' | 'erfahren';
   isSufficientlyIndependent: boolean;
   isActive: boolean;
-  notes?: string;
   createdAt: string;
   lastLogin?: string | null;
 }
@@ -19,7 +18,6 @@ export interface CreateEmployeeRequest {
   role: 'admin' | 'instandhalter' | 'user';
   employeeType: 'chef' | 'neuling' | 'erfahren';
   isSufficientlyIndependent: boolean;
-  notes?: string;
 }
 
 export interface UpdateEmployeeRequest {
@@ -28,7 +26,6 @@ export interface UpdateEmployeeRequest {
   employeeType?: 'chef' | 'neuling' | 'erfahren';
   isSufficientlyIndependent?: boolean;
   isActive?: boolean;
-  notes?: string;
 }
 
 export interface EmployeeWithPassword extends Employee {
diff --git a/frontend/src/pages/Employees/components/EmployeeForm.tsx b/frontend/src/pages/Employees/components/EmployeeForm.tsx
index f13f954..aa8f1cc 100644
--- a/frontend/src/pages/Employees/components/EmployeeForm.tsx
+++ b/frontend/src/pages/Employees/components/EmployeeForm.tsx
@@ -53,7 +53,6 @@ const EmployeeForm: React.FC<EmployeeFormProps> = ({
     role: 'user' as 'admin' | 'instandhalter' | 'user',
     employeeType: 'neuling' as 'chef' | 'neuling' | 'erfahren',
     isSufficientlyIndependent: false,
-    notes: '',
     isActive: true
   });
   const [loading, setLoading] = useState(false);
@@ -69,7 +68,6 @@ const EmployeeForm: React.FC<EmployeeFormProps> = ({
         role: employee.role,
         employeeType: employee.employeeType,
         isSufficientlyIndependent: employee.isSufficientlyIndependent,
-        notes: employee.notes || '',
         isActive: employee.isActive
       });
     }
@@ -114,7 +112,6 @@ const EmployeeForm: React.FC<EmployeeFormProps> = ({
           role: formData.role,
           employeeType: formData.employeeType,
           isSufficientlyIndependent: formData.isSufficientlyIndependent,
-          notes: formData.notes || undefined
         };
         await employeeService.createEmployee(createData);
       } else if (employee) {
@@ -124,7 +121,6 @@ const EmployeeForm: React.FC<EmployeeFormProps> = ({
           employeeType: formData.employeeType,
           isSufficientlyIndependent: formData.isSufficientlyIndependent,
           isActive: formData.isActive,
-          notes: formData.notes || undefined
         };
         await employeeService.updateEmployee(employee.id, updateData);
       }
@@ -406,40 +402,6 @@ const EmployeeForm: React.FC<EmployeeFormProps> = ({
             </div>
           </div>
 
-          {/* Bemerkungen */}
-          <div style={{
-            padding: '20px',
-            backgroundColor: '#f8f9fa',
-            borderRadius: '8px',
-            border: '1px solid #e9ecef'
-          }}>
-            <h3 style={{ margin: '0 0 15px 0', color: '#495057' }}>ℹ️ Bemerkungen</h3>
-            
-            <div>
-              <label style={{ display: 'block', marginBottom: '8px', fontWeight: 'bold', color: '#2c3e50' }}>
-                Notizen & Hinweise
-              </label>
-              <textarea
-                name="notes"
-                value={formData.notes}
-                onChange={handleChange}
-                rows={3}
-                style={{
-                  width: '100%',
-                  padding: '10px',
-                  border: '1px solid #ddd',
-                  borderRadius: '4px',
-                  fontSize: '16px',
-                  resize: 'vertical'
-                }}
-                placeholder="Besondere Fähigkeiten, Einschränkungen, Schulungen, wichtige Hinweise..."
-              />
-              <div style={{ fontSize: '12px', color: '#7f8c8d', marginTop: '5px' }}>
-                Optionale Notizen für interne Zwecke
-              </div>
-            </div>
-          </div>
-
           {/* Systemrolle (nur für Admins) */}
           {hasRole(['admin']) && (
             <div style={{
diff --git a/frontend/src/types/employee.ts b/frontend/src/types/employee.ts
index b7439cb..da1c270 100644
--- a/frontend/src/types/employee.ts
+++ b/frontend/src/types/employee.ts
@@ -9,7 +9,6 @@ export interface Employee {
   isActive: boolean;
   createdAt: string;
   lastLogin?: string | null;
-  notes?: string;
 }
 
 export interface CreateEmployeeRequest {
@@ -19,7 +18,6 @@ export interface CreateEmployeeRequest {
   role: 'admin' | 'instandhalter' | 'user';
   employeeType: 'chef' | 'neuling' | 'erfahren';
   isSufficientlyIndependent: boolean;
-  notes?: string;
 }
 
 export interface UpdateEmployeeRequest {
@@ -28,7 +26,6 @@ export interface UpdateEmployeeRequest {
   employeeType?: 'chef' | 'neuling' | 'erfahren';
   isSufficientlyIndependent?: boolean;
   isActive?: boolean;
-  notes?: string;
 }
 
 export interface Availability {