Merge pull request 'Fixed Json Parser' (#37) from feature/service-detection into staging

Reviewed-on: #37

Tests/servicediscovery.py

@@ -3,9 +3,39 @@ import urllib.request
 
 url = "http://localhost:5000/monitoring/service-discovery"
 payload = {
-    "server_id": 7,
+  "Server_id": 2,
-    "containers": ["{\"id\":\"6621c5b67c25\",\"image\":\"git.triggermeelmo.com/donpat1to/watcher-agent:v0.1.26\",\"name\":\"watcher-agent\"}",
+  "Containers": [
-                   "{\"id\":\"b8c86fb260bd\",\"image\":\"git.triggermeelmo.com/watcher/watcher-server:v0.1.10\",\"name\":\"watcher\"}"]
+    {
+      "id": "3e74abf5ce30",
+      "image": "hello-world:latest",
+      "name": "serene_nightingale"
+    },
+    {
+      "id": "83cd9d461690",
+      "image": "postgres:latest",
+      "name": "distracted_feistel"
+    },
+    {
+      "id": "b296c2ed1213",
+      "image": "postgres:latest",
+      "name": "mystifying_jackson"
+    },
+    {
+      "id": "69568181d576",
+      "image": "hello-world:latest",
+      "name": "romantic_driscoll"
+    },
+    {
+      "id": "67c37a2b1791",
+      "image": "hello-world:latest",
+      "name": "asdf"
+    },
+    {
+      "id": "8f39bae1e316",
+      "image": "hello-world:latest",
+      "name": "distracted_mirzakhani"
+    }
+  ]
 }
 
 data = json.dumps(payload).encode("utf-8")

Watcher/Controllers/ContainerController.cs

@@ -18,7 +18,7 @@ public class ContainerController : Controller
     }
 
     public async Task<IActionResult> Overview()
-{
+    {
         var containers = await _context.Containers.ToListAsync();
         var servers = await _context.Servers.ToListAsync();
 
@@ -29,6 +29,6 @@ public class ContainerController : Controller
         };
 
         return View(viewModel);
-}
+    }
 
 }

Watcher/Controllers/MonitoringController.cs

@@ -1,5 +1,5 @@
 using System.ComponentModel.DataAnnotations;
-using System.Net.Http.Json;
+using System.Net;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 using Microsoft.AspNetCore.Authorization;
@@ -82,10 +82,15 @@ public class MetricDto
     public double NET_Out { get; set; } // Bytes/s
 }
 
-public class ServiceDto
+public class DockerServiceDto
 {
-    public required int server_id { get; set; } // Vom Watcher-Server zugewiesene ID des Hosts
+    public required int Server_id { get; set; } // Vom Watcher-Server zugewiesene ID des Hosts
-    public required List<String> containers { get; set; }
+    public required JsonElement Containers { get; set; }
+}
+
+public class DockerServiceMetricDto
+{
+
 }
 
 [ApiController]
@@ -226,7 +231,7 @@ public class MonitoringController : Controller
 
     // Endpoint, an dem Agents Ihre laufenden Services registrieren
     [HttpPost("service-discovery")]
-    public async Task<IActionResult> ServiceDetection([FromBody] ServiceDto dto)
+    public async Task<IActionResult> ServiceDetection([FromBody] DockerServiceDto dto)
     {
         // Gültigkeit des Payloads prüfen
         if (!ModelState.IsValid)
@@ -240,38 +245,13 @@ public class MonitoringController : Controller
             return BadRequest(new { error = "Invalid Payload", details = errors });
         }
 
-        // Json zu was brauchbarem machen
+        List<Container> newContainers =
-        //string containersJson = await dto.containers.ReadAsStringAsync();
+            JsonSerializer.Deserialize<List<Container>>(dto.Containers.GetRawText())
-        //List<Container> newContainers = JsonSerializer.Deserialize<List<Container>>(containersJson)?? new List<Container>();;
+            ?? new List<Container>();
-
-        List<Container> newContainers = new List<Container>();
-
-        foreach (String s in dto.containers)
-        {
-            // JSON zu einem JsonDocument parsen
-            using JsonDocument doc = JsonDocument.Parse(s);
-            JsonElement root = doc.RootElement;
-
-            // Einzelne Werte extrahieren
-            string id = root.GetProperty("id").GetString() ?? "";
-            string image = root.GetProperty("image").GetString() ?? "";
-            string name = root.GetProperty("name").GetString() ?? "";
-
-            Container newContainer = new Container
-            {
-                ServerId = dto.server_id,
-                ContainerId = id,
-                Image = image,
-                Name = name,
-            };
-
-
-            newContainers.Add(newContainer);
-        }
 
         foreach (Container c in newContainers)
         {
-            c.ServerId = dto.server_id;
+            c.ServerId = dto.Server_id;
             // Debug Logs
             // TODO entfernen wenn fertig getestet
             Console.WriteLine("---------");
@@ -283,12 +263,9 @@ public class MonitoringController : Controller
 
         }
 
-        // Container Objekte erstellen
-        //List<Container> newContainers = ParseServiceDiscoveryInput(dto.Server_id, containers);
-
         // Liste aller Container, die bereits der übergebenen ServerId zugewiesen sind
         List<Container> existingContainers = _context.Containers
-            .Where(c => c.ServerId == dto.server_id)
+            .Where(c => c.ServerId == dto.Server_id)
             .ToList();
 
 
@@ -338,6 +315,45 @@ public class MonitoringController : Controller
 
     }
 
+    // Endpoint, an den der Agent die Metrics der registrierten Container schickt
+    public async Task<IActionResult> ServiceMetrics([FromBody] DockerServiceMetricDto dto)
+    {
+        // Gültigkeit des Payloads prüfen
+        if (!ModelState.IsValid)
+        {
+            var errors = ModelState.Values
+                .SelectMany(v => v.Errors)
+                .Select(e => e.ErrorMessage)
+                .ToList();
+
+            _logger.LogError("Invalid ServiceDetection-Payload.");
+            return BadRequest(new { error = "Invalid Payload", details = errors });
+        }
+
+        // Liste an Metrics aus der dto erstellen
+        List<ContainerMetric> metrics = new List<ContainerMetric>();
+
+        // Metrics in die Datenbank eintragen
+        try
+        {
+            foreach (ContainerMetric m in metrics)
+            {
+                _context.ContainerMetrics.Add(m);
+                await _context.SaveChangesAsync();
+                // _logger.LogInformation(m. + " added for Host " + c.ServerId);
+                return Ok();
+            }
+        }
+        catch (SqliteException e)
+        {
+            _logger.LogError(e.Message);
+            return StatusCode(500);
+        }
+
+        return Ok();
+
+    }
+
     // Durchschnittliche Werte Berechnen
     public async Task<IActionResult> CalculateMedian(string Metric, int HoursToMonitor, int ServerId)
     {

Watcher/Data/AppDbContext.cs

@@ -26,6 +26,8 @@ public class AppDbContext : DbContext
 
     public DbSet<Tag> Tags { get; set; }
 
+    public DbSet<ContainerMetric> ContainerMetrics { get; set; }
+
     public DbSet<User> Users { get; set; }
 
     protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)

Watcher/Migrations/20251029125404_ContainerMetrics-Added.Designer.cs

@@ -0,0 +1,355 @@
+// <auto-generated />
+using System;
+using Microsoft.EntityFrameworkCore;
+using Microsoft.EntityFrameworkCore.Infrastructure;
+using Microsoft.EntityFrameworkCore.Migrations;
+using Microsoft.EntityFrameworkCore.Storage.ValueConversion;
+using Watcher.Data;
+
+#nullable disable
+
+namespace Watcher.Migrations
+{
+    [DbContext(typeof(AppDbContext))]
+    [Migration("20251029125404_ContainerMetrics-Added")]
+    partial class ContainerMetricsAdded
+    {
+        /// <inheritdoc />
+        protected override void BuildTargetModel(ModelBuilder modelBuilder)
+        {
+#pragma warning disable 612, 618
+            modelBuilder.HasAnnotation("ProductVersion", "8.0.6");
+
+            modelBuilder.Entity("Watcher.Models.Container", b =>
+                {
+                    b.Property<int>("Id")
+                        .ValueGeneratedOnAdd()
+                        .HasColumnType("INTEGER");
+
+                    b.Property<string>("ContainerId")
+                        .HasColumnType("TEXT");
+
+                    b.Property<string>("Image")
+                        .HasColumnType("TEXT");
+
+                    b.Property<int?>("ImageId")
+                        .HasColumnType("INTEGER");
+
+                    b.Property<bool>("IsRunning")
+                        .HasColumnType("INTEGER");
+
+                    b.Property<string>("Name")
+                        .HasColumnType("TEXT");
+
+                    b.Property<int>("ServerId")
+                        .HasColumnType("INTEGER");
+
+                    b.Property<int?>("TagId")
+                        .HasColumnType("INTEGER");
+
+                    b.HasKey("Id");
+
+                    b.HasIndex("ImageId");
+
+                    b.HasIndex("TagId");
+
+                    b.ToTable("Containers");
+                });
+
+            modelBuilder.Entity("Watcher.Models.Image", b =>
+                {
+                    b.Property<int>("Id")
+                        .ValueGeneratedOnAdd()
+                        .HasColumnType("INTEGER");
+
+                    b.Property<string>("Name")
+                        .HasColumnType("TEXT");
+
+                    b.Property<string>("Tag")
+                        .HasColumnType("TEXT");
+
+                    b.HasKey("Id");
+
+                    b.ToTable("Images");
+                });
+
+            modelBuilder.Entity("Watcher.Models.LogEvent", b =>
+                {
+                    b.Property<int>("Id")
+                        .ValueGeneratedOnAdd()
+                        .HasColumnType("INTEGER");
+
+                    b.Property<int?>("ContainerId")
+                        .HasColumnType("INTEGER");
+
+                    b.Property<string>("Level")
+                        .HasColumnType("TEXT");
+
+                    b.Property<string>("Message")
+                        .HasColumnType("TEXT");
+
+                    b.Property<int?>("ServerId")
+                        .HasColumnType("INTEGER");
+
+                    b.Property<DateTime>("Timestamp")
+                        .HasColumnType("TEXT");
+
+                    b.HasKey("Id");
+
+                    b.HasIndex("ContainerId");
+
+                    b.HasIndex("ServerId");
+
+                    b.ToTable("LogEvents");
+                });
+
+            modelBuilder.Entity("Watcher.Models.Metric", b =>
+                {
+                    b.Property<int>("Id")
+                        .ValueGeneratedOnAdd()
+                        .HasColumnType("INTEGER");
+
+                    b.Property<double>("CPU_Load")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("CPU_Temp")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("DISK_Size")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("DISK_Temp")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("DISK_Usage")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("GPU_Load")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("GPU_Temp")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("GPU_Vram_Size")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("GPU_Vram_Usage")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("NET_In")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("NET_Out")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("RAM_Load")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("RAM_Size")
+                        .HasColumnType("REAL");
+
+                    b.Property<int?>("ServerId")
+                        .HasColumnType("INTEGER");
+
+                    b.Property<DateTime>("Timestamp")
+                        .HasColumnType("TEXT");
+
+                    b.HasKey("Id");
+
+                    b.ToTable("Metrics");
+                });
+
+            modelBuilder.Entity("Watcher.Models.Server", b =>
+                {
+                    b.Property<int>("Id")
+                        .ValueGeneratedOnAdd()
+                        .HasColumnType("INTEGER");
+
+                    b.Property<double>("CPU_Load_Critical")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("CPU_Load_Warning")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("CPU_Temp_Critical")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("CPU_Temp_Warning")
+                        .HasColumnType("REAL");
+
+                    b.Property<int>("CpuCores")
+                        .HasColumnType("INTEGER");
+
+                    b.Property<string>("CpuType")
+                        .HasColumnType("TEXT");
+
+                    b.Property<DateTime>("CreatedAt")
+                        .HasColumnType("TEXT");
+
+                    b.Property<double>("DISK_Temp_Critical")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("DISK_Temp_Warning")
+                        .HasColumnType("REAL");
+
+                    b.Property<string>("Description")
+                        .HasColumnType("TEXT");
+
+                    b.Property<string>("DiskSpace")
+                        .HasColumnType("TEXT");
+
+                    b.Property<double>("Disk_Usage_Critical")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("Disk_Usage_Warning")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("GPU_Load_Critical")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("GPU_Load_Warning")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("GPU_Temp_Critical")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("GPU_Temp_Warning")
+                        .HasColumnType("REAL");
+
+                    b.Property<string>("GpuType")
+                        .HasColumnType("TEXT");
+
+                    b.Property<string>("IPAddress")
+                        .IsRequired()
+                        .HasColumnType("TEXT");
+
+                    b.Property<bool>("IsOnline")
+                        .HasColumnType("INTEGER");
+
+                    b.Property<bool>("IsVerified")
+                        .HasColumnType("INTEGER");
+
+                    b.Property<DateTime>("LastSeen")
+                        .HasColumnType("TEXT");
+
+                    b.Property<string>("Name")
+                        .IsRequired()
+                        .HasColumnType("TEXT");
+
+                    b.Property<double>("RAM_Load_Critical")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("RAM_Load_Warning")
+                        .HasColumnType("REAL");
+
+                    b.Property<double>("RamSize")
+                        .HasColumnType("REAL");
+
+                    b.Property<int?>("TagId")
+                        .HasColumnType("INTEGER");
+
+                    b.Property<string>("Type")
+                        .IsRequired()
+                        .HasColumnType("TEXT");
+
+                    b.HasKey("Id");
+
+                    b.HasIndex("TagId");
+
+                    b.ToTable("Servers");
+                });
+
+            modelBuilder.Entity("Watcher.Models.Tag", b =>
+                {
+                    b.Property<int>("Id")
+                        .ValueGeneratedOnAdd()
+                        .HasColumnType("INTEGER");
+
+                    b.Property<string>("Name")
+                        .HasColumnType("TEXT");
+
+                    b.HasKey("Id");
+
+                    b.ToTable("Tags");
+                });
+
+            modelBuilder.Entity("Watcher.Models.User", b =>
+                {
+                    b.Property<int>("Id")
+                        .ValueGeneratedOnAdd()
+                        .HasColumnType("INTEGER");
+
+                    b.Property<string>("Email")
+                        .HasColumnType("TEXT");
+
+                    b.Property<string>("IdentityProvider")
+                        .IsRequired()
+                        .HasColumnType("TEXT");
+
+                    b.Property<DateTime>("LastLogin")
+                        .HasColumnType("TEXT");
+
+                    b.Property<string>("OIDC_Id")
+                        .HasColumnType("TEXT");
+
+                    b.Property<string>("Password")
+                        .IsRequired()
+                        .HasColumnType("TEXT");
+
+                    b.Property<string>("Username")
+                        .IsRequired()
+                        .HasColumnType("TEXT");
+
+                    b.HasKey("Id");
+
+                    b.ToTable("Users");
+                });
+
+            modelBuilder.Entity("Watcher.Models.Container", b =>
+                {
+                    b.HasOne("Watcher.Models.Image", null)
+                        .WithMany("Containers")
+                        .HasForeignKey("ImageId");
+
+                    b.HasOne("Watcher.Models.Tag", null)
+                        .WithMany("Containers")
+                        .HasForeignKey("TagId");
+                });
+
+            modelBuilder.Entity("Watcher.Models.LogEvent", b =>
+                {
+                    b.HasOne("Watcher.Models.Container", "Container")
+                        .WithMany()
+                        .HasForeignKey("ContainerId");
+
+                    b.HasOne("Watcher.Models.Server", "Server")
+                        .WithMany()
+                        .HasForeignKey("ServerId");
+
+                    b.Navigation("Container");
+
+                    b.Navigation("Server");
+                });
+
+            modelBuilder.Entity("Watcher.Models.Server", b =>
+                {
+                    b.HasOne("Watcher.Models.Tag", null)
+                        .WithMany("Servers")
+                        .HasForeignKey("TagId");
+                });
+
+            modelBuilder.Entity("Watcher.Models.Image", b =>
+                {
+                    b.Navigation("Containers");
+                });
+
+            modelBuilder.Entity("Watcher.Models.Tag", b =>
+                {
+                    b.Navigation("Containers");
+
+                    b.Navigation("Servers");
+                });
+#pragma warning restore 612, 618
+        }
+    }
+}

Watcher/Migrations/20251029125404_ContainerMetrics-Added.cs

@@ -0,0 +1,22 @@
+using Microsoft.EntityFrameworkCore.Migrations;
+
+#nullable disable
+
+namespace Watcher.Migrations
+{
+    /// <inheritdoc />
+    public partial class ContainerMetricsAdded : Migration
+    {
+        /// <inheritdoc />
+        protected override void Up(MigrationBuilder migrationBuilder)
+        {
+
+        }
+
+        /// <inheritdoc />
+        protected override void Down(MigrationBuilder migrationBuilder)
+        {
+
+        }
+    }
+}

Watcher/Models/Container.cs

@@ -4,11 +4,11 @@ namespace Watcher.Models;
 
 public class Container
 {
-    [JsonPropertyName("id")]
     public int Id { get; set; }
-
+    [JsonPropertyName("Server_id")]
     public int ServerId { get; set; }
 
+    [JsonPropertyName("id")]
     public String? ContainerId { get; set; }
 
     [JsonPropertyName("image")]

Watcher/Models/ContainerMetric.cs

@@ -0,0 +1,24 @@
+namespace Watcher.Models;
+
+public class ContainerMetric
+{
+    // Metric Metadata
+    public int Id { get; set; }
+    public DateTime Timestamp { get; set; }
+
+
+    // Zuordnung zu einem Container -- Foreign Key
+    public int? ContainerId { get; set; }
+
+
+    // CPU-Daten
+    public double CPU_Load { get; set; } = 0.0; // %
+
+    public double CPU_Temp { get; set; } = 0.0; // deg C
+
+    // RAM-Daten
+    public double RAM_Size { get; set; } = 0.0; // GB
+
+    public double RAM_Load { get; set; } = 0.0; // %
+
+}