Compare commits

..

38 Commits

Author SHA1 Message Date
0d27396fd5 changed from SolveWithSolutionCallback to Solver as of OR-Tools version change 2026-01-19 21:51:48 +01:00
0902472dfe added editing for shiftplans 2026-01-19 21:07:38 +01:00
5c021e8eb2 updated Readme 2026-01-19 13:13:59 +01:00
e5d836d037 moved amount of accesses to more strict handling for api calls 2025-11-07 16:37:43 +01:00
99d5105768 added api /auth/me to whitelist apicalls 2025-11-07 16:35:57 +01:00
a8dc11b024 added whitelist with loopback addresses for api rateLimit 2025-11-07 16:32:10 +01:00
0473a3b5bf added sorting to time table entries 2025-11-06 00:11:24 +01:00
ec86290d72 fixed package.json executing seeding script 2025-11-05 15:22:29 +01:00
eec9ea92d0 added seedtestData script 2025-11-05 15:09:03 +01:00
80cfe71362 added node_env detection 2025-11-05 15:03:31 +01:00
f6e19bc1ed added dropdown menu 2025-11-05 14:18:18 +01:00
e66c0f9e28 export drop down menu doesnt disappear when exporttype is selected 2025-11-05 13:22:00 +01:00
822b170920 added dropdown menu for export 2025-11-05 11:32:40 +01:00
c6dfa5b4c6 fixed manager detection 2025-11-05 09:43:28 +01:00
d0be1b4a61 excel timetable with employee with each cell 2025-11-05 09:40:26 +01:00
b337fd0e0a using playwright for pdf export instead of pdfkit 2025-11-05 09:20:24 +01:00
badccb4f55 more fancy excel export 2025-11-05 08:31:39 +01:00
9eb9afce1e added timetable export to the export funciton 2025-11-04 23:25:26 +01:00
17d68c2426 Merge branch 'staging' of https://github.com/donpat1to/Schichtenplaner into staging 2025-11-04 22:31:23 +01:00
cff2374f41 fixed klammer usage 2025-11-04 22:28:39 +01:00
3a787875e6 implemented export with pdf and excel library 2025-11-04 15:33:51 +01:00
0b46919e46 fixed role handling in getshiftplanbyid 2025-11-03 23:16:53 +01:00
65cb3e72ba added backend for shiftplan export 2025-11-03 22:50:02 +01:00
dab5164704 added exporting files 2025-11-03 22:07:32 +01:00
7c63bee1b3 updated python installation to break system packages 2025-11-03 10:55:07 +01:00
4c275993e6 changing debian versions from bookworm to bullseye 2025-11-03 10:40:46 +01:00
5c925e3b54 copying python files seperate for scheduling mechanism 2025-11-03 10:33:07 +01:00
11b6ee7672 moved python installation from builder to image 2025-11-03 09:39:42 +01:00
19357d12c1 changed ci to create its own pakcage-lock 2025-11-02 21:14:34 +01:00
8ccd506b7d changed ci to create its own pakcage-lock 2025-11-02 21:13:32 +01:00
e09979aa77 put package-lock.json into the .gitignore 2025-11-02 21:09:25 +01:00
0eda1ac125 creating package lock package on every ci seperate 2025-11-02 20:59:35 +01:00
6aa9511fbe brought package.json back from the grave 2025-11-02 20:57:34 +01:00
ab24f5cf35 npm ci install for prod 2025-11-02 20:48:43 +01:00
2e81ed48c4 more lenient api rate limit 2025-11-02 20:40:59 +01:00
da2b3b0126 pushed new svg 2025-11-01 18:25:36 +01:00
7a87c49703 added configuration over https / http 2025-11-01 17:54:12 +01:00
52f559199d added configuration over https / http 2025-11-01 17:20:45 +01:00
38 changed files with 4567 additions and 6241 deletions

View File

@@ -1,27 +1,29 @@
# === SCHICHTPLANER DOCKER COMPOSE ENVIRONMENT VARIABLES === # .env.template
# Diese Datei wird von docker-compose automatisch geladen # ============================================
# DOCKER COMPOSE ENVIRONMENT TEMPLATE
# Copy this file to .env and adjust values
# ============================================
# Security # Application settings
JWT_SECRET=${JWT_SECRET:-your-secret-key-please-change} NODE_ENV=production
NODE_ENV=${NODE_ENV:-production} JWT_SECRET=your-secret-key-please-change
HOSTNAME=localhost
# Security & Network
TRUST_PROXY_ENABLED=false
TRUSTED_PROXY_IPS=127.0.0.1,::1
FORCE_HTTPS=false
# Database # Database
DB_PATH=${DB_PATH:-/app/data/database.db} DATABASE_PATH=/app/data/schichtplaner.db
# Server # Optional features
PORT=${PORT:-3002} ENABLE_PRO=false
DEBUG=false
# App Configuration # Port configuration
APP_TITLE="Shift Planning App" APP_PORT=3002
ENABLE_PRO=${ENABLE_PRO:-false}
# Trust Proxy Configuration # ============================================
TRUST_PROXY_ENABLED=false # END OF TEMPLATE
TRUSTED_PROXY_IPS= # Your load balancer/reverse proxy IPs # ============================================
TRUSTED_PROXY_HEADER=x-forwarded-for
# Rate Limiting Configuration
RATE_LIMIT_WINDOW_MS=900000
RATE_LIMIT_MAX_REQUESTS=100
RATE_LIMIT_SKIP_PATHS=/api/health,/api/status
RATE_LIMIT_WHITELIST=127.0.0.1,::1

View File

@@ -83,9 +83,13 @@ jobs:
with: with:
node-version: '20' node-version: '20'
- name: Create package-lock.json
working-directory: .
run: npm i --package-lock-only
- name: Install backend dependencies - name: Install backend dependencies
working-directory: ./backend working-directory: ./backend
run: npm install run: npm ci
- name: Run TypeScript check - name: Run TypeScript check
working-directory: ./backend working-directory: ./backend

1
.gitignore vendored
View File

@@ -57,6 +57,7 @@ yarn-error.log*
# Build outputs # Build outputs
dist/ dist/
build/ build/
package-lock.json
# Environment variables # Environment variables
.env .env

View File

@@ -1,22 +1,17 @@
# Single stage build for workspaces # Single stage build for workspaces
FROM node:20-bullseye AS builder FROM node:20-bookworm AS builder
WORKDIR /app WORKDIR /app
# Install Python + OR-Tools
RUN apt-get update && apt-get install -y python3 python3-pip build-essential \
&& pip install --no-cache-dir ortools
# Create symlink so python3 is callable as python
RUN ln -sf /usr/bin/python3 /usr/bin/python
# Copy root package files first # Copy root package files first
COPY package*.json ./ COPY package*.json ./
COPY tsconfig.base.json ./ COPY tsconfig.base.json ./
COPY ecosystem.config.cjs ./ COPY ecosystem.config.cjs ./
# Install root dependencies # Install root dependencies
RUN npm install --only=production #RUN npm install --only=production
RUN npm i --package-lock-only
RUN npm ci
# Copy workspace files # Copy workspace files
COPY backend/ ./backend/ COPY backend/ ./backend/
@@ -30,10 +25,7 @@ RUN npm install --workspace=frontend
RUN npm run build --only=production --workspace=backend RUN npm run build --only=production --workspace=backend
# Build frontend # Build frontend
RUN npm run build --workspace=frontend RUN npm run build --only=production --workspace=frontend
# Verify Python and OR-Tools installation
RUN python -c "from ortools.sat.python import cp_model; print('OR-Tools installed successfully')"
# Production stage # Production stage
FROM node:20-bookworm FROM node:20-bookworm
@@ -57,7 +49,20 @@ COPY --from=builder /app/frontend/dist/ ./frontend-build/
COPY --from=builder /app/ecosystem.config.cjs ./ COPY --from=builder /app/ecosystem.config.cjs ./
COPY --from=builder /app/backend/src/database/ ./dist/database/ COPY --from=builder /app/backend/src/database/ ./dist/database/
COPY --from=builder /app/backend/src/database/ ./database/ # should be obsolete with the line above
#COPY --from=builder /app/backend/src/database/ ./database/
COPY --from=builder /app/backend/src/python-scripts/ ./python-scripts/
# Install Python + OR-Tools
RUN apt-get update && apt-get install -y python3 python3-pip build-essential \
&& pip install --no-cache-dir --break-system-packages ortools
# Create symlink so python3 is callable as python
RUN ln -sf /usr/bin/python3 /usr/bin/python
# Verify Python and OR-Tools installation
RUN python -c "from ortools.sat.python import cp_model; print('OR-Tools installed successfully')"
# Copy init script and env template # Copy init script and env template
COPY docker-init.sh /usr/local/bin/ COPY docker-init.sh /usr/local/bin/

View File

@@ -1,6 +1,91 @@
# Schichtenplaner # Schichtenplaner
Aufteilung der Schichten unter Mitarbeitern
A web application for planning and distributing work shifts among employees. Manage your team's schedules, handle employee availability, and automatically generate optimized shift plans.
## Features
- Employee management with availability tracking
- Shift plan creation and management
- Automated scheduling optimization using constraint programming (OR-Tools CP-SAT)
- Excel export functionality
- User authentication with JWT
- Responsive web interface
---
## For Developers
### Tech Stack
**Frontend:**
- React 19 with TypeScript
- Vite 6 (build tool & dev server)
- React Router DOM (routing)
- date-fns (date handling)
- Framer Motion (animations)
**Backend:**
- Express.js with TypeScript
- SQLite3 (database)
- JWT authentication
- Helmet (security headers)
- express-rate-limit (rate limiting)
- OR-Tools CP-SAT (Python - scheduling optimization)
- ExcelJS (Excel exports)
**Infrastructure:**
- npm workspaces (monorepo)
- Docker support
### Prerequisites
- Node.js (v18+)
- Python 3 with OR-Tools (`pip install ortools`)
- npm
### Getting Started
```bash
# Install dependencies
npm install
# Run development server (frontend + backend)
npm run dev
# Build all packages
npm run build:all
```
### Project Structure
```
schichtenplaner/
├── frontend/ # React application
├── backend/ # Express API server
├── premium/ # Premium features (optional)
└── package.json # Root monorepo config
```
### Available Scripts
| Command | Description |
|---------|-------------|
| `npm run dev` | Start both frontend and backend in development mode |
| `npm run dev:frontend` | Start frontend only |
| `npm run dev:backend` | Start backend only |
| `npm run build:all` | Build frontend and backend |
| `npm run docker:build` | Build Docker image |
| `npm run docker:run` | Run Docker container |
### Environment Variables
The backend requires these environment variables in production:
- `NODE_ENV` - Set to `production` or `development`
- `JWT_SECRET` - Secret key for JWT token signing
- `TRUST_PROXY_ENABLED` - Enable/disable proxy trust (default: true)
- `TRUSTED_PROXY_IPS` - Comma-separated list of trusted proxy IPs
---
## 🧾 License ## 🧾 License

View File

@@ -4,7 +4,9 @@
"type": "module", "type": "module",
"scripts": { "scripts": {
"dev": "npm run build && npx tsx src/server.ts", "dev": "npm run build && npx tsx src/server.ts",
"dev:single": "cross-env NODE_ENV=development TRUST_PROXY_ENABLED=false npx tsx src/server.ts", "dev:single": "cross-env NODE_ENV=development TRUST_PROXY_ENABLED=false SEED_TEST_DATA=true npx tsx src/server.ts",
"seed:test-data": "npx tsx src/scripts/seedTestData.ts",
"dev:all": "npm run dev:single",
"build": "tsc", "build": "tsc",
"start": "node dist/server.js", "start": "node dist/server.js",
"prestart": "npm run build", "prestart": "npm run build",
@@ -16,7 +18,7 @@
"dependencies": { "dependencies": {
"@types/bcrypt": "^6.0.0", "@types/bcrypt": "^6.0.0",
"@types/node": "24.9.2", "@types/node": "24.9.2",
"vite":"7.1.12", "vite": "7.1.12",
"bcrypt": "^6.0.0", "bcrypt": "^6.0.0",
"bcryptjs": "^2.4.3", "bcryptjs": "^2.4.3",
"express": "^4.18.2", "express": "^4.18.2",
@@ -25,7 +27,9 @@
"uuid": "^9.0.0", "uuid": "^9.0.0",
"express-rate-limit": "8.1.0", "express-rate-limit": "8.1.0",
"helmet": "8.1.0", "helmet": "8.1.0",
"express-validator": "7.3.0" "express-validator": "7.3.0",
"exceljs": "4.4.0",
"playwright-chromium": "^1.37.0"
}, },
"devDependencies": { "devDependencies": {
"@types/bcryptjs": "^2.4.2", "@types/bcryptjs": "^2.4.2",

File diff suppressed because it is too large Load Diff

View File

@@ -5,11 +5,11 @@ import { Request } from 'express';
const getClientIP = (req: Request): string => { const getClientIP = (req: Request): string => {
// Read from environment which header to trust // Read from environment which header to trust
const trustedHeader = process.env.TRUSTED_PROXY_HEADER || 'x-forwarded-for'; const trustedHeader = process.env.TRUSTED_PROXY_HEADER || 'x-forwarded-for';
const forwarded = req.headers[trustedHeader]; const forwarded = req.headers[trustedHeader];
const realIp = req.headers['x-real-ip']; const realIp = req.headers['x-real-ip'];
const cfConnectingIp = req.headers['cf-connecting-ip']; // Cloudflare const cfConnectingIp = req.headers['cf-connecting-ip']; // Cloudflare
// If we have a forwarded header and trust proxy is configured // If we have a forwarded header and trust proxy is configured
if (forwarded) { if (forwarded) {
if (Array.isArray(forwarded)) { if (Array.isArray(forwarded)) {
@@ -22,66 +22,96 @@ const getClientIP = (req: Request): string => {
return firstIP; return firstIP;
} }
} }
// Cloudflare support // Cloudflare support
if (cfConnectingIp) { if (cfConnectingIp) {
console.log(`🔍 Using Cloudflare IP: ${cfConnectingIp}`); console.log(`🔍 Using Cloudflare IP: ${cfConnectingIp}`);
return cfConnectingIp.toString(); return cfConnectingIp.toString();
} }
// Fallback to x-real-ip // Fallback to x-real-ip
if (realIp) { if (realIp) {
console.log(`🔍 Using x-real-ip: ${realIp}`); console.log(`🔍 Using x-real-ip: ${realIp}`);
return realIp.toString(); return realIp.toString();
} }
// Final fallback to connection remote address // Final fallback to connection remote address
const remoteAddress = req.socket.remoteAddress || req.ip || 'unknown'; const remoteAddress = req.socket.remoteAddress || req.ip || 'unknown';
console.log(`🔍 Using remote address: ${remoteAddress}`); console.log(`🔍 Using remote address: ${remoteAddress}`);
return remoteAddress; return remoteAddress;
}; };
// Helper to check if an IP is a loopback address (IPv4 or IPv6)
const isLoopbackAddress = (ip: string): boolean => {
// IPv4 loopback: 127.0.0.0/8
if (ip.startsWith('127.') || ip === 'localhost') {
return true;
}
// IPv6 loopback: ::1
// Also handle IPv4-mapped IPv6 addresses like ::ffff:127.0.0.1
if (ip === '::1' || ip === '::ffff:127.0.0.1') {
return true;
}
// Handle full IPv6 loopback notation
if (ip.toLowerCase().startsWith('0000:0000:0000:0000:0000:0000:0000:0001') ||
ip.toLowerCase() === '0:0:0:0:0:0:0:1') {
return true;
}
return false;
};
// Helper to check if request should be limited // Helper to check if request should be limited
const shouldSkipLimit = (req: Request): boolean => { const shouldSkipLimit = (req: Request): boolean => {
const skipPaths = [ const skipPaths = [
'/api/health', '/api/health',
'/api/setup/status', '/api/setup/status',
'/api/auth/validate' '/api/auth/validate',
'/api/auth/me',
]; ];
// Skip for successful GET requests (data fetching) // Skip for successful GET requests (data fetching)
if (req.method === 'GET' && req.path.startsWith('/api/')) { if (req.method === 'GET' && req.path.startsWith('/api/')) {
return true; return true;
} }
const clientIP = getClientIP(req);
// Skip for loopback addresses (local development)
if (isLoopbackAddress(clientIP)) {
console.log(`✅ Loopback address skipped: ${clientIP}`);
return true;
}
// Skip for whitelisted IPs from environment // Skip for whitelisted IPs from environment
const whitelist = process.env.RATE_LIMIT_WHITELIST?.split(',') || []; const whitelist = process.env.RATE_LIMIT_WHITELIST?.split(',') || [];
const clientIP = getClientIP(req);
if (whitelist.includes(clientIP)) { if (whitelist.includes(clientIP)) {
console.log(`✅ IP whitelisted: ${clientIP}`); console.log(`✅ IP whitelisted: ${clientIP}`);
return true; return true;
} }
return skipPaths.includes(req.path); return skipPaths.includes(req.path);
}; };
// Environment-based configuration // Environment-based configuration
const getRateLimitConfig = () => { const getRateLimitConfig = () => {
const isProduction = process.env.NODE_ENV === 'production'; const isProduction = process.env.NODE_ENV === 'production';
return { return {
windowMs: parseInt(process.env.RATE_LIMIT_WINDOW_MS || '900000'), // 15 minutes default windowMs: parseInt(process.env.RATE_LIMIT_WINDOW_MS || '900000'), // 15 minutes default
max: isProduction max: isProduction
? parseInt(process.env.RATE_LIMIT_MAX_REQUESTS || '100') // Stricter in production ? parseInt(process.env.RATE_LIMIT_MAX_REQUESTS || '50') // Stricter in production
: parseInt(process.env.RATE_LIMIT_MAX_REQUESTS || '1000'), // More lenient in development : parseInt(process.env.RATE_LIMIT_MAX_REQUESTS || '100'), // More lenient in development
// Development-specific relaxations // Development-specific relaxations
skip: (req: Request) => { skip: (req: Request) => {
// Skip all GET requests in development for easier testing // Skip all GET requests in development for easier testing
if (!isProduction && req.method === 'GET') { if (!isProduction && req.method === 'GET') {
return true; return true;
} }
return shouldSkipLimit(req); return shouldSkipLimit(req);
} }
}; };
@@ -90,8 +120,8 @@ const getRateLimitConfig = () => {
// Main API limiter - nur für POST/PUT/DELETE // Main API limiter - nur für POST/PUT/DELETE
export const apiLimiter = rateLimit({ export const apiLimiter = rateLimit({
...getRateLimitConfig(), ...getRateLimitConfig(),
message: { message: {
error: 'Zu viele Anfragen, bitte verlangsamen Sie Ihre Aktionen' error: 'Zu viele Anfragen, bitte verlangsamen Sie Ihre Aktionen'
}, },
standardHeaders: true, standardHeaders: true,
legacyHeaders: false, legacyHeaders: false,
@@ -99,8 +129,8 @@ export const apiLimiter = rateLimit({
handler: (req, res) => { handler: (req, res) => {
const clientIP = getClientIP(req); const clientIP = getClientIP(req);
console.warn(`🚨 Rate limit exceeded for IP: ${clientIP}, Path: ${req.path}, Method: ${req.method}`); console.warn(`🚨 Rate limit exceeded for IP: ${clientIP}, Path: ${req.path}, Method: ${req.method}`);
res.status(429).json({ res.status(429).json({
error: 'Zu viele Anfragen', error: 'Zu viele Anfragen',
message: 'Bitte versuchen Sie es später erneut', message: 'Bitte versuchen Sie es später erneut',
retryAfter: '15 Minuten', retryAfter: '15 Minuten',
@@ -112,9 +142,9 @@ export const apiLimiter = rateLimit({
// Strict limiter for auth endpoints // Strict limiter for auth endpoints
export const authLimiter = rateLimit({ export const authLimiter = rateLimit({
windowMs: 15 * 60 * 1000, windowMs: 15 * 60 * 1000,
max: parseInt(process.env.AUTH_RATE_LIMIT_MAX_REQUESTS || '5'), max: parseInt(process.env.AUTH_RATE_LIMIT_MAX_REQUESTS || '50'),
message: { message: {
error: 'Zu viele Login-Versuche, bitte versuchen Sie es später erneut' error: 'Zu viele Login-Versuche, bitte versuchen Sie es später erneut'
}, },
standardHeaders: true, standardHeaders: true,
legacyHeaders: false, legacyHeaders: false,
@@ -123,8 +153,8 @@ export const authLimiter = rateLimit({
handler: (req, res) => { handler: (req, res) => {
const clientIP = getClientIP(req); const clientIP = getClientIP(req);
console.warn(`🚨 Auth rate limit exceeded for IP: ${clientIP}`); console.warn(`🚨 Auth rate limit exceeded for IP: ${clientIP}`);
res.status(429).json({ res.status(429).json({
error: 'Zu viele Login-Versuche', error: 'Zu viele Login-Versuche',
message: 'Aus Sicherheitsgründen wurde Ihr Konto temporär gesperrt', message: 'Aus Sicherheitsgründen wurde Ihr Konto temporär gesperrt',
retryAfter: '15 Minuten' retryAfter: '15 Minuten'
@@ -135,7 +165,7 @@ export const authLimiter = rateLimit({
// Separate limiter for expensive endpoints // Separate limiter for expensive endpoints
export const expensiveEndpointLimiter = rateLimit({ export const expensiveEndpointLimiter = rateLimit({
windowMs: 15 * 60 * 1000, windowMs: 15 * 60 * 1000,
max: parseInt(process.env.EXPENSIVE_ENDPOINT_LIMIT || '10'), max: parseInt(process.env.EXPENSIVE_ENDPOINT_LIMIT || '20'),
message: { message: {
error: 'Zu viele Anfragen für diese Ressource' error: 'Zu viele Anfragen für diese Ressource'
}, },

View File

@@ -388,6 +388,111 @@ export const validateCreateFromPreset = [
.withMessage('isTemplate must be a boolean') .withMessage('isTemplate must be a boolean')
]; ];
// ===== TIME SLOT VALIDATION =====
export const validateTimeSlot = [
body('name')
.isLength({ min: 1, max: 100 })
.withMessage('Time slot name must be between 1-100 characters')
.trim()
.escape(),
body('startTime')
.matches(/^([0-1]?[0-9]|2[0-3]):[0-5][0-9]$/)
.withMessage('Start time must be in HH:MM format'),
body('endTime')
.matches(/^([0-1]?[0-9]|2[0-3]):[0-5][0-9]$/)
.withMessage('End time must be in HH:MM format'),
body('description')
.optional()
.isLength({ max: 500 })
.withMessage('Description cannot exceed 500 characters')
.trim()
.escape()
];
export const validateTimeSlotUpdate = [
body('name')
.optional()
.isLength({ min: 1, max: 100 })
.withMessage('Time slot name must be between 1-100 characters')
.trim()
.escape(),
body('startTime')
.optional()
.matches(/^([0-1]?[0-9]|2[0-3]):[0-5][0-9]$/)
.withMessage('Start time must be in HH:MM format'),
body('endTime')
.optional()
.matches(/^([0-1]?[0-9]|2[0-3]):[0-5][0-9]$/)
.withMessage('End time must be in HH:MM format'),
body('description')
.optional()
.isLength({ max: 500 })
.withMessage('Description cannot exceed 500 characters')
.trim()
.escape()
];
export const validateSlotId = [
param('slotId')
.isUUID()
.withMessage('Slot ID must be a valid UUID')
];
// ===== SHIFT VALIDATION =====
export const validateShiftCreate = [
body('timeSlotId')
.isUUID()
.withMessage('Time slot ID must be a valid UUID'),
body('dayOfWeek')
.isInt({ min: 1, max: 7 })
.withMessage('Day of week must be between 1-7 (Monday-Sunday)'),
body('requiredEmployees')
.optional()
.isInt({ min: 1, max: 10 })
.withMessage('Required employees must be between 1-10'),
body('color')
.optional()
.isHexColor()
.withMessage('Color must be a valid hex color')
];
export const validateShiftUpdate = [
body('timeSlotId')
.optional()
.isUUID()
.withMessage('Time slot ID must be a valid UUID'),
body('dayOfWeek')
.optional()
.isInt({ min: 1, max: 7 })
.withMessage('Day of week must be between 1-7 (Monday-Sunday)'),
body('requiredEmployees')
.optional()
.isInt({ min: 1, max: 10 })
.withMessage('Required employees must be between 1-10'),
body('color')
.optional()
.isHexColor()
.withMessage('Color must be a valid hex color')
];
export const validateShiftId = [
param('shiftId')
.isUUID()
.withMessage('Shift ID must be a valid UUID')
];
// ===== SCHEDULED SHIFTS VALIDATION ===== // ===== SCHEDULED SHIFTS VALIDATION =====
export const validateScheduledShiftUpdate = [ export const validateScheduledShiftUpdate = [
body('assignedEmployees') body('assignedEmployees')

View File

@@ -201,7 +201,7 @@ class UniversalSchedulingSolver:
# Solve with callback # Solve with callback
callback = SimpleSolutionCallback() callback = SimpleSolutionCallback()
status = self.solver.SolveWithSolutionCallback(self.model, callback) status = self.solver.Solve(self.model, callback)
result = self._format_solution(status, cp_vars, model_data) result = self._format_solution(status, cp_vars, model_data)
result['metadata']['constraintsAdded'] = constraints_added result['metadata']['constraintsAdded'] = constraints_added

View File

@@ -1,20 +1,34 @@
import express from 'express'; import express from 'express';
import { authMiddleware, requireRole } from '../middleware/auth.js'; import { authMiddleware, requireRole } from '../middleware/auth.js';
import { import {
getShiftPlans, getShiftPlans,
getShiftPlan, getShiftPlan,
createShiftPlan, createShiftPlan,
updateShiftPlan, updateShiftPlan,
deleteShiftPlan, deleteShiftPlan,
createFromPreset, createFromPreset,
clearAssignments clearAssignments,
exportShiftPlanToExcel,
exportShiftPlanToPDF,
addTimeSlot,
updateTimeSlot,
deleteTimeSlot,
addShift,
updateShift,
deleteShift
} from '../controllers/shiftPlanController.js'; } from '../controllers/shiftPlanController.js';
import { import {
validateShiftPlan, validateShiftPlan,
validateShiftPlanUpdate, validateShiftPlanUpdate,
validateCreateFromPreset, validateCreateFromPreset,
handleValidationErrors, handleValidationErrors,
validateId validateId,
validateTimeSlot,
validateTimeSlotUpdate,
validateShiftCreate,
validateShiftUpdate,
validateSlotId,
validateShiftId
} from '../middleware/validation.js'; } from '../middleware/validation.js';
const router = express.Router(); const router = express.Router();
@@ -30,4 +44,17 @@ router.put('/:id', validateId, validateShiftPlanUpdate, handleValidationErrors,
router.delete('/:id', validateId, handleValidationErrors, requireRole(['admin', 'maintenance']), deleteShiftPlan); router.delete('/:id', validateId, handleValidationErrors, requireRole(['admin', 'maintenance']), deleteShiftPlan);
router.post('/:id/clear-assignments', validateId, handleValidationErrors, requireRole(['admin', 'maintenance']), clearAssignments); router.post('/:id/clear-assignments', validateId, handleValidationErrors, requireRole(['admin', 'maintenance']), clearAssignments);
router.get('/:id/export/excel', validateId, handleValidationErrors, requireRole(['admin', 'maintenance']), exportShiftPlanToExcel);
router.get('/:id/export/pdf', validateId, handleValidationErrors, requireRole(['admin', 'maintenance']), exportShiftPlanToPDF);
// Time slot management
router.post('/:id/time-slots', validateId, validateTimeSlot, handleValidationErrors, requireRole(['admin', 'maintenance']), addTimeSlot);
router.put('/:id/time-slots/:slotId', validateId, validateSlotId, validateTimeSlotUpdate, handleValidationErrors, requireRole(['admin', 'maintenance']), updateTimeSlot);
router.delete('/:id/time-slots/:slotId', validateId, validateSlotId, handleValidationErrors, requireRole(['admin', 'maintenance']), deleteTimeSlot);
// Shift management
router.post('/:id/shifts', validateId, validateShiftCreate, handleValidationErrors, requireRole(['admin', 'maintenance']), addShift);
router.patch('/:id/shifts/:shiftId', validateId, validateShiftId, validateShiftUpdate, handleValidationErrors, requireRole(['admin', 'maintenance']), updateShift);
router.delete('/:id/shifts/:shiftId', validateId, validateShiftId, handleValidationErrors, requireRole(['admin', 'maintenance']), deleteShift);
export default router; export default router;

View File

@@ -0,0 +1,347 @@
// backend/src/scripts/seedTestData.ts
import { db } from '../services/databaseService.js';
import bcrypt from 'bcryptjs';
import { v4 as uuidv4 } from 'uuid';
import fs from 'fs';
import path from 'path';
import { fileURLToPath } from 'url';
const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
interface TestData {
plan_name: string;
description: string;
period: string;
status: string;
created_by: string;
shifts: {
[day: string]: {
[shiftType: string]: {
time: string;
assignments: { [employeeName: string]: number };
};
};
};
employee_info: {
contract_sizes: { [name: string]: string };
employee_types: { [name: string]: string };
roles: { [name: string]: string };
trainees: { [name: string]: boolean };
can_work_alone: { [name: string]: boolean };
};
availability_scale: {
[key: string]: string;
};
}
function generateEmail(firstname: string, lastname: string): string {
const convertUmlauts = (str: string): string => {
return str
.toLowerCase()
.replace(/ü/g, 'ue')
.replace(/ö/g, 'oe')
.replace(/ä/g, 'ae')
.replace(/ß/g, 'ss');
};
const cleanFirstname = convertUmlauts(firstname).replace(/[^a-z0-9]/g, '');
const cleanLastname = convertUmlauts(lastname).replace(/[^a-z0-9]/g, '');
return `${cleanFirstname}.${cleanLastname}@sp.de`;
}
function mapContractType(germanType: string): 'small' | 'large' | 'flexible' {
switch (germanType) {
case 'groß': return 'large';
case 'klein': return 'small';
case 'flexible': return 'flexible';
default: return 'small';
}
}
function mapDayToNumber(day: string): number {
const dayMap: { [key: string]: number } = {
'monday': 1,
'tuesday': 2,
'wednesday': 3,
'thursday': 4,
'friday': 5,
'saturday': 6,
'sunday': 7
};
return dayMap[day.toLowerCase()] || 1;
}
function parseTimeSlot(time: string): { startTime: string; endTime: string } {
const [start, end] = time.split(' - ');
return {
startTime: start.trim(),
endTime: end.trim()
};
}
export async function seedTestData(): Promise<void> {
try {
console.log('🌱 Starting test data seeding...');
// Read test.json file - adjust path to be relative to project root
//const testDataPath = path.resolve(process.cwd(), './test.json');
const testDataPath = path.resolve(__dirname, './test.json');
console.log('🔍 Looking for test.json at:', testDataPath);
if (!fs.existsSync(testDataPath)) {
console.log('❌ test.json file not found at:', testDataPath);
// Try alternative paths
const alternativePaths = [
//path.resolve(__dirname, '../../../test.json'),
//path.resolve(process.cwd(), '../test.json'),
//path.resolve(__dirname, '../../test.json'),
path.resolve(__dirname, './test.json')
];
for (const altPath of alternativePaths) {
console.log('🔍 Trying alternative path:', altPath);
if (fs.existsSync(altPath)) {
console.log('✅ Found test.json at:', altPath);
// Continue with the found path
break;
}
}
return;
}
const testDataRaw = fs.readFileSync(testDataPath, 'utf-8');
const testData: TestData = JSON.parse(testDataRaw);
console.log('📊 Loaded test data:', {
planName: testData.plan_name,
employeeCount: Object.keys(testData.employee_info.contract_sizes).length,
days: Object.keys(testData.shifts).length
});
// Start transaction
await db.run('BEGIN TRANSACTION');
try {
// 1. Create employees
console.log('👥 Creating employees...');
const employeeMap: { [name: string]: string } = {};
const employeeNames = Object.keys(testData.employee_info.contract_sizes);
for (const name of employeeNames) {
const employeeId = uuidv4();
employeeMap[name] = employeeId;
const [firstname, lastname = ''] = name.split(' ');
const email = generateEmail(firstname, lastname || 'Test');
const passwordHash = await bcrypt.hash('ZebraAux123!', 10);
const contractType = mapContractType(testData.employee_info.contract_sizes[name]);
const employeeType = testData.employee_info.employee_types[name];
const role = testData.employee_info.roles[name];
const isTrainee = testData.employee_info.trainees[name];
const canWorkAlone = testData.employee_info.can_work_alone[name];
// Insert employee
await db.run(
`INSERT INTO employees (
id, email, password, firstname, lastname,
employee_type, contract_type, can_work_alone,
is_trainee, is_active
) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`,
[
employeeId,
email,
passwordHash,
firstname,
lastname || 'Test',
employeeType,
contractType,
canWorkAlone ? 1 : 0,
isTrainee ? 1 : 0,
1
]
);
// Insert role
await db.run(
`INSERT INTO employee_roles (employee_id, role) VALUES (?, ?)`,
[employeeId, role]
);
console.log(`✅ Created employee: ${name} (${email})`);
}
// 2. Create shift plan
console.log('📅 Creating shift plan...');
const planId = uuidv4();
const [startDate, endDate] = testData.period.split(' bis ');
// Use the first admin employee as creator
const adminEmployee = Object.entries(testData.employee_info.roles)
.find(([_, role]) => role === 'admin');
const createdBy = adminEmployee ? employeeMap[adminEmployee[0]] : employeeMap[employeeNames[0]];
await db.run(
`INSERT INTO shift_plans (
id, name, description, start_date, end_date,
is_template, status, created_by
) VALUES (?, ?, ?, ?, ?, ?, ?, ?)`,
[
planId,
testData.plan_name,
testData.description,
startDate.trim(),
endDate.trim(),
0, // is_template = false
'published',
createdBy
]
);
// 3. Create time slots
console.log('⏰ Creating time slots...');
const timeSlotMap: { [key: string]: string } = {};
// Extract unique time slots from shifts
const uniqueTimeSlots = new Set<string>();
Object.values(testData.shifts).forEach(dayShifts => {
Object.values(dayShifts).forEach(shift => {
uniqueTimeSlots.add(shift.time);
});
});
let timeSlotIndex = 0;
for (const time of uniqueTimeSlots) {
const timeSlotId = uuidv4();
const { startTime, endTime } = parseTimeSlot(time);
const name = timeSlotIndex === 0 ? 'Vormittag' : 'Nachmittag';
await db.run(
`INSERT INTO time_slots (id, plan_id, name, start_time, end_time, description)
VALUES (?, ?, ?, ?, ?, ?)`,
[timeSlotId, planId, name, startTime, endTime, `Time slot: ${time}`]
);
timeSlotMap[time] = timeSlotId;
timeSlotIndex++;
}
// 4. Create shifts
console.log('🔄 Creating shifts...');
const shiftMap: { [dayTime: string]: string } = {};
for (const [dayName, dayShifts] of Object.entries(testData.shifts)) {
const dayOfWeek = mapDayToNumber(dayName);
for (const [shiftType, shiftData] of Object.entries(dayShifts)) {
const shiftId = uuidv4();
const timeSlotId = timeSlotMap[shiftData.time];
await db.run(
`INSERT INTO shifts (id, plan_id, time_slot_id, day_of_week, required_employees, color)
VALUES (?, ?, ?, ?, ?, ?)`,
[shiftId, planId, timeSlotId, dayOfWeek, 2, '#3498db']
);
shiftMap[`${dayName}_${shiftType}`] = shiftId;
}
}
// 5. Generate scheduled shifts for one week (for template demonstration)
console.log('📋 Generating scheduled shifts...');
const start = new Date(startDate.trim());
for (let dayOffset = 0; dayOffset < 7; dayOffset++) {
const currentDate = new Date(start);
currentDate.setDate(start.getDate() + dayOffset);
const dayOfWeek = currentDate.getDay() === 0 ? 7 : currentDate.getDay();
const dayName = Object.keys(testData.shifts).find(day =>
mapDayToNumber(day) === dayOfWeek
);
if (dayName && testData.shifts[dayName]) {
for (const [shiftType, shiftData] of Object.entries(testData.shifts[dayName])) {
const scheduledShiftId = uuidv4();
const timeSlotId = timeSlotMap[shiftData.time];
await db.run(
`INSERT INTO scheduled_shifts (id, plan_id, date, time_slot_id, required_employees, assigned_employees)
VALUES (?, ?, ?, ?, ?, ?)`,
[
scheduledShiftId,
planId,
currentDate.toISOString().split('T')[0],
timeSlotId,
2,
JSON.stringify([])
]
);
}
}
}
// 6. Create employee availabilities
console.log('📝 Creating employee availabilities...');
for (const [dayName, dayShifts] of Object.entries(testData.shifts)) {
const dayOfWeek = mapDayToNumber(dayName);
for (const [shiftType, shiftData] of Object.entries(dayShifts)) {
const shiftId = shiftMap[`${dayName}_${shiftType}`];
for (const [employeeName, preferenceLevel] of Object.entries(shiftData.assignments)) {
const employeeId = employeeMap[employeeName];
if (employeeId) {
const availabilityId = uuidv4();
await db.run(
`INSERT INTO employee_availability (id, employee_id, plan_id, shift_id, preference_level)
VALUES (?, ?, ?, ?, ?)`,
[availabilityId, employeeId, planId, shiftId, preferenceLevel]
);
}
}
}
}
await db.run('COMMIT');
console.log('🎉 Test data seeded successfully!');
console.log('📊 Summary:');
console.log(` - Employees: ${employeeNames.length}`);
console.log(` - Shift Plan: ${testData.plan_name}`);
console.log(` - Time Slots: ${Object.keys(timeSlotMap).length}`);
console.log(` - Shifts: ${Object.keys(shiftMap).length}`);
console.log(` - Period: ${testData.period}`);
} catch (error) {
await db.run('ROLLBACK');
console.error('❌ Error during test data seeding:', error);
throw error;
}
} catch (error) {
console.error('❌ Failed to seed test data:', error);
throw error;
}
}
// Run if called directly
if (import.meta.url === `file://${process.argv[1]}`) {
seedTestData()
.then(() => {
console.log('✅ Seed script completed');
process.exit(0);
})
.catch((error) => {
console.error('❌ Seed script failed:', error);
process.exit(1);
});
}

View File

@@ -0,0 +1,235 @@
{
"plan_name": "test",
"description": "Standard Vorlage für ZEBRA: Mo-Do Vormittag+Nachmittag, Fr nur Vormittag",
"period": "2025-10-01 bis 2026-02-01",
"status": "published",
"created_by": "Max Mustermann",
"shifts": {
"monday": {
"early": {
"time": "8:00 - 12:00",
"assignments": {
"Jerome": 2,
"Patrick": 2,
"Andrey": 1,
"Fabian": 2,
"Lu": 3,
"Basti": 1,
"Kilian": 3,
"Gerald": 1,
"Uliana": 2,
"Nico": 1,
"Linuuuus": 1
}
},
"late": {
"time": "11:30 - 15:30",
"assignments": {
"Jerome": 1,
"Patrick": 3,
"Andrey": 1,
"Fabian": 3,
"Lu": 1,
"Basti": 1,
"Kilian": 3,
"Gerald": 3,
"Uliana": 3,
"Nico": 1,
"Linuuuus": 3
}
}
},
"tuesday": {
"early": {
"time": "8:00 - 12:00",
"assignments": {
"Jerome": 2,
"Patrick": 2,
"Andrey": 1,
"Fabian": 2,
"Lu": 3,
"Basti": 1,
"Kilian": 3,
"Gerald": 2,
"Uliana": 1,
"Nico": 1,
"Linuuuus": 2
}
},
"late": {
"time": "11:30 - 15:30",
"assignments": {
"Jerome": 1,
"Patrick": 3,
"Andrey": 1,
"Fabian": 3,
"Lu": 3,
"Basti": 1,
"Kilian": 3,
"Gerald": 2,
"Uliana": 2,
"Nico": 3,
"Linuuuus": 2
}
}
},
"wednesday": {
"early": {
"time": "8:00 - 12:00",
"assignments": {
"Jerome": 2,
"Patrick": 2,
"Andrey": 1,
"Fabian": 2,
"Lu": 3,
"Basti": 3,
"Kilian": 3,
"Gerald": 3,
"Uliana": 2,
"Nico": 3,
"Linuuuus": 2
}
},
"late": {
"time": "11:30 - 15:30",
"assignments": {
"Jerome": 2,
"Patrick": 3,
"Andrey": 1,
"Fabian": 3,
"Lu": 3,
"Basti": 3,
"Kilian": 3,
"Gerald": 3,
"Uliana": 3,
"Nico": 1,
"Linuuuus": 3
}
}
},
"thursday": {
"early": {
"time": "8:00 - 12:00",
"assignments": {
"Jerome": 3,
"Patrick": 3,
"Andrey": 1,
"Fabian": 3,
"Lu": 3,
"Basti": 3,
"Kilian": 3,
"Gerald": 3,
"Uliana": 3,
"Nico": 2,
"Linuuuus": 2
}
},
"late": {
"time": "11:30 - 15:30",
"assignments": {
"Jerome": 1,
"Patrick": 1,
"Andrey": 1,
"Fabian": 1,
"Lu": 3,
"Basti": 3,
"Kilian": 1,
"Gerald": 2,
"Uliana": 3,
"Nico": 3,
"Linuuuus": 3
}
}
},
"friday": {
"early": {
"time": "8:00 - 12:00",
"assignments": {
"Jerome": 1,
"Patrick": 1,
"Andrey": 1,
"Fabian": 1,
"Lu": 1,
"Basti": 3,
"Kilian": 1,
"Gerald": 1,
"Uliana": 1,
"Nico": 3,
"Linuuuus": 3
}
}
}
},
"employee_info": {
"contract_sizes": {
"Jerome": "groß",
"Patrick": "groß",
"Andrey": "groß",
"Fabian": "klein",
"Lu": "klein",
"Basti": "flexible",
"Kilian": "klein",
"Gerald": "groß",
"Uliana": "groß",
"Nico": "klein",
"Linuuuus": "klein"
},
"employee_types": {
"Jerome": "personell",
"Patrick": "personell",
"Andrey": "personell",
"Fabian": "personell",
"Lu": "personell",
"Basti": "manager",
"Kilian": "personell",
"Gerald": "personell",
"Uliana": "personell",
"Nico": "personell",
"Linuuuus": "personell"
},
"roles": {
"Jerome": "user",
"Patrick": "maintenance",
"Andrey": "user",
"Fabian": "user",
"Lu": "user",
"Basti": "admin",
"Kilian": "user",
"Gerald": "user",
"Uliana": "user",
"Nico": "user",
"Linuuuus": "user"
},
"trainees": {
"Jerome": false,
"Patrick": false,
"Andrey": false,
"Fabian": false,
"Lu": false,
"Basti": false,
"Kilian": true,
"Gerald": true,
"Uliana": true,
"Nico": true,
"Linuuuus": false
},
"can_work_alone": {
"Jerome": true,
"Patrick": true,
"Andrey": false,
"Fabian": true,
"Lu": false,
"Basti": false,
"Kilian": false,
"Gerald": false,
"Uliana": false,
"Nico": false,
"Linuuuus": true
}
},
"availability_scale": {
"1": "available",
"2": "limited",
"3": "unavailable"
}
}

View File

@@ -14,9 +14,9 @@ import shiftPlanRoutes from './routes/shiftPlans.js';
import setupRoutes from './routes/setup.js'; import setupRoutes from './routes/setup.js';
import scheduledShifts from './routes/scheduledShifts.js'; import scheduledShifts from './routes/scheduledShifts.js';
import schedulingRoutes from './routes/scheduling.js'; import schedulingRoutes from './routes/scheduling.js';
import { import {
apiLimiter, apiLimiter,
authLimiter, authLimiter,
expensiveEndpointLimiter expensiveEndpointLimiter
} from './middleware/rateLimit.js'; } from './middleware/rateLimit.js';
import { ipSecurityCheck as authIpCheck } from './middleware/auth.js'; import { ipSecurityCheck as authIpCheck } from './middleware/auth.js';
@@ -27,6 +27,15 @@ const __dirname = path.dirname(__filename);
const app = express(); const app = express();
const PORT = 3002; const PORT = 3002;
const isDevelopment = process.env.NODE_ENV === 'development'; const isDevelopment = process.env.NODE_ENV === 'development';
if (isDevelopment) {
console.log('🔧 Running in Development mode');
} else if (process.env.NODE_ENV === 'production') {
console.log('🚀 Running in Production mode');
} else {
console.log('⚠️ NODE_ENV not set, defaulting to Development mode');
console.error('❌ Please set NODE_ENV to "production" or "development" for proper behavior.');
process.exit(1);
}
app.use(authIpCheck); app.use(authIpCheck);
@@ -85,7 +94,7 @@ if (process.env.NODE_ENV === 'production') {
const configureTrustProxy = (): string | string[] | boolean | number => { const configureTrustProxy = (): string | string[] | boolean | number => {
const trustedProxyIps = process.env.TRUSTED_PROXY_IPS; const trustedProxyIps = process.env.TRUSTED_PROXY_IPS;
const trustProxyEnabled = process.env.TRUST_PROXY_ENABLED !== 'false'; // Default true for production const trustProxyEnabled = process.env.TRUST_PROXY_ENABLED !== 'false';
// If explicitly disabled // If explicitly disabled
if (!trustProxyEnabled) { if (!trustProxyEnabled) {
@@ -96,35 +105,38 @@ const configureTrustProxy = (): string | string[] | boolean | number => {
// If specific IPs are provided via environment variable // If specific IPs are provided via environment variable
if (trustedProxyIps) { if (trustedProxyIps) {
console.log('🔒 Trust proxy: Using configured IPs:', trustedProxyIps); console.log('🔒 Trust proxy: Using configured IPs:', trustedProxyIps);
// Handle comma-separated list of IPs/CIDR ranges // Handle comma-separated list of IPs/CIDR ranges
if (trustedProxyIps.includes(',')) { if (trustedProxyIps.includes(',')) {
return trustedProxyIps.split(',').map(ip => ip.trim()); return trustedProxyIps.split(',').map(ip => ip.trim());
} }
// Handle single IP/CIDR // Handle single IP/CIDR
return trustedProxyIps.trim(); return trustedProxyIps.trim();
} }
// Default behavior based on environment // Default behavior for reverse proxy setup
if (process.env.NODE_ENV === 'production') { console.log('🔒 Trust proxy: Using reverse proxy defaults (trust all)');
console.log('🔒 Trust proxy: Using production defaults (private networks)'); return true; // Trust all proxies when behind nginx
return [
'loopback',
'linklocal',
'uniquelocal',
'10.0.0.0/8',
'172.16.0.0/12',
'192.168.0.0/16'
];
} else {
console.log('🔒 Trust proxy: Development mode (disabled)');
return false;
}
}; };
app.set('trust proxy', configureTrustProxy()); app.set('trust proxy', configureTrustProxy());
app.use((req, res, next) => {
const protocol = req.headers['x-forwarded-proto'] || req.protocol;
const isHttps = protocol === 'https';
// Add security warning for HTTP requests
if (!isHttps && process.env.NODE_ENV === 'production') {
res.setHeader('X-Security-Warning', 'This application is being accessed over HTTP. For secure communication, please use HTTPS.');
// Log HTTP access in production
console.warn(`⚠️ HTTP access detected: ${req.method} ${req.path} from ${req.ip}`);
}
next();
});
// Security headers // Security headers
app.use(helmet({ app.use(helmet({
contentSecurityPolicy: { contentSecurityPolicy: {
@@ -138,9 +150,14 @@ app.use(helmet({
objectSrc: ["'none'"], objectSrc: ["'none'"],
mediaSrc: ["'self'"], mediaSrc: ["'self'"],
frameSrc: ["'none'"], frameSrc: ["'none'"],
upgradeInsecureRequests: process.env.FORCE_HTTPS === 'true' ? [] : null
}, },
}, },
hsts: false, hsts: {
maxAge: 31536000,
includeSubDomains: true,
preload: true
}, // Enable HSTS for HTTPS
crossOriginEmbedderPolicy: false crossOriginEmbedderPolicy: false
})); }));
@@ -265,7 +282,7 @@ app.get('*', (req, res, next) => {
// Serve React app for all other routes // Serve React app for all other routes
const frontendPath = '/app/frontend-build'; const frontendPath = '/app/frontend-build';
const indexPath = path.join(frontendPath, 'index.html'); const indexPath = path.join(frontendPath, 'index.html');
if (fs.existsSync(indexPath)) { if (fs.existsSync(indexPath)) {
res.sendFile(indexPath); res.sendFile(indexPath);
} else { } else {
@@ -303,6 +320,16 @@ const initializeApp = async () => {
const { applyMigration } = await import('./scripts/applyMigration.js'); const { applyMigration } = await import('./scripts/applyMigration.js');
await applyMigration(); await applyMigration();
if (isDevelopment && process.env.SEED_TEST_DATA === 'true') {
try {
const { seedTestData } = await import('./scripts/seedTestData.js');
await seedTestData();
console.log('✅ Test data seeded successfully');
} catch (error) {
console.log('⚠️ Test data seeding skipped or failed:', error);
}
}
app.listen(PORT, () => { app.listen(PORT, () => {
console.log('🎉 APPLICATION STARTED SUCCESSFULLY!'); console.log('🎉 APPLICATION STARTED SUCCESSFULLY!');
console.log(`📍 Port: ${PORT}`); console.log(`📍 Port: ${PORT}`);

View File

@@ -6,17 +6,22 @@ services:
image: ghcr.io/donpat1to/schichtenplaner:v1.0.0 image: ghcr.io/donpat1to/schichtenplaner:v1.0.0
environment: environment:
- NODE_ENV=production - NODE_ENV=production
- JWT_SECRET=${JWT_SECRET:-your-secret-key-please-change} - JWT_SECRET=${JWT_SECRET}
ports: - TRUST_PROXY_ENABLED=true
- "3002:3002" - TRUSTED_PROXY_IPS=nginx-proxy,172.0.0.0/8,10.0.0.0/8,192.168.0.0/16
- FORCE_HTTPS=${FORCE_HTTPS:-false}
networks:
- app-network
volumes: volumes:
- app_data:/app/data - app_data:/app/data
restart: unless-stopped restart: unless-stopped
healthcheck: healthcheck:
test: ["CMD", "curl", "-f", "http://localhost:3002/api/health"] test: ["CMD", "wget", "--no-verbose", "--tries=1", "--spider", "http://localhost:3002/api/health"]
interval: 30s interval: 30s
timeout: 10s timeout: 10s
retries: 3 retries: 3
expose:
- "3002"
volumes: volumes:
app_data: app_data:

View File

@@ -3,17 +3,15 @@ set -e
echo "🚀 Container Initialisierung gestartet..." echo "🚀 Container Initialisierung gestartet..."
# Funktion zum Generieren eines sicheren Secrets
generate_secret() { generate_secret() {
length=$1 length=$1
tr -dc 'A-Za-z0-9!@#$%^&*()_+-=' < /dev/urandom | head -c $length tr -dc 'A-Za-z0-9!@#$%^&*()_+-=' < /dev/urandom | head -c $length
} }
# Prüfe ob .env existiert # Create .env if it doesn't exist
if [ ! -f /app/.env ]; then if [ ! -f /app/.env ]; then
echo "📝 Erstelle .env Datei..." echo "📝 Erstelle .env Datei..."
# Verwende vorhandenes JWT_SECRET oder generiere ein neues
if [ -z "$JWT_SECRET" ] || [ "$JWT_SECRET" = "your-secret-key-please-change" ]; then if [ -z "$JWT_SECRET" ] || [ "$JWT_SECRET" = "your-secret-key-please-change" ]; then
export JWT_SECRET=$(generate_secret 64) export JWT_SECRET=$(generate_secret 64)
echo "🔑 Automatisch sicheres JWT Secret generiert" echo "🔑 Automatisch sicheres JWT Secret generiert"
@@ -21,30 +19,37 @@ if [ ! -f /app/.env ]; then
echo "🔑 Verwende vorhandenes JWT Secret aus Umgebungsvariable" echo "🔑 Verwende vorhandenes JWT Secret aus Umgebungsvariable"
fi fi
# Erstelle .env aus Template mit envsubst # Create .env with all proxy settings
envsubst < /app/.env.template > /app/.env cat > /app/.env << EOF
echo "✅ .env Datei erstellt" NODE_ENV=production
JWT_SECRET=${JWT_SECRET}
TRUST_PROXY_ENABLED=${TRUST_PROXY_ENABLED:-true}
TRUSTED_PROXY_IPS=${TRUSTED_PROXY_IPS:-172.0.0.0/8,10.0.0.0/8,192.168.0.0/16}
HOSTNAME=${HOSTNAME:-localhost}
EOF
echo "✅ .env Datei erstellt"
else else
echo " .env Datei existiert bereits" echo " .env Datei existiert bereits"
# Wenn .env existiert, aber JWT_SECRET Umgebungsvariable gesetzt ist, aktualisiere sie # Update JWT_SECRET if provided
if [ -n "$JWT_SECRET" ] && [ "$JWT_SECRET" != "your-secret-key-please-change" ]; then if [ -n "$JWT_SECRET" ] && [ "$JWT_SECRET" != "your-secret-key-please-change" ]; then
echo "🔑 Aktualisiere JWT Secret in .env Datei" echo "🔑 Aktualisiere JWT Secret in .env Datei"
# Aktualisiere nur das JWT_SECRET in der .env Datei
sed -i "s/^JWT_SECRET=.*/JWT_SECRET=$JWT_SECRET/" /app/.env sed -i "s/^JWT_SECRET=.*/JWT_SECRET=$JWT_SECRET/" /app/.env
fi fi
fi fi
# Validiere dass JWT_SECERT nicht der Standardwert ist # Validate JWT_SECRET
if grep -q "JWT_SECRET=your-secret-key-please-change" /app/.env; then if grep -q "JWT_SECRET=your-secret-key-please-change" /app/.env; then
echo "❌ FEHLER: Standard JWT Secret in .env gefunden!" echo "❌ FEHLER: Standard JWT Secret in .env gefunden!"
echo "❌ Bitte setzen Sie JWT_SECRET Umgebungsvariable" echo "❌ Bitte setzen Sie JWT_SECRET Umgebungsvariable"
exit 1 exit 1
fi fi
# Setze sichere Berechtigungen
chmod 600 /app/.env chmod 600 /app/.env
echo "🔧 Proxy Configuration:"
echo " - TRUST_PROXY_ENABLED: ${TRUST_PROXY_ENABLED:-true}"
echo " - TRUSTED_PROXY_IPS: ${TRUSTED_PROXY_IPS:-172.0.0.0/8,10.0.0.0/8,192.168.0.0/16}"
echo "🔧 Starte Anwendung..." echo "🔧 Starte Anwendung..."
exec "$@" exec "$@"

178
frontend/donpat1to.svg Normal file

File diff suppressed because one or more lines are too long

After

Width:  |  Height:  |  Size: 102 KiB

View File

@@ -2,7 +2,7 @@
<html lang="en"> <html lang="en">
<head> <head>
<meta charset="UTF-8" /> <meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/vite.svg" /> <link rel="icon" type="image/svg+xml" href="/donpat1to.svg" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" /> <meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Shift Planning App</title> <title>Shift Planning App</title>
</head> </head>

View File

@@ -7,7 +7,9 @@
"react": "^19.0.0", "react": "^19.0.0",
"react-dom": "^19.0.0", "react-dom": "^19.0.0",
"react-router-dom": "^6.28.0", "react-router-dom": "^6.28.0",
"date-fns": "4.1.0" "date-fns": "4.1.0",
"@vitejs/plugin-react": "^4.3.3",
"vite": "^6.0.7"
}, },
"devDependencies": { "devDependencies": {
"@types/node": "20.19.23", "@types/node": "20.19.23",
@@ -25,7 +27,9 @@
"esbuild": "^0.21.0", "esbuild": "^0.21.0",
"terser": "5.44.0", "terser": "5.44.0",
"babel-plugin-transform-remove-console": "6.9.4", "babel-plugin-transform-remove-console": "6.9.4",
"framer-motion": "12.23.24" "framer-motion": "12.23.24",
"file-saver": "2.0.5",
"@types/file-saver": "2.0.5"
}, },
"scripts": { "scripts": {
"dev": "vite dev", "dev": "vite dev",

View File

@@ -15,6 +15,8 @@ import EmployeeManagement from './pages/Employees/EmployeeManagement';
import Settings from './pages/Settings/Settings'; import Settings from './pages/Settings/Settings';
import Help from './pages/Help/Help'; import Help from './pages/Help/Help';
import Setup from './pages/Setup/Setup'; import Setup from './pages/Setup/Setup';
import ErrorBoundary from './components/ErrorBoundary/ErrorBoundary';
import SecurityWarning from './components/SecurityWarning/SecurityWarning';
// Free Footer Link Pages (always available) // Free Footer Link Pages (always available)
import FAQ from './components/Layout/FooterLinks/FAQ/FAQ'; import FAQ from './components/Layout/FooterLinks/FAQ/FAQ';
@@ -160,14 +162,17 @@ const AppContent: React.FC = () => {
function App() { function App() {
return ( return (
<NotificationProvider> <ErrorBoundary>
<AuthProvider> <NotificationProvider>
<Router> <AuthProvider>
<NotificationContainer /> <Router>
<AppContent /> <SecurityWarning />
</Router> <NotificationContainer />
</AuthProvider> <AppContent />
</NotificationProvider> </Router>
</AuthProvider>
</NotificationProvider>
</ErrorBoundary>
); );
} }

View File

@@ -0,0 +1,101 @@
// src/components/ErrorBoundary/ErrorBoundary.tsx
import React from 'react';
interface Props {
children: React.ReactNode;
fallback?: React.ReactNode;
}
interface State {
hasError: boolean;
error?: Error;
}
class ErrorBoundary extends React.Component<Props, State> {
constructor(props: Props) {
super(props);
this.state = { hasError: false };
}
static getDerivedStateFromError(error: Error): State {
return { hasError: true, error };
}
componentDidCatch(error: Error, errorInfo: React.ErrorInfo) {
console.error('🚨 Application Error:', error);
console.error('📋 Error Details:', errorInfo);
// In production, send to your error reporting service
// logErrorToService(error, errorInfo);
}
render() {
if (this.state.hasError) {
// You can render any custom fallback UI
return this.props.fallback || (
<div style={{
padding: '40px',
textAlign: 'center',
fontFamily: 'Arial, sans-serif'
}}>
<div style={{ fontSize: '48px', marginBottom: '20px' }}></div>
<h2>Oops! Something went wrong</h2>
<p style={{ margin: '20px 0', color: '#666' }}>
We encountered an unexpected error. Please try refreshing the page.
</p>
<div style={{ marginTop: '30px' }}>
<button
onClick={() => window.location.reload()}
style={{
padding: '10px 20px',
backgroundColor: '#007bff',
color: 'white',
border: 'none',
borderRadius: '4px',
cursor: 'pointer',
marginRight: '10px'
}}
>
Refresh Page
</button>
<button
onClick={() => this.setState({ hasError: false })}
style={{
padding: '10px 20px',
backgroundColor: '#6c757d',
color: 'white',
border: 'none',
borderRadius: '4px',
cursor: 'pointer'
}}
>
Try Again
</button>
</div>
{process.env.NODE_ENV === 'development' && this.state.error && (
<details style={{
marginTop: '20px',
textAlign: 'left',
background: '#f8f9fa',
padding: '15px',
borderRadius: '4px'
}}>
<summary>Error Details (Development)</summary>
<pre style={{
whiteSpace: 'pre-wrap',
fontSize: '12px',
color: '#dc3545'
}}>
{this.state.error.stack}
</pre>
</details>
)}
</div>
);
}
return this.props.children;
}
}
export default ErrorBoundary;

View File

@@ -0,0 +1,122 @@
import React, { useEffect } from 'react';
import { BUTTON_COLORS } from '../../utils/buttonStyles';
interface ModalProps {
isOpen: boolean;
onClose: () => void;
title: string;
children: React.ReactNode;
width?: string;
}
const Modal: React.FC<ModalProps> = ({
isOpen,
onClose,
title,
children,
width = '400px'
}) => {
useEffect(() => {
const handleEscape = (e: KeyboardEvent) => {
if (e.key === 'Escape') {
onClose();
}
};
if (isOpen) {
document.addEventListener('keydown', handleEscape);
document.body.style.overflow = 'hidden';
}
return () => {
document.removeEventListener('keydown', handleEscape);
document.body.style.overflow = 'unset';
};
}, [isOpen, onClose]);
if (!isOpen) return null;
const overlayStyle: React.CSSProperties = {
position: 'fixed',
top: 0,
left: 0,
right: 0,
bottom: 0,
backgroundColor: 'rgba(0, 0, 0, 0.5)',
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
zIndex: 9999,
};
const modalStyle: React.CSSProperties = {
backgroundColor: 'white',
borderRadius: '8px',
boxShadow: '0 4px 20px rgba(0, 0, 0, 0.2)',
width: width,
maxWidth: '90vw',
maxHeight: '90vh',
overflow: 'auto',
};
const headerStyle: React.CSSProperties = {
display: 'flex',
justifyContent: 'space-between',
alignItems: 'center',
padding: '16px 20px',
borderBottom: '1px solid #dee2e6',
backgroundColor: BUTTON_COLORS.primary,
color: 'white',
borderRadius: '8px 8px 0 0',
};
const titleStyle: React.CSSProperties = {
margin: 0,
fontSize: '18px',
fontWeight: 'bold',
};
const closeButtonStyle: React.CSSProperties = {
background: 'none',
border: 'none',
color: 'white',
fontSize: '24px',
cursor: 'pointer',
padding: '0',
lineHeight: 1,
opacity: 0.8,
};
const contentStyle: React.CSSProperties = {
padding: '20px',
};
const handleOverlayClick = (e: React.MouseEvent) => {
if (e.target === e.currentTarget) {
onClose();
}
};
return (
<div style={overlayStyle} onClick={handleOverlayClick}>
<div style={modalStyle} onClick={(e) => e.stopPropagation()}>
<div style={headerStyle}>
<h3 style={titleStyle}>{title}</h3>
<button
onClick={onClose}
style={closeButtonStyle}
onMouseEnter={(e) => { e.currentTarget.style.opacity = '1'; }}
onMouseLeave={(e) => { e.currentTarget.style.opacity = '0.8'; }}
>
&times;
</button>
</div>
<div style={contentStyle}>
{children}
</div>
</div>
</div>
);
};
export default Modal;

View File

@@ -0,0 +1,59 @@
// src/components/SecurityWarning/SecurityWarning.tsx
import React, { useState, useEffect } from 'react';
const SecurityWarning: React.FC = () => {
const [isHttp, setIsHttp] = useState(false);
const [isDismissed, setIsDismissed] = useState(false);
useEffect(() => {
// Check if current protocol is HTTP
const checkProtocol = () => {
setIsHttp(window.location.protocol === 'http:');
};
checkProtocol();
window.addEventListener('load', checkProtocol);
return () => window.removeEventListener('load', checkProtocol);
}, []);
if (!isHttp || isDismissed) {
return null;
}
return (
<div style={{
position: 'fixed',
top: 0,
left: 0,
right: 0,
backgroundColor: '#ff6b35',
color: 'white',
padding: '10px 20px',
textAlign: 'center',
zIndex: 10000,
fontSize: '14px',
fontWeight: 'bold',
boxShadow: '0 2px 4px rgba(0,0,0,0.2)'
}}>
SECURITY WARNING: This site is being accessed over HTTP.
For secure communication, please use HTTPS.
<button
onClick={() => setIsDismissed(true)}
style={{
marginLeft: '15px',
background: 'rgba(255,255,255,0.2)',
border: '1px solid white',
color: 'white',
padding: '2px 8px',
borderRadius: '3px',
cursor: 'pointer'
}}
>
Dismiss
</button>
</div>
);
};
export default SecurityWarning;

View File

@@ -19,6 +19,8 @@ export const designTokens = {
9: '#cda8f0', 9: '#cda8f0',
10: '#ebd7fa', 10: '#ebd7fa',
}, },
manager: '#CC0000',
// Semantic Colors // Semantic Colors
primary: '#51258f', primary: '#51258f',

View File

@@ -317,7 +317,17 @@ const AvailabilityManager: React.FC<AvailabilityManagerProps> = ({
// Convert to array and sort by start time // Convert to array and sort by start time
const sortedTimeSlots = Array.from(allTimeSlots.values()).sort((a, b) => { const sortedTimeSlots = Array.from(allTimeSlots.values()).sort((a, b) => {
return (a.startTime || '').localeCompare(b.startTime || ''); // Convert time strings to minutes for proper numeric comparison
const timeToMinutes = (timeStr: string) => {
if (!timeStr) return 0;
const [hours, minutes] = timeStr.split(':').map(Number);
return hours * 60 + minutes;
};
const minutesA = timeToMinutes(a.startTime);
const minutesB = timeToMinutes(b.startTime);
return minutesA - minutesB; // Ascending order (earliest first)
}); });
return ( return (

View File

@@ -4,6 +4,7 @@ import { ROLE_CONFIG, EMPLOYEE_TYPE_CONFIG } from '../../../models/defaults/empl
import { Employee } from '../../../models/Employee'; import { Employee } from '../../../models/Employee';
import { useAuth } from '../../../contexts/AuthContext'; import { useAuth } from '../../../contexts/AuthContext';
import { useNotification } from '../../../contexts/NotificationContext'; import { useNotification } from '../../../contexts/NotificationContext';
import { ICONS, iconButtonStyle, BUTTON_COLORS } from '../../../utils/buttonStyles';
interface EmployeeListProps { interface EmployeeListProps {
employees: Employee[]; employees: Employee[];
@@ -455,40 +456,20 @@ const EmployeeList: React.FC<EmployeeListProps> = ({
{/* Verfügbarkeit Button */} {/* Verfügbarkeit Button */}
<button <button
onClick={() => onManageAvailability(employee)} onClick={() => onManageAvailability(employee)}
style={{ style={iconButtonStyle(BUTTON_COLORS.info, false)}
padding: '6px 8px',
backgroundColor: '#3498db',
color: 'white',
border: 'none',
borderRadius: '4px',
cursor: 'pointer',
fontSize: '12px',
minWidth: '32px',
height: '32px'
}}
title="Verfügbarkeit verwalten" title="Verfügbarkeit verwalten"
> >
📅 {ICONS.calendar}
</button> </button>
{/* Bearbeiten Button */} {/* Bearbeiten Button */}
{canEdit && ( {canEdit && (
<button <button
onClick={() => onEdit(employee)} onClick={() => onEdit(employee)}
style={{ style={iconButtonStyle(BUTTON_COLORS.edit, false)}
padding: '6px 8px',
backgroundColor: '#f39c12',
color: 'white',
border: 'none',
borderRadius: '4px',
cursor: 'pointer',
fontSize: '12px',
minWidth: '32px',
height: '32px'
}}
title="Mitarbeiter bearbeiten" title="Mitarbeiter bearbeiten"
> >
{ICONS.edit}
</button> </button>
)} )}
@@ -496,20 +477,10 @@ const EmployeeList: React.FC<EmployeeListProps> = ({
{canDelete && ( {canDelete && (
<button <button
onClick={() => handleDeleteClick(employee)} onClick={() => handleDeleteClick(employee)}
style={{ style={iconButtonStyle(BUTTON_COLORS.delete, false)}
padding: '6px 8px',
backgroundColor: '#e74c3c',
color: 'white',
border: 'none',
borderRadius: '4px',
cursor: 'pointer',
fontSize: '12px',
minWidth: '32px',
height: '32px'
}}
title="Mitarbeiter löschen" title="Mitarbeiter löschen"
> >
🗑 {ICONS.delete}
</button> </button>
)} )}

View File

@@ -18,7 +18,7 @@ const ShiftPlanCreate: React.FC = () => {
const [searchParams] = useSearchParams(); const [searchParams] = useSearchParams();
const { showNotification } = useNotification(); const { showNotification } = useNotification();
const { executeWithValidation, isSubmitting } = useBackendValidation(); const { executeWithValidation, isSubmitting } = useBackendValidation();
const [planName, setPlanName] = useState(''); const [planName, setPlanName] = useState('');
const [startDate, setStartDate] = useState(''); const [startDate, setStartDate] = useState('');
const [endDate, setEndDate] = useState(''); const [endDate, setEndDate] = useState('');
@@ -35,9 +35,9 @@ const ShiftPlanCreate: React.FC = () => {
console.log('🔄 Lade verfügbare Vorlagen-Presets...'); console.log('🔄 Lade verfügbare Vorlagen-Presets...');
const data = await shiftPlanService.getTemplatePresets(); const data = await shiftPlanService.getTemplatePresets();
console.log('✅ Presets geladen:', data); console.log('✅ Presets geladen:', data);
setPresets(data); setPresets(data);
// Setze das erste Preset als Standard, falls vorhanden // Setze das erste Preset als Standard, falls vorhanden
if (data.length > 0) { if (data.length > 0) {
setSelectedPreset(data[0].name); setSelectedPreset(data[0].name);
@@ -75,7 +75,7 @@ const ShiftPlanCreate: React.FC = () => {
if (!endDate) { if (!endDate) {
showNotification({ showNotification({
type: 'error', type: 'error',
title: 'Fehlende Angaben', title: 'Fehlende Angaben',
message: 'Bitte wählen Sie ein Enddatum' message: 'Bitte wählen Sie ein Enddatum'
}); });
return; return;
@@ -115,14 +115,14 @@ const ShiftPlanCreate: React.FC = () => {
}); });
console.log('✅ Plan erstellt:', createdPlan); console.log('✅ Plan erstellt:', createdPlan);
// Erfolgsmeldung und Weiterleitung // Erfolgsmeldung und Weiterleitung
showNotification({ showNotification({
type: 'success', type: 'success',
title: 'Erfolg', title: 'Erfolg',
message: 'Schichtplan erfolgreich erstellt!' message: 'Schichtplan erfolgreich erstellt!'
}); });
setTimeout(() => { setTimeout(() => {
navigate(`/shift-plans/${createdPlan.id}`); navigate(`/shift-plans/${createdPlan.id}`);
}, 1500); }, 1500);
@@ -146,20 +146,20 @@ const ShiftPlanCreate: React.FC = () => {
<div className={styles.container}> <div className={styles.container}>
<div className={styles.header}> <div className={styles.header}>
<h1>Neuen Schichtplan erstellen</h1> <h1>Neuen Schichtplan erstellen</h1>
<button <button
onClick={() => navigate(-1)} onClick={() => navigate(-1)}
className={styles.backButton} className={styles.backButton}
disabled={isSubmitting} disabled={isSubmitting}
> >
Zurück Zurück
</button> </button>
</div> </div>
<div className={styles.form}> <div className={styles.form}>
<div className={styles.formGroup}> <div className={styles.formGroup}>
<label>Plan Name:</label> <label>Plan Name:</label>
<input <input
type="text" type="text"
value={planName} value={planName}
onChange={(e) => setPlanName(e.target.value)} onChange={(e) => setPlanName(e.target.value)}
placeholder="z.B. KW 42 2025" placeholder="z.B. KW 42 2025"
@@ -171,8 +171,8 @@ const ShiftPlanCreate: React.FC = () => {
<div className={styles.dateGroup}> <div className={styles.dateGroup}>
<div className={styles.formGroup}> <div className={styles.formGroup}>
<label>Von:</label> <label>Von:</label>
<input <input
type="date" type="date"
value={startDate} value={startDate}
onChange={(e) => setStartDate(e.target.value)} onChange={(e) => setStartDate(e.target.value)}
className={styles.input} className={styles.input}
@@ -182,8 +182,8 @@ const ShiftPlanCreate: React.FC = () => {
<div className={styles.formGroup}> <div className={styles.formGroup}>
<label>Bis:</label> <label>Bis:</label>
<input <input
type="date" type="date"
value={endDate} value={endDate}
onChange={(e) => setEndDate(e.target.value)} onChange={(e) => setEndDate(e.target.value)}
className={styles.input} className={styles.input}
@@ -194,8 +194,8 @@ const ShiftPlanCreate: React.FC = () => {
<div className={styles.formGroup}> <div className={styles.formGroup}>
<label>Vorlage verwenden:</label> <label>Vorlage verwenden:</label>
<select <select
value={selectedPreset} value={selectedPreset}
onChange={(e) => setSelectedPreset(e.target.value)} onChange={(e) => setSelectedPreset(e.target.value)}
className={`${styles.select} ${presets.length === 0 ? styles.empty : ''}`} className={`${styles.select} ${presets.length === 0 ? styles.empty : ''}`}
disabled={isSubmitting} disabled={isSubmitting}
@@ -207,7 +207,7 @@ const ShiftPlanCreate: React.FC = () => {
</option> </option>
))} ))}
</select> </select>
{selectedPreset && ( {selectedPreset && (
<div className={styles.presetDescription}> <div className={styles.presetDescription}>
{getSelectedPresetDescription()} {getSelectedPresetDescription()}
@@ -222,9 +222,9 @@ const ShiftPlanCreate: React.FC = () => {
</div> </div>
<div className={styles.actions}> <div className={styles.actions}>
<button <button
onClick={handleCreate} onClick={handleCreate}
className={styles.createButton} className={styles.createButton}
disabled={isSubmitting || !selectedPreset || !planName.trim() || !startDate || !endDate} disabled={isSubmitting || !selectedPreset || !planName.trim() || !startDate || !endDate}
> >
{isSubmitting ? 'Wird erstellt...' : 'Schichtplan erstellen'} {isSubmitting ? 'Wird erstellt...' : 'Schichtplan erstellen'}

View File

@@ -1,33 +1,67 @@
// frontend/src/pages/ShiftPlans/ShiftPlanEdit.tsx // frontend/src/pages/ShiftPlans/ShiftPlanEdit.tsx
import React, { useState, useEffect } from 'react'; import React, { useState, useEffect, useMemo } from 'react';
import { useParams, useNavigate } from 'react-router-dom'; import { useParams, useNavigate } from 'react-router-dom';
import { shiftPlanService } from '../../services/shiftPlanService'; import { shiftPlanService } from '../../services/shiftPlanService';
import { ShiftPlan, Shift, ScheduledShift } from '../../models/ShiftPlan'; import { ShiftPlan, Shift, TimeSlot } from '../../models/ShiftPlan';
import { useNotification } from '../../contexts/NotificationContext'; import { useNotification } from '../../contexts/NotificationContext';
import { useBackendValidation } from '../../hooks/useBackendValidation'; import { useBackendValidation } from '../../hooks/useBackendValidation';
import { formatTime } from '../../utils/foramatters';
import {
ICONS,
smallDeleteButton,
addTextButton,
cancelTextButton,
addOutlineButton,
BUTTON_COLORS,
} from '../../utils/buttonStyles';
import ShiftCell from './components/ShiftCell';
import TimeSlotEditor from './components/TimeSlotEditor';
import AddDayButton from './components/AddDayButton';
const DAYS_OF_WEEK = [
{ id: 1, name: 'Montag', shortName: 'Mo' },
{ id: 2, name: 'Dienstag', shortName: 'Di' },
{ id: 3, name: 'Mittwoch', shortName: 'Mi' },
{ id: 4, name: 'Donnerstag', shortName: 'Do' },
{ id: 5, name: 'Freitag', shortName: 'Fr' },
{ id: 6, name: 'Samstag', shortName: 'Sa' },
{ id: 7, name: 'Sonntag', shortName: 'So' },
];
const ShiftPlanEdit: React.FC = () => { const ShiftPlanEdit: React.FC = () => {
const { id } = useParams<{ id: string }>(); const { id } = useParams<{ id: string }>();
const navigate = useNavigate(); const navigate = useNavigate();
const { showNotification, confirmDialog } = useNotification(); const { showNotification, confirmDialog } = useNotification();
const { executeWithValidation, isSubmitting } = useBackendValidation(); const { executeWithValidation, isSubmitting } = useBackendValidation();
const [shiftPlan, setShiftPlan] = useState<ShiftPlan | null>(null); const [shiftPlan, setShiftPlan] = useState<ShiftPlan | null>(null);
const [loading, setLoading] = useState(true); const [loading, setLoading] = useState(true);
const [editingShift, setEditingShift] = useState<Shift | null>(null); const [activeDays, setActiveDays] = useState<number[]>([]);
const [newShift, setNewShift] = useState<Partial<Shift>>({
timeSlotId: '', // New time slot form state
dayOfWeek: 1, const [showAddTimeSlot, setShowAddTimeSlot] = useState(false);
requiredEmployees: 1 const [newTimeSlot, setNewTimeSlot] = useState({
name: '',
startTime: '08:00',
endTime: '12:00',
description: '',
}); });
useEffect(() => { useEffect(() => {
loadShiftPlan(); loadShiftPlan();
}, [id]); }, [id]);
useEffect(() => {
if (shiftPlan) {
// Determine active days from existing shifts
const daysWithShifts = new Set(shiftPlan.shifts.map(s => s.dayOfWeek));
setActiveDays(Array.from(daysWithShifts).sort((a, b) => a - b));
}
}, [shiftPlan]);
const loadShiftPlan = async () => { const loadShiftPlan = async () => {
if (!id) return; if (!id) return;
await executeWithValidation(async () => { await executeWithValidation(async () => {
try { try {
const plan = await shiftPlanService.getShiftPlan(id); const plan = await shiftPlanService.getShiftPlan(id);
@@ -41,68 +75,223 @@ const ShiftPlanEdit: React.FC = () => {
}); });
}; };
const handleUpdateShift = async (shift: Shift) => { // Get shift for a specific cell
if (!shiftPlan || !id) return; const getShift = (timeSlotId: string, dayOfWeek: number): Shift | null => {
if (!shiftPlan) return null;
await executeWithValidation(async () => { return shiftPlan.shifts.find(
// Update logic here - will be implemented when backend API is available s => s.timeSlotId === timeSlotId && s.dayOfWeek === dayOfWeek
// For now, just simulate success ) || null;
console.log('Updating shift:', shift);
loadShiftPlan();
setEditingShift(null);
showNotification({
type: 'success',
title: 'Erfolg',
message: 'Schicht wurde erfolgreich aktualisiert.'
});
});
}; };
const handleAddShift = async () => { // Count shifts for a time slot
if (!shiftPlan || !id) return; const getShiftsCountForSlot = (slotId: string): number => {
if (!shiftPlan) return 0;
// Basic frontend validation only return shiftPlan.shifts.filter(s => s.timeSlotId === slotId).length;
if (!newShift.timeSlotId) { };
showNotification({
type: 'error', // Sort time slots by start time (early to late)
title: 'Fehlende Angaben', const sortedTimeSlots = useMemo(() => {
message: 'Bitte wählen Sie einen Zeit-Slot aus.' if (!shiftPlan) return [];
});
return; const timeToMinutes = (timeStr: string): number => {
if (!timeStr) return 0;
const [hours, minutes] = timeStr.split(':').map(Number);
return hours * 60 + minutes;
};
return [...shiftPlan.timeSlots].sort((a, b) => {
const minutesA = timeToMinutes(a.startTime);
const minutesB = timeToMinutes(b.startTime);
return minutesA - minutesB;
});
}, [shiftPlan]);
// Add a new day column
const handleAddDay = (dayOfWeek: number) => {
if (!activeDays.includes(dayOfWeek)) {
setActiveDays([...activeDays, dayOfWeek].sort((a, b) => a - b));
} }
};
if (!newShift.requiredEmployees || newShift.requiredEmployees < 1) {
// Remove a day column (delete all shifts for that day)
const handleRemoveDay = async (dayOfWeek: number) => {
if (!shiftPlan || !id) return;
const shiftsForDay = shiftPlan.shifts.filter(s => s.dayOfWeek === dayOfWeek);
if (shiftsForDay.length > 0) {
const confirmed = await confirmDialog({
title: 'Tag entfernen',
message: `Dieser Tag enthält ${shiftsForDay.length} Schicht(en). Alle Schichten für diesen Tag werden gelöscht. Fortfahren?`,
confirmText: 'Löschen',
cancelText: 'Abbrechen',
type: 'warning'
});
if (!confirmed) return;
// Delete all shifts for this day
await executeWithValidation(async () => {
for (const shift of shiftsForDay) {
await shiftPlanService.deleteShift(id, shift.id);
}
await loadShiftPlan();
showNotification({
type: 'success',
title: 'Erfolg',
message: `Alle Schichten für diesen Tag wurden gelöscht.`
});
});
}
setActiveDays(activeDays.filter(d => d !== dayOfWeek));
};
// Add a new time slot
const handleAddTimeSlot = async () => {
if (!id || !newTimeSlot.name || !newTimeSlot.startTime || !newTimeSlot.endTime) {
showNotification({ showNotification({
type: 'error', type: 'error',
title: 'Fehlende Angaben', title: 'Fehlende Angaben',
message: 'Bitte geben Sie die Anzahl der benötigten Mitarbeiter an.' message: 'Bitte füllen Sie alle Pflichtfelder aus.'
}); });
return; return;
} }
await executeWithValidation(async () => { await executeWithValidation(async () => {
// Add shift logic here - will be implemented when backend API is available await shiftPlanService.addTimeSlot(id, {
// For now, just simulate success name: newTimeSlot.name,
console.log('Adding shift:', newShift); startTime: newTimeSlot.startTime,
endTime: newTimeSlot.endTime,
description: newTimeSlot.description || undefined,
});
showNotification({ showNotification({
type: 'success', type: 'success',
title: 'Erfolg', title: 'Erfolg',
message: 'Neue Schicht wurde hinzugefügt.' message: 'Zeit-Slot wurde hinzugefügt.'
}); });
setNewShift({ setNewTimeSlot({ name: '', startTime: '08:00', endTime: '12:00', description: '' });
timeSlotId: '', setShowAddTimeSlot(false);
dayOfWeek: 1, await loadShiftPlan();
requiredEmployees: 1
});
loadShiftPlan();
}); });
}; };
// Update a time slot
const handleUpdateTimeSlot = async (
slot: TimeSlot,
name: string,
startTime: string,
endTime: string,
description?: string
) => {
if (!id) return;
await executeWithValidation(async () => {
await shiftPlanService.updateTimeSlot(id, slot.id, {
name,
startTime,
endTime,
description,
});
showNotification({
type: 'success',
title: 'Erfolg',
message: 'Zeit-Slot wurde aktualisiert.'
});
await loadShiftPlan();
});
};
// Delete a time slot
const handleDeleteTimeSlot = async (slotId: string) => {
if (!id || !shiftPlan) return;
const shiftsCount = getShiftsCountForSlot(slotId);
const confirmed = await confirmDialog({
title: 'Zeit-Slot löschen',
message: shiftsCount > 0
? `Dieser Zeit-Slot enthält ${shiftsCount} Schicht(en). Alle zugehörigen Schichten werden ebenfalls gelöscht. Fortfahren?`
: 'Möchten Sie diesen Zeit-Slot wirklich löschen?',
confirmText: 'Löschen',
cancelText: 'Abbrechen',
type: 'warning'
});
if (!confirmed) return;
await executeWithValidation(async () => {
await shiftPlanService.deleteTimeSlot(id, slotId);
showNotification({
type: 'success',
title: 'Erfolg',
message: 'Zeit-Slot wurde gelöscht.'
});
await loadShiftPlan();
});
};
// Add a new shift
const handleAddShift = async (
dayOfWeek: number,
timeSlotId: string,
requiredEmployees: number,
color: string
) => {
if (!id) return;
await executeWithValidation(async () => {
await shiftPlanService.addShift(id, {
dayOfWeek,
timeSlotId,
requiredEmployees,
color,
});
showNotification({
type: 'success',
title: 'Erfolg',
message: 'Schicht wurde hinzugefügt.'
});
await loadShiftPlan();
});
};
// Update a shift
const handleUpdateShift = async (
shift: Shift,
requiredEmployees: number,
color: string
) => {
if (!id) return;
await executeWithValidation(async () => {
await shiftPlanService.updateShift(id, shift.id, {
requiredEmployees,
color,
});
showNotification({
type: 'success',
title: 'Erfolg',
message: 'Schicht wurde aktualisiert.'
});
await loadShiftPlan();
});
};
// Delete a shift
const handleDeleteShift = async (shiftId: string) => { const handleDeleteShift = async (shiftId: string) => {
if (!id) return;
const confirmed = await confirmDialog({ const confirmed = await confirmDialog({
title: 'Schicht löschen', title: 'Schicht löschen',
message: 'Möchten Sie diese Schicht wirklich löschen?', message: 'Möchten Sie diese Schicht wirklich löschen?',
@@ -114,20 +303,19 @@ const ShiftPlanEdit: React.FC = () => {
if (!confirmed) return; if (!confirmed) return;
await executeWithValidation(async () => { await executeWithValidation(async () => {
// Delete logic here - will be implemented when backend API is available await shiftPlanService.deleteShift(id, shiftId);
// For now, just simulate success
console.log('Deleting shift:', shiftId);
loadShiftPlan();
showNotification({ showNotification({
type: 'success', type: 'success',
title: 'Erfolg', title: 'Erfolg',
message: 'Schicht wurde erfolgreich gelöscht.' message: 'Schicht wurde gelöscht.'
}); });
await loadShiftPlan();
}); });
}; };
// Publish the shift plan
const handlePublish = async () => { const handlePublish = async () => {
if (!shiftPlan || !id) return; if (!shiftPlan || !id) return;
@@ -136,21 +324,21 @@ const ShiftPlanEdit: React.FC = () => {
...shiftPlan, ...shiftPlan,
status: 'published' status: 'published'
}); });
showNotification({ showNotification({
type: 'success', type: 'success',
title: 'Erfolg', title: 'Erfolg',
message: 'Schichtplan wurde veröffentlicht.' message: 'Schichtplan wurde veröffentlicht.'
}); });
loadShiftPlan(); await loadShiftPlan();
}); });
}; };
if (loading) { if (loading) {
return ( return (
<div style={{ <div style={{
textAlign: 'center', textAlign: 'center',
padding: '40px', padding: '40px',
fontSize: '18px', fontSize: '18px',
color: '#666' color: '#666'
@@ -162,8 +350,8 @@ const ShiftPlanEdit: React.FC = () => {
if (!shiftPlan) { if (!shiftPlan) {
return ( return (
<div style={{ <div style={{
textAlign: 'center', textAlign: 'center',
padding: '40px', padding: '40px',
fontSize: '18px', fontSize: '18px',
color: '#e74c3c' color: '#e74c3c'
@@ -173,34 +361,19 @@ const ShiftPlanEdit: React.FC = () => {
); );
} }
// Group shifts by dayOfWeek const hasTimeSlots = shiftPlan.timeSlots.length > 0;
const shiftsByDay = shiftPlan.shifts.reduce((acc, shift) => { const hasActiveDays = activeDays.length > 0;
if (!acc[shift.dayOfWeek]) {
acc[shift.dayOfWeek] = [];
}
acc[shift.dayOfWeek].push(shift);
return acc;
}, {} as Record<number, typeof shiftPlan.shifts>);
const daysOfWeek = [
{ id: 1, name: 'Montag' },
{ id: 2, name: 'Dienstag' },
{ id: 3, name: 'Mittwoch' },
{ id: 4, name: 'Donnerstag' },
{ id: 5, name: 'Freitag' },
{ id: 6, name: 'Samstag' },
{ id: 7, name: 'Sonntag' }
];
return ( return (
<div style={{ padding: '20px' }}> <div style={{ padding: '20px' }}>
<div style={{ {/* Header */}
display: 'flex', <div style={{
justifyContent: 'space-between', display: 'flex',
justifyContent: 'space-between',
alignItems: 'center', alignItems: 'center',
marginBottom: '30px' marginBottom: '30px'
}}> }}>
<h1>{shiftPlan.name} bearbeiten</h1> <h1 style={{ margin: 0 }}>{shiftPlan.name} bearbeiten</h1>
<div> <div>
{shiftPlan.status === 'draft' && ( {shiftPlan.status === 'draft' && (
<button <button
@@ -238,214 +411,332 @@ const ShiftPlanEdit: React.FC = () => {
</div> </div>
</div> </div>
{/* Add new shift form */} {/* Empty State */}
<div style={{ {!hasTimeSlots && !hasActiveDays && (
backgroundColor: 'white', <div style={{
borderRadius: '8px', backgroundColor: 'white',
padding: '20px', borderRadius: '8px',
marginBottom: '20px', padding: '60px 40px',
boxShadow: '0 2px 4px rgba(0,0,0,0.1)' textAlign: 'center',
}}> boxShadow: '0 2px 4px rgba(0,0,0,0.1)',
<h3>Neue Schicht hinzufügen</h3> marginBottom: '20px',
<div style={{ display: 'grid', gap: '15px', gridTemplateColumns: 'repeat(auto-fit, minmax(200px, 1fr))' }}> }}>
<div> <div style={{ fontSize: '48px', marginBottom: '16px', opacity: 0.5 }}>
<label>Wochentag</label> 📋
<select
value={newShift.dayOfWeek}
onChange={(e) => setNewShift({ ...newShift, dayOfWeek: parseInt(e.target.value) })}
style={{ width: '100%', padding: '8px', borderRadius: '4px', border: '1px solid #ddd' }}
disabled={isSubmitting}
>
{daysOfWeek.map(day => (
<option key={day.id} value={day.id}>{day.name}</option>
))}
</select>
</div> </div>
<div> <h2 style={{ color: '#2c3e50', marginBottom: '8px' }}>
<label>Zeit-Slot</label> Keine Schichten vorhanden
<select </h2>
value={newShift.timeSlotId} <p style={{ color: '#666', marginBottom: '24px' }}>
onChange={(e) => setNewShift({ ...newShift, timeSlotId: e.target.value })} Fügen Sie zunächst einen Zeit-Slot hinzu und wählen Sie dann die Tage aus,
style={{ width: '100%', padding: '8px', borderRadius: '4px', border: '1px solid #ddd' }} an denen Schichten stattfinden sollen.
disabled={isSubmitting} </p>
> <button
<option value="">Bitte auswählen...</option> onClick={() => setShowAddTimeSlot(true)}
{shiftPlan.timeSlots.map(slot => ( style={{
<option key={slot.id} value={slot.id}> ...addTextButton(false),
{slot.name} ({slot.startTime}-{slot.endTime}) padding: '12px 24px',
</option> fontSize: '16px',
))} }}
</select> >
{ICONS.add} Zeit-Slot hinzufügen
</button>
</div>
)}
{/* Grid Editor */}
{(hasTimeSlots || hasActiveDays) && (
<div style={{
marginBottom: '30px',
border: '1px solid #e0e0e0',
borderRadius: '8px',
overflow: 'hidden'
}}>
{/* Header bar matching ShiftPlanView */}
<div style={{
backgroundColor: '#2c3e50',
color: 'white',
padding: '15px 20px',
fontWeight: 'bold'
}}>
Schichtplan bearbeiten
<div style={{ fontSize: '14px', fontWeight: 'normal', marginTop: '5px' }}>
{sortedTimeSlots.length} Zeitslots {activeDays.length} Tage
</div>
</div> </div>
<div>
<label>Benötigte Mitarbeiter</label> <div style={{ overflowX: 'auto' }}>
<input <table style={{
type="number" width: '100%',
min="1" borderCollapse: 'collapse',
value={newShift.requiredEmployees} backgroundColor: 'white'
onChange={(e) => setNewShift({ ...newShift, requiredEmployees: parseInt(e.target.value) || 1 })} }}>
style={{ width: '100%', padding: '8px', borderRadius: '4px', border: '1px solid #ddd' }} <thead>
disabled={isSubmitting} <tr style={{ backgroundColor: '#f8f9fa' }}>
/> <th style={{
padding: '12px 16px',
textAlign: 'left',
border: '1px solid #dee2e6',
fontWeight: 'bold',
minWidth: '180px'
}}>
Schicht (Zeit)
</th>
{activeDays.map(dayId => {
const day = DAYS_OF_WEEK.find(d => d.id === dayId);
return (
<th key={dayId} style={{
padding: '12px 16px',
textAlign: 'center',
border: '1px solid #dee2e6',
fontWeight: 'bold',
minWidth: '120px'
}}>
<div style={{ display: 'flex', alignItems: 'center', justifyContent: 'center', gap: '8px' }}>
<span>{day?.name}</span>
<button
onClick={() => handleRemoveDay(dayId)}
disabled={isSubmitting}
style={smallDeleteButton(isSubmitting)}
title="Tag entfernen"
>
{ICONS.delete}
</button>
</div>
</th>
);
})}
<th style={{
padding: '12px 16px',
textAlign: 'center',
border: '1px solid #dee2e6',
minWidth: '70px',
backgroundColor: '#f8f9fa',
}}>
<AddDayButton
activeDays={activeDays}
onAddDay={handleAddDay}
disabled={isSubmitting}
/>
</th>
</tr>
</thead>
<tbody>
{sortedTimeSlots.map((slot, index) => (
<tr key={slot.id} style={{
backgroundColor: index % 2 === 0 ? 'white' : '#f8f9fa'
}}>
<td style={{
padding: '12px 16px',
border: '1px solid #dee2e6',
fontWeight: '500',
backgroundColor: '#f8f9fa',
position: 'sticky',
left: 0
}}>
<TimeSlotEditor
slot={slot}
onUpdate={handleUpdateTimeSlot}
onDelete={handleDeleteTimeSlot}
shiftsCount={getShiftsCountForSlot(slot.id)}
disabled={isSubmitting}
/>
</td>
{activeDays.map(dayId => (
<ShiftCell
key={`${slot.id}-${dayId}`}
shift={getShift(slot.id, dayId)}
dayOfWeek={dayId}
timeSlotId={slot.id}
onAdd={handleAddShift}
onEdit={handleUpdateShift}
onDelete={handleDeleteShift}
disabled={isSubmitting}
/>
))}
<td style={{
border: '1px solid #dee2e6',
padding: '8px',
textAlign: 'center',
}}>
<button
onClick={() => handleDeleteTimeSlot(slot.id)}
disabled={isSubmitting}
style={smallDeleteButton(isSubmitting)}
title="Zeit-Slot löschen"
>
{ICONS.delete}
</button>
</td>
</tr>
))}
{/* Add Time Slot Row */}
<tr>
<td colSpan={activeDays.length + 2} style={{
padding: '16px',
borderTop: '2px solid #dee2e6',
}}>
{showAddTimeSlot ? (
<div style={{
display: 'flex',
gap: '12px',
alignItems: 'flex-end',
flexWrap: 'wrap',
}}>
<div>
<label style={{ display: 'block', fontSize: '12px', marginBottom: '4px', color: '#666' }}>
Name *
</label>
<input
type="text"
value={newTimeSlot.name}
onChange={(e) => setNewTimeSlot({ ...newTimeSlot, name: e.target.value })}
placeholder="z.B. Vormittag"
style={{
padding: '8px',
borderRadius: '4px',
border: '1px solid #ddd',
width: '150px',
}}
disabled={isSubmitting}
/>
</div>
<div>
<label style={{ display: 'block', fontSize: '12px', marginBottom: '4px', color: '#666' }}>
Startzeit *
</label>
<input
type="time"
value={newTimeSlot.startTime}
onChange={(e) => setNewTimeSlot({ ...newTimeSlot, startTime: e.target.value })}
style={{
padding: '8px',
borderRadius: '4px',
border: '1px solid #ddd',
}}
disabled={isSubmitting}
/>
</div>
<div>
<label style={{ display: 'block', fontSize: '12px', marginBottom: '4px', color: '#666' }}>
Endzeit *
</label>
<input
type="time"
value={newTimeSlot.endTime}
onChange={(e) => setNewTimeSlot({ ...newTimeSlot, endTime: e.target.value })}
style={{
padding: '8px',
borderRadius: '4px',
border: '1px solid #ddd',
}}
disabled={isSubmitting}
/>
</div>
<div>
<label style={{ display: 'block', fontSize: '12px', marginBottom: '4px', color: '#666' }}>
Beschreibung
</label>
<input
type="text"
value={newTimeSlot.description}
onChange={(e) => setNewTimeSlot({ ...newTimeSlot, description: e.target.value })}
placeholder="Optional"
style={{
padding: '8px',
borderRadius: '4px',
border: '1px solid #ddd',
width: '150px',
}}
disabled={isSubmitting}
/>
</div>
<button
onClick={handleAddTimeSlot}
disabled={isSubmitting || !newTimeSlot.name}
style={addTextButton(isSubmitting || !newTimeSlot.name)}
>
{ICONS.add} Hinzufügen
</button>
<button
onClick={() => {
setShowAddTimeSlot(false);
setNewTimeSlot({ name: '', startTime: '08:00', endTime: '12:00', description: '' });
}}
disabled={isSubmitting}
style={cancelTextButton(isSubmitting)}
>
Abbrechen
</button>
</div>
) : (
<button
onClick={() => setShowAddTimeSlot(true)}
disabled={isSubmitting}
style={addOutlineButton(isSubmitting)}
onMouseEnter={(e) => {
if (!isSubmitting) {
e.currentTarget.style.backgroundColor = '#f0fff4';
}
}}
onMouseLeave={(e) => {
e.currentTarget.style.backgroundColor = 'transparent';
}}
>
{ICONS.add} Neuer Zeit-Slot hinzufügen
</button>
)}
</td>
</tr>
</tbody>
</table>
</div> </div>
</div> </div>
<button )}
onClick={handleAddShift}
disabled={isSubmitting || !newShift.timeSlotId || !newShift.requiredEmployees}
style={{
marginTop: '15px',
padding: '8px 16px',
backgroundColor: isSubmitting ? '#bdc3c7' : '#3498db',
color: 'white',
border: 'none',
borderRadius: '4px',
cursor: isSubmitting ? 'not-allowed' : 'pointer',
opacity: (!newShift.timeSlotId || !newShift.requiredEmployees) ? 0.6 : 1
}}
>
{isSubmitting ? 'Wird hinzugefügt...' : 'Schicht hinzufügen'}
</button>
</div>
{/* Existing shifts */} {/* Legend */}
<div style={{ display: 'grid', gap: '20px' }}> <div style={{
{daysOfWeek.map(day => { marginTop: '20px',
const shifts = shiftsByDay[day.id] || []; padding: '16px',
if (shifts.length === 0) return null; backgroundColor: 'white',
borderRadius: '8px',
return ( boxShadow: '0 2px 4px rgba(0,0,0,0.1)',
<div key={day.id} style={{ }}>
backgroundColor: 'white', <h4 style={{ margin: '0 0 12px 0', color: '#2c3e50' }}>Legende</h4>
borderRadius: '8px', <div style={{ display: 'flex', gap: '24px', flexWrap: 'wrap', fontSize: '13px' }}>
padding: '20px', <div style={{ display: 'flex', alignItems: 'center', gap: '8px' }}>
boxShadow: '0 2px 4px rgba(0,0,0,0.1)' <div style={{
}}> width: '24px',
<h3 style={{ marginTop: 0 }}>{day.name}</h3> height: '24px',
<div style={{ display: 'grid', gap: '15px' }}> backgroundColor: '#d5f4e6',
{shifts.map(shift => { border: `2px solid ${BUTTON_COLORS.add}`,
const timeSlot = shiftPlan.timeSlots.find(ts => ts.id === shift.timeSlotId); borderRadius: '4px',
return ( }} />
<div key={shift.id} style={{ <span>Aktive Schicht (klicken zum Bearbeiten)</span>
backgroundColor: '#f8f9fa', </div>
padding: '15px', <div style={{ display: 'flex', alignItems: 'center', gap: '8px' }}>
borderRadius: '6px', <div style={{
boxShadow: '0 1px 3px rgba(0,0,0,0.05)' width: '24px',
}}> height: '24px',
{editingShift?.id === shift.id ? ( backgroundColor: '#f8f9fa',
<div style={{ display: 'grid', gap: '10px', gridTemplateColumns: 'repeat(auto-fit, minmax(200px, 1fr))' }}> border: '2px dashed #dee2e6',
<div> borderRadius: '4px',
<label>Zeit-Slot</label> }} />
<select <span>Leere Zelle (klicken zum Hinzufügen)</span>
value={editingShift.timeSlotId} </div>
onChange={(e) => setEditingShift({ ...editingShift, timeSlotId: e.target.value })} <div style={{ display: 'flex', alignItems: 'center', gap: '8px' }}>
style={{ width: '100%', padding: '8px', borderRadius: '4px', border: '1px solid #ddd' }} <span style={{ color: BUTTON_COLORS.edit, fontSize: '16px' }}>{ICONS.edit}</span>
disabled={isSubmitting} <span>Zeit-Slot bearbeiten</span>
> </div>
{shiftPlan.timeSlots.map(slot => ( <div style={{ display: 'flex', alignItems: 'center', gap: '8px' }}>
<option key={slot.id} value={slot.id}> <span style={{ color: BUTTON_COLORS.delete, fontSize: '16px' }}>{ICONS.delete}</span>
{slot.name} ({slot.startTime}-{slot.endTime}) <span>Löschen</span>
</option> </div>
))} </div>
</select>
</div>
<div>
<label>Benötigte Mitarbeiter</label>
<input
type="number"
min="1"
value={editingShift.requiredEmployees}
onChange={(e) => setEditingShift({ ...editingShift, requiredEmployees: parseInt(e.target.value) || 1 })}
style={{ width: '100%', padding: '8px', borderRadius: '4px', border: '1px solid #ddd' }}
disabled={isSubmitting}
/>
</div>
<div style={{ display: 'flex', gap: '10px', alignItems: 'flex-end' }}>
<button
onClick={() => handleUpdateShift(editingShift)}
disabled={isSubmitting}
style={{
padding: '8px 16px',
backgroundColor: isSubmitting ? '#bdc3c7' : '#2ecc71',
color: 'white',
border: 'none',
borderRadius: '4px',
cursor: isSubmitting ? 'not-allowed' : 'pointer'
}}
>
{isSubmitting ? 'Speichern...' : 'Speichern'}
</button>
<button
onClick={() => setEditingShift(null)}
disabled={isSubmitting}
style={{
padding: '8px 16px',
backgroundColor: '#95a5a6',
color: 'white',
border: 'none',
borderRadius: '4px',
cursor: isSubmitting ? 'not-allowed' : 'pointer',
opacity: isSubmitting ? 0.6 : 1
}}
>
Abbrechen
</button>
</div>
</div>
) : (
<>
<div style={{ fontWeight: 'bold', marginBottom: '5px' }}>
{timeSlot?.name} ({timeSlot?.startTime?.substring(0, 5)} - {timeSlot?.endTime?.substring(0, 5)})
</div>
<div style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center' }}>
<div style={{ fontSize: '14px', color: '#666' }}>
<span>Benötigte Mitarbeiter: {shift.requiredEmployees}</span>
</div>
<div>
<button
onClick={() => setEditingShift(shift)}
disabled={isSubmitting}
style={{
padding: '6px 12px',
backgroundColor: isSubmitting ? '#bdc3c7' : '#f1c40f',
color: 'white',
border: 'none',
borderRadius: '4px',
cursor: isSubmitting ? 'not-allowed' : 'pointer',
marginRight: '8px',
opacity: isSubmitting ? 0.6 : 1
}}
>
Bearbeiten
</button>
<button
onClick={() => handleDeleteShift(shift.id)}
disabled={isSubmitting}
style={{
padding: '6px 12px',
backgroundColor: isSubmitting ? '#bdc3c7' : '#e74c3c',
color: 'white',
border: 'none',
borderRadius: '4px',
cursor: isSubmitting ? 'not-allowed' : 'pointer',
opacity: isSubmitting ? 0.6 : 1
}}
>
Löschen
</button>
</div>
</div>
</>
)}
</div>
);
})}
</div>
</div>
);
})}
</div> </div>
</div> </div>
); );
}; };
export default ShiftPlanEdit; export default ShiftPlanEdit;

View File

@@ -13,7 +13,7 @@ const ShiftPlanList: React.FC = () => {
const navigate = useNavigate(); const navigate = useNavigate();
const { showNotification, confirmDialog } = useNotification(); const { showNotification, confirmDialog } = useNotification();
const { executeWithValidation, isSubmitting } = useBackendValidation(); const { executeWithValidation, isSubmitting } = useBackendValidation();
const [shiftPlans, setShiftPlans] = useState<ShiftPlan[]>([]); const [shiftPlans, setShiftPlans] = useState<ShiftPlan[]>([]);
const [loading, setLoading] = useState(true); const [loading, setLoading] = useState(true);
@@ -48,13 +48,13 @@ const ShiftPlanList: React.FC = () => {
await executeWithValidation(async () => { await executeWithValidation(async () => {
await shiftPlanService.deleteShiftPlan(id); await shiftPlanService.deleteShiftPlan(id);
showNotification({ showNotification({
type: 'success', type: 'success',
title: 'Erfolg', title: 'Erfolg',
message: 'Der Schichtplan wurde erfolgreich gelöscht.' message: 'Der Schichtplan wurde erfolgreich gelöscht.'
}); });
loadShiftPlans(); loadShiftPlans();
}); });
}; };
@@ -87,8 +87,8 @@ const ShiftPlanList: React.FC = () => {
if (loading) { if (loading) {
return ( return (
<div style={{ <div style={{
textAlign: 'center', textAlign: 'center',
padding: '40px', padding: '40px',
fontSize: '18px', fontSize: '18px',
color: '#666' color: '#666'
@@ -100,34 +100,34 @@ const ShiftPlanList: React.FC = () => {
return ( return (
<div> <div>
<div style={{ <div style={{
display: 'flex', display: 'flex',
justifyContent: 'space-between', justifyContent: 'space-between',
alignItems: 'center', alignItems: 'center',
marginBottom: '30px' marginBottom: '30px'
}}> }}>
<h1>📅 Schichtpläne</h1> <h1>📅 Schichtpläne</h1>
{hasRole(['admin', 'maintenance']) && ( {hasRole(['admin', 'maintenance']) && (
<Link to="/shift-plans/new"> <Link to="/shift-plans/new">
<button style={{ <button style={{
padding: '10px 20px', padding: '10px 20px',
backgroundColor: '#51258f', backgroundColor: '#51258f',
color: 'white', color: 'white',
border: 'none', border: 'none',
borderRadius: '4px', borderRadius: '4px',
cursor: 'pointer' cursor: 'pointer'
}}> }}>
+ Neuen Plan + Neuer Plan
</button> </button>
</Link> </Link>
)} )}
</div> </div>
{shiftPlans.length === 0 ? ( {shiftPlans.length === 0 ? (
<div style={{ <div style={{
padding: '40px', padding: '40px',
textAlign: 'center', textAlign: 'center',
backgroundColor: '#f8f9fa', backgroundColor: '#f8f9fa',
borderRadius: '8px', borderRadius: '8px',
border: '2px dashed #dee2e6' border: '2px dashed #dee2e6'
}}> }}>
@@ -136,12 +136,12 @@ const ShiftPlanList: React.FC = () => {
<p>Erstellen Sie Ihren ersten Schichtplan!</p> <p>Erstellen Sie Ihren ersten Schichtplan!</p>
{hasRole(['admin', 'maintenance']) && ( {hasRole(['admin', 'maintenance']) && (
<Link to="/shift-plans/new"> <Link to="/shift-plans/new">
<button style={{ <button style={{
marginTop: '15px', marginTop: '15px',
padding: '10px 20px', padding: '10px 20px',
backgroundColor: '#51258f', backgroundColor: '#51258f',
color: 'white', color: 'white',
border: 'none', border: 'none',
borderRadius: '4px', borderRadius: '4px',
cursor: 'pointer' cursor: 'pointer'
}}> }}>
@@ -153,7 +153,7 @@ const ShiftPlanList: React.FC = () => {
) : ( ) : (
<div style={{ display: 'grid', gap: '20px' }}> <div style={{ display: 'grid', gap: '20px' }}>
{shiftPlans.map(plan => ( {shiftPlans.map(plan => (
<div <div
key={plan.id} key={plan.id}
style={{ style={{
padding: '20px', padding: '20px',
@@ -246,7 +246,7 @@ const ShiftPlanList: React.FC = () => {
fontSize: '14px', fontSize: '14px',
color: '#2c3e50' color: '#2c3e50'
}}> }}>
<strong> Informationen:</strong> Sie können Schichtpläne nur anzeigen. <strong> Informationen:</strong> Sie können Schichtpläne nur anzeigen.
Bearbeitungsrechte benötigen Admin- oder Instandhalter-Berechtigungen. Bearbeitungsrechte benötigen Admin- oder Instandhalter-Berechtigungen.
</div> </div>
)} )}

View File

@@ -1,5 +1,5 @@
// frontend/src/pages/ShiftPlans/ShiftPlanView.tsx // frontend/src/pages/ShiftPlans/ShiftPlanView.tsx
import React, { useState, useEffect } from 'react'; import React, { useState, useEffect, useRef } from 'react';
import { useParams, useNavigate } from 'react-router-dom'; import { useParams, useNavigate } from 'react-router-dom';
import { useAuth } from '../../contexts/AuthContext'; import { useAuth } from '../../contexts/AuthContext';
import { shiftPlanService } from '../../services/shiftPlanService'; import { shiftPlanService } from '../../services/shiftPlanService';
@@ -10,6 +10,7 @@ import { ShiftPlan, TimeSlot, ScheduledShift } from '../../models/ShiftPlan';
import { Employee, EmployeeAvailability } from '../../models/Employee'; import { Employee, EmployeeAvailability } from '../../models/Employee';
import { useNotification } from '../../contexts/NotificationContext'; import { useNotification } from '../../contexts/NotificationContext';
import { formatDate, formatTime } from '../../utils/foramatters'; import { formatDate, formatTime } from '../../utils/foramatters';
import { saveAs } from 'file-saver';
// Local interface extensions (same as AvailabilityManager) // Local interface extensions (same as AvailabilityManager)
interface ExtendedTimeSlot extends TimeSlot { interface ExtendedTimeSlot extends TimeSlot {
@@ -44,7 +45,7 @@ const ShiftPlanView: React.FC = () => {
const navigate = useNavigate(); const navigate = useNavigate();
const { hasRole, user } = useAuth(); const { hasRole, user } = useAuth();
const { showNotification } = useNotification(); const { showNotification } = useNotification();
const [shiftPlan, setShiftPlan] = useState<ShiftPlan | null>(null); const [shiftPlan, setShiftPlan] = useState<ShiftPlan | null>(null);
const [employees, setEmployees] = useState<Employee[]>([]); const [employees, setEmployees] = useState<Employee[]>([]);
const [availabilities, setAvailabilities] = useState<EmployeeAvailability[]>([]); const [availabilities, setAvailabilities] = useState<EmployeeAvailability[]>([]);
@@ -54,19 +55,23 @@ const ShiftPlanView: React.FC = () => {
const [scheduledShifts, setScheduledShifts] = useState<ScheduledShift[]>([]); const [scheduledShifts, setScheduledShifts] = useState<ScheduledShift[]>([]);
const [showAssignmentPreview, setShowAssignmentPreview] = useState(false); const [showAssignmentPreview, setShowAssignmentPreview] = useState(false);
const [recreating, setRecreating] = useState(false); const [recreating, setRecreating] = useState(false);
const [exporting, setExporting] = useState(false);
const [exportType, setExportType] = useState<'pdf' | 'excel' | null>(null);
const [dropdownWidth, setDropdownWidth] = useState(0);
const dropdownRef = useRef<HTMLDivElement>(null);
useEffect(() => { useEffect(() => {
loadShiftPlanData(); loadShiftPlanData();
// Event Listener für Verfügbarkeits-Änderungen // Event Listener für Verfügbarkeits-Änderungen
const handleAvailabilityChange = () => { const handleAvailabilityChange = () => {
console.log('📢 Verfügbarkeiten wurden geändert - lade Daten neu...'); console.log('📢 Verfügbarkeiten wurden geändert - lade Daten neu...');
reloadAvailabilities(); reloadAvailabilities();
}; };
// Globales Event für Verfügbarkeits-Änderungen // Globales Event für Verfügbarkeits-Änderungen
window.addEventListener('availabilitiesChanged', handleAvailabilityChange); window.addEventListener('availabilitiesChanged', handleAvailabilityChange);
return () => { return () => {
window.removeEventListener('availabilitiesChanged', handleAvailabilityChange); window.removeEventListener('availabilitiesChanged', handleAvailabilityChange);
}; };
@@ -82,7 +87,7 @@ const ShiftPlanView: React.FC = () => {
}; };
document.addEventListener('visibilitychange', handleVisibilityChange); document.addEventListener('visibilitychange', handleVisibilityChange);
return () => { return () => {
document.removeEventListener('visibilitychange', handleVisibilityChange); document.removeEventListener('visibilitychange', handleVisibilityChange);
}; };
@@ -97,17 +102,17 @@ const ShiftPlanView: React.FC = () => {
const debugAvailabilityShiftIds = () => { const debugAvailabilityShiftIds = () => {
if (!availabilities.length) return; if (!availabilities.length) return;
console.log('🔍 AVAILABILITY SHIFT ID ANALYSIS:'); console.log('🔍 AVAILABILITY SHIFT ID ANALYSIS:');
const uniqueShiftIds = [...new Set(availabilities.map(a => a.shiftId))]; const uniqueShiftIds = [...new Set(availabilities.map(a => a.shiftId))];
console.log(`Unique shift IDs in availabilities: ${uniqueShiftIds.length}`); console.log(`Unique shift IDs in availabilities: ${uniqueShiftIds.length}`);
uniqueShiftIds.forEach(shiftId => { uniqueShiftIds.forEach(shiftId => {
const count = availabilities.filter(a => a.shiftId === shiftId).length; const count = availabilities.filter(a => a.shiftId === shiftId).length;
const pref1 = availabilities.filter(a => a.shiftId === shiftId && a.preferenceLevel === 1).length; const pref1 = availabilities.filter(a => a.shiftId === shiftId && a.preferenceLevel === 1).length;
const pref2 = availabilities.filter(a => a.shiftId === shiftId && a.preferenceLevel === 2).length; const pref2 = availabilities.filter(a => a.shiftId === shiftId && a.preferenceLevel === 2).length;
const pref3 = availabilities.filter(a => a.shiftId === shiftId && a.preferenceLevel === 3).length; const pref3 = availabilities.filter(a => a.shiftId === shiftId && a.preferenceLevel === 3).length;
console.log(` ${shiftId}: ${count} total (✅${pref1} 🔶${pref2}${pref3})`); console.log(` ${shiftId}: ${count} total (✅${pref1} 🔶${pref2}${pref3})`);
}); });
}; };
@@ -119,6 +124,12 @@ const ShiftPlanView: React.FC = () => {
} }
}, [availabilities]); }, [availabilities]);
useEffect(() => {
if (dropdownRef.current) {
setDropdownWidth(dropdownRef.current.offsetWidth / 40); // Adjust divisor for desired slide distance
}
}, [exportType]);
// Create a data structure that maps days to their shifts with time slot info - SAME AS AVAILABILITYMANAGER // Create a data structure that maps days to their shifts with time slot info - SAME AS AVAILABILITYMANAGER
const getTimetableData = () => { const getTimetableData = () => {
if (!shiftPlan || !shiftPlan.shifts || !shiftPlan.timeSlots) { if (!shiftPlan || !shiftPlan.shifts || !shiftPlan.timeSlots) {
@@ -133,7 +144,7 @@ const ShiftPlanView: React.FC = () => {
if (!acc[shift.dayOfWeek]) { if (!acc[shift.dayOfWeek]) {
acc[shift.dayOfWeek] = []; acc[shift.dayOfWeek] = [];
} }
const timeSlot = timeSlotMap.get(shift.timeSlotId); const timeSlot = timeSlotMap.get(shift.timeSlotId);
const enhancedShift: ExtendedShift = { const enhancedShift: ExtendedShift = {
...shift, ...shift,
@@ -142,7 +153,7 @@ const ShiftPlanView: React.FC = () => {
endTime: timeSlot?.endTime, endTime: timeSlot?.endTime,
displayName: timeSlot ? `${timeSlot.name} (${formatTime(timeSlot.startTime)}-${formatTime(timeSlot.endTime)})` : shift.id displayName: timeSlot ? `${timeSlot.name} (${formatTime(timeSlot.startTime)}-${formatTime(timeSlot.endTime)})` : shift.id
}; };
acc[shift.dayOfWeek].push(enhancedShift); acc[shift.dayOfWeek].push(enhancedShift);
return acc; return acc;
}, {} as Record<number, ExtendedShift[]>); }, {} as Record<number, ExtendedShift[]>);
@@ -189,7 +200,17 @@ const ShiftPlanView: React.FC = () => {
// Convert to array and sort by start time - SAME LOGIC AS AVAILABILITYMANAGER // Convert to array and sort by start time - SAME LOGIC AS AVAILABILITYMANAGER
const allTimeSlots = Array.from(allTimeSlotsMap.values()).sort((a, b) => { const allTimeSlots = Array.from(allTimeSlotsMap.values()).sort((a, b) => {
return (a.startTime || '').localeCompare(b.startTime || ''); // Convert time strings to minutes for proper numeric comparison
const timeToMinutes = (timeStr: string) => {
if (!timeStr) return 0;
const [hours, minutes] = timeStr.split(':').map(Number);
return hours * 60 + minutes;
};
const minutesA = timeToMinutes(a.startTime);
const minutesB = timeToMinutes(b.startTime);
return minutesA - minutesB; // Ascending order (earliest first)
}); });
return { days, shiftsByDay, allTimeSlots }; return { days, shiftsByDay, allTimeSlots };
@@ -202,11 +223,11 @@ const ShiftPlanView: React.FC = () => {
} }
const validationErrors: string[] = []; const validationErrors: string[] = [];
// Check for missing time slots - SAME VALIDATION AS AVAILABILITYMANAGER // Check for missing time slots - SAME VALIDATION AS AVAILABILITYMANAGER
const usedTimeSlotIds = new Set(shiftPlan.shifts.map(s => s.timeSlotId)); const usedTimeSlotIds = new Set(shiftPlan.shifts.map(s => s.timeSlotId));
const availableTimeSlotIds = new Set(shiftPlan.timeSlots.map(ts => ts.id)); const availableTimeSlotIds = new Set(shiftPlan.timeSlots.map(ts => ts.id));
usedTimeSlotIds.forEach(timeSlotId => { usedTimeSlotIds.forEach(timeSlotId => {
if (!availableTimeSlotIds.has(timeSlotId)) { if (!availableTimeSlotIds.has(timeSlotId)) {
validationErrors.push(`Zeitslot ${timeSlotId} wird verwendet, existiert aber nicht in timeSlots`); validationErrors.push(`Zeitslot ${timeSlotId} wird verwendet, existiert aber nicht in timeSlots`);
@@ -240,12 +261,45 @@ const ShiftPlanView: React.FC = () => {
}; };
}; };
const handleExport = async () => {
if (!shiftPlan || !exportType) return;
try {
setExporting(true);
let blob: Blob;
if (exportType === 'excel') {
blob = await shiftPlanService.exportShiftPlanToExcel(shiftPlan.id);
saveAs(blob, `Schichtplan_${shiftPlan.name}_${new Date().toISOString().split('T')[0]}.xlsx`);
} else {
blob = await shiftPlanService.exportShiftPlanToPDF(shiftPlan.id);
saveAs(blob, `Schichtplan_${shiftPlan.name}_${new Date().toISOString().split('T')[0]}.pdf`);
}
showNotification({
type: 'success',
title: 'Export erfolgreich',
message: `Der Schichtplan wurde als ${exportType === 'excel' ? 'Excel' : 'PDF'} exportiert.`
});
} catch (error) {
console.error(`Error exporting to ${exportType}:`, error);
showNotification({
type: 'error',
title: 'Export fehlgeschlagen',
message: `Der ${exportType === 'excel' ? 'Excel' : 'PDF'}-Export konnte nicht durchgeführt werden.`
});
} finally {
setExporting(false);
}
};
const loadShiftPlanData = async () => { const loadShiftPlanData = async () => {
if (!id) return; if (!id) return;
try { try {
setLoading(true); setLoading(true);
// Load plan and employees first // Load plan and employees first
const [plan, employeesData] = await Promise.all([ const [plan, employeesData] = await Promise.all([
shiftPlanService.getShiftPlan(id), shiftPlanService.getShiftPlan(id),
@@ -258,7 +312,7 @@ const ShiftPlanView: React.FC = () => {
// CRITICAL: Load scheduled shifts and verify they exist // CRITICAL: Load scheduled shifts and verify they exist
const shiftsData = await shiftAssignmentService.getScheduledShiftsForPlan(id); const shiftsData = await shiftAssignmentService.getScheduledShiftsForPlan(id);
console.log('📋 Loaded scheduled shifts:', shiftsData.length); console.log('📋 Loaded scheduled shifts:', shiftsData.length);
if (shiftsData.length === 0) { if (shiftsData.length === 0) {
console.warn('⚠️ No scheduled shifts found for plan:', id); console.warn('⚠️ No scheduled shifts found for plan:', id);
showNotification({ showNotification({
@@ -272,21 +326,21 @@ const ShiftPlanView: React.FC = () => {
// Load availabilities - USING THE SAME LOGIC AS AVAILABILITYMANAGER // Load availabilities - USING THE SAME LOGIC AS AVAILABILITYMANAGER
console.log('🔄 LADE VERFÜGBARKEITEN FÜR PLAN:', id); console.log('🔄 LADE VERFÜGBARKEITEN FÜR PLAN:', id);
const availabilityPromises = employeesData const availabilityPromises = employeesData
.filter(emp => emp.isActive) .filter(emp => emp.isActive)
.map(emp => employeeService.getAvailabilities(emp.id)); .map(emp => employeeService.getAvailabilities(emp.id));
const allAvailabilities = await Promise.all(availabilityPromises); const allAvailabilities = await Promise.all(availabilityPromises);
const flattenedAvailabilities = allAvailabilities.flat(); const flattenedAvailabilities = allAvailabilities.flat();
// Filter to only include availabilities for the current plan - SAME LOGIC AS AVAILABILITYMANAGER // Filter to only include availabilities for the current plan - SAME LOGIC AS AVAILABILITYMANAGER
const planAvailabilities = flattenedAvailabilities.filter( const planAvailabilities = flattenedAvailabilities.filter(
availability => availability.planId === id availability => availability.planId === id
); );
console.log('✅ VERFÜGBARKEITEN FÜR DIESEN PLAN:', planAvailabilities.length); console.log('✅ VERFÜGBARKEITEN FÜR DIESEN PLAN:', planAvailabilities.length);
setAvailabilities(planAvailabilities); setAvailabilities(planAvailabilities);
// Run validation // Run validation
@@ -312,7 +366,7 @@ const ShiftPlanView: React.FC = () => {
try { try {
setRecreating(true); setRecreating(true);
if (!window.confirm('Möchten Sie die aktuellen Zuweisungen wirklich zurücksetzen? Alle vorhandenen Zuweisungen werden gelöscht.')) { if (!window.confirm('Möchten Sie die aktuellen Zuweisungen wirklich zurücksetzen? Alle vorhandenen Zuweisungen werden gelöscht.')) {
return; return;
} }
@@ -343,7 +397,7 @@ const ShiftPlanView: React.FC = () => {
// STEP 4: CRITICAL - Force reload of scheduled shifts to get EMPTY assignments // STEP 4: CRITICAL - Force reload of scheduled shifts to get EMPTY assignments
const refreshedShifts = await shiftAssignmentService.getScheduledShiftsForPlan(shiftPlan.id); const refreshedShifts = await shiftAssignmentService.getScheduledShiftsForPlan(shiftPlan.id);
setScheduledShifts(refreshedShifts); // Update state with EMPTY assignments setScheduledShifts(refreshedShifts); // Update state with EMPTY assignments
// STEP 5: Clear any previous assignment results // STEP 5: Clear any previous assignment results
setAssignmentResult(null); setAssignmentResult(null);
setShowAssignmentPreview(false); setShowAssignmentPreview(false);
@@ -383,9 +437,9 @@ const ShiftPlanView: React.FC = () => {
setPublishing(true); setPublishing(true);
setAssignmentResult(null); // Reset previous results setAssignmentResult(null); // Reset previous results
setShowAssignmentPreview(false); // Reset preview setShowAssignmentPreview(false); // Reset preview
console.log('🔄 STARTING ASSIGNMENT PREVIEW...'); console.log('🔄 STARTING ASSIGNMENT PREVIEW...');
// FORCE COMPLETE REFRESH - don't rely on cached state // FORCE COMPLETE REFRESH - don't rely on cached state
const [refreshedEmployees, refreshedAvailabilities] = await Promise.all([ const [refreshedEmployees, refreshedAvailabilities] = await Promise.all([
employeeService.getEmployees().then(emps => emps.filter(emp => emp.isActive)), employeeService.getEmployees().then(emps => emps.filter(emp => emp.isActive)),
@@ -399,12 +453,12 @@ const ShiftPlanView: React.FC = () => {
console.log('- Scheduled Shifts:', scheduledShifts.length); console.log('- Scheduled Shifts:', scheduledShifts.length);
// DEBUG: Show shift pattern IDs // DEBUG: Show shift pattern IDs
if (shiftPlan.shifts) { /*if (shiftPlan.shifts) {
console.log('📋 SHIFT PATTERN IDs:'); console.log('📋 SHIFT PATTERN IDs:');
shiftPlan.shifts.forEach((shift, index) => { shiftPlan.shifts.forEach((shift, index) => {
console.log(` ${index + 1}. ${shift.id} (Day ${shift.dayOfWeek}, TimeSlot ${shift.timeSlotId})`); console.log(` ${index + 1}. ${shift.id} (Day ${shift.dayOfWeek}, TimeSlot ${shift.timeSlotId})`);
}); });
} }*/
const constraints = { const constraints = {
enforceNoTraineeAlone: true, enforceNoTraineeAlone: true,
@@ -414,7 +468,7 @@ const ShiftPlanView: React.FC = () => {
}; };
console.log('🧠 Calling shift assignment service...'); console.log('🧠 Calling shift assignment service...');
// Use the freshly loaded data, not the state // Use the freshly loaded data, not the state
const result = await shiftAssignmentService.assignShifts( const result = await shiftAssignmentService.assignShifts(
shiftPlan, shiftPlan,
@@ -435,7 +489,7 @@ const ShiftPlanView: React.FC = () => {
console.log('🔍 ASSIGNMENTS BY SHIFT PATTERN:'); console.log('🔍 ASSIGNMENTS BY SHIFT PATTERN:');
Object.entries(result.assignments).forEach(([shiftId, empIds]) => { Object.entries(result.assignments).forEach(([shiftId, empIds]) => {
const shiftPattern = shiftPlan.shifts?.find(s => s.id === shiftId); const shiftPattern = shiftPlan.shifts?.find(s => s.id === shiftId);
if (shiftPattern) { if (shiftPattern) {
console.log(` ✅ Shift Pattern: ${shiftId}`); console.log(` ✅ Shift Pattern: ${shiftId}`);
console.log(` - Day: ${shiftPattern.dayOfWeek}, TimeSlot: ${shiftPattern.timeSlotId}`); console.log(` - Day: ${shiftPattern.dayOfWeek}, TimeSlot: ${shiftPattern.timeSlotId}`);
@@ -451,7 +505,7 @@ const ShiftPlanView: React.FC = () => {
console.log('🔄 Setting assignment result and showing preview...'); console.log('🔄 Setting assignment result and showing preview...');
setAssignmentResult(result); setAssignmentResult(result);
setShowAssignmentPreview(true); setShowAssignmentPreview(true);
console.log('✅ Assignment preview ready, modal should be visible'); console.log('✅ Assignment preview ready, modal should be visible');
} catch (error) { } catch (error) {
@@ -465,18 +519,18 @@ const ShiftPlanView: React.FC = () => {
setPublishing(false); setPublishing(false);
} }
}; };
const handlePublish = async () => { const handlePublish = async () => {
if (!shiftPlan || !assignmentResult) return; if (!shiftPlan || !assignmentResult) return;
try { try {
setPublishing(true); setPublishing(true);
console.log('🔄 Starting to publish assignments...'); console.log('🔄 Starting to publish assignments...');
// Get fresh scheduled shifts // Get fresh scheduled shifts
const updatedShifts = await shiftAssignmentService.getScheduledShiftsForPlan(shiftPlan.id); const updatedShifts = await shiftAssignmentService.getScheduledShiftsForPlan(shiftPlan.id);
if (!updatedShifts || updatedShifts.length === 0) { if (!updatedShifts || updatedShifts.length === 0) {
throw new Error('No scheduled shifts found in the plan'); throw new Error('No scheduled shifts found in the plan');
} }
@@ -486,19 +540,19 @@ const ShiftPlanView: React.FC = () => {
const updatePromises = updatedShifts.map(async (scheduledShift) => { const updatePromises = updatedShifts.map(async (scheduledShift) => {
const dayOfWeek = getDayOfWeek(scheduledShift.date); const dayOfWeek = getDayOfWeek(scheduledShift.date);
// Find the corresponding shift pattern for this day and time slot // Find the corresponding shift pattern for this day and time slot
const shiftPattern = shiftPlan?.shifts?.find(shift => const shiftPattern = shiftPlan?.shifts?.find(shift =>
shift.dayOfWeek === dayOfWeek && shift.dayOfWeek === dayOfWeek &&
shift.timeSlotId === scheduledShift.timeSlotId shift.timeSlotId === scheduledShift.timeSlotId
); );
let assignedEmployees: string[] = []; let assignedEmployees: string[] = [];
if (shiftPattern) { if (shiftPattern) {
assignedEmployees = assignmentResult.assignments[shiftPattern.id] || []; assignedEmployees = assignmentResult.assignments[shiftPattern.id] || [];
console.log(`📝 Updating scheduled shift ${scheduledShift.id} (Day ${dayOfWeek}, TimeSlot ${scheduledShift.timeSlotId}) with`, assignedEmployees, 'employees'); console.log(`📝 Updating scheduled shift ${scheduledShift.id} (Day ${dayOfWeek}, TimeSlot ${scheduledShift.timeSlotId}) with`, assignedEmployees, 'employees');
if (assignedEmployees.length === 0) { if (assignedEmployees.length === 0) {
console.warn(`⚠️ No assignments found for shift pattern ${shiftPattern.id}`); console.warn(`⚠️ No assignments found for shift pattern ${shiftPattern.id}`);
console.log('🔍 Available assignment keys:', Object.keys(assignmentResult.assignments)); console.log('🔍 Available assignment keys:', Object.keys(assignmentResult.assignments));
@@ -506,13 +560,13 @@ const ShiftPlanView: React.FC = () => {
} else { } else {
console.warn(`⚠️ No shift pattern found for scheduled shift ${scheduledShift.id} (Day ${dayOfWeek}, TimeSlot ${scheduledShift.timeSlotId})`); console.warn(`⚠️ No shift pattern found for scheduled shift ${scheduledShift.id} (Day ${dayOfWeek}, TimeSlot ${scheduledShift.timeSlotId})`);
} }
try { try {
// Update the scheduled shift with assigned employees // Update the scheduled shift with assigned employees
await shiftAssignmentService.updateScheduledShift(scheduledShift.id, { await shiftAssignmentService.updateScheduledShift(scheduledShift.id, {
assignedEmployees assignedEmployees
}); });
console.log(`✅ Successfully updated scheduled shift ${scheduledShift.id}`); console.log(`✅ Successfully updated scheduled shift ${scheduledShift.id}`);
} catch (error) { } catch (error) {
console.error(`❌ Failed to update shift ${scheduledShift.id}:`, error); console.error(`❌ Failed to update shift ${scheduledShift.id}:`, error);
@@ -550,12 +604,12 @@ const ShiftPlanView: React.FC = () => {
} catch (error) { } catch (error) {
console.error('❌ Error publishing shift plan:', error); console.error('❌ Error publishing shift plan:', error);
let message = 'Unbekannter Fehler'; let message = 'Unbekannter Fehler';
if (error instanceof Error) { if (error instanceof Error) {
message = error.message; message = error.message;
} }
showNotification({ showNotification({
type: 'error', type: 'error',
title: 'Fehler', title: 'Fehler',
@@ -569,7 +623,7 @@ const ShiftPlanView: React.FC = () => {
const refreshAllAvailabilities = async (): Promise<EmployeeAvailability[]> => { const refreshAllAvailabilities = async (): Promise<EmployeeAvailability[]> => {
try { try {
console.log('🔄 Force refreshing ALL availabilities with error handling...'); console.log('🔄 Force refreshing ALL availabilities with error handling...');
if (!id) { if (!id) {
console.error('❌ No plan ID available'); console.error('❌ No plan ID available');
return []; return [];
@@ -585,20 +639,20 @@ const ShiftPlanView: React.FC = () => {
return []; // Return empty array instead of failing entire operation return []; // Return empty array instead of failing entire operation
} }
}); });
const allAvailabilities = await Promise.all(availabilityPromises); const allAvailabilities = await Promise.all(availabilityPromises);
const flattenedAvailabilities = allAvailabilities.flat(); const flattenedAvailabilities = allAvailabilities.flat();
// More robust filtering // More robust filtering
const planAvailabilities = flattenedAvailabilities.filter( const planAvailabilities = flattenedAvailabilities.filter(
availability => availability && availability.planId === id availability => availability && availability.planId === id
); );
console.log(`✅ Successfully refreshed ${planAvailabilities.length} availabilities for plan ${id}`); console.log(`✅ Successfully refreshed ${planAvailabilities.length} availabilities for plan ${id}`);
// IMMEDIATELY update state // IMMEDIATELY update state
setAvailabilities(planAvailabilities); setAvailabilities(planAvailabilities);
return planAvailabilities; return planAvailabilities;
} catch (error) { } catch (error) {
console.error('❌ Critical error refreshing availabilities:', error); console.error('❌ Critical error refreshing availabilities:', error);
@@ -609,21 +663,21 @@ const ShiftPlanView: React.FC = () => {
const debugShiftMatching = () => { const debugShiftMatching = () => {
if (!shiftPlan || !scheduledShifts.length) return; if (!shiftPlan || !scheduledShifts.length) return;
console.log('🔍 DEBUG: Shift Pattern to Scheduled Shift Matching'); console.log('🔍 DEBUG: Shift Pattern to Scheduled Shift Matching');
console.log('=================================================='); console.log('==================================================');
shiftPlan.shifts?.forEach(shiftPattern => { shiftPlan.shifts?.forEach(shiftPattern => {
const matchingScheduledShifts = scheduledShifts.filter(scheduled => { const matchingScheduledShifts = scheduledShifts.filter(scheduled => {
const dayOfWeek = getDayOfWeek(scheduled.date); const dayOfWeek = getDayOfWeek(scheduled.date);
return dayOfWeek === shiftPattern.dayOfWeek && return dayOfWeek === shiftPattern.dayOfWeek &&
scheduled.timeSlotId === shiftPattern.timeSlotId; scheduled.timeSlotId === shiftPattern.timeSlotId;
}); });
console.log(`📅 Shift Pattern: ${shiftPattern.id}`); console.log(`📅 Shift Pattern: ${shiftPattern.id}`);
console.log(` - Day: ${shiftPattern.dayOfWeek}, TimeSlot: ${shiftPattern.timeSlotId}`); console.log(` - Day: ${shiftPattern.dayOfWeek}, TimeSlot: ${shiftPattern.timeSlotId}`);
console.log(` - Matching scheduled shifts: ${matchingScheduledShifts.length}`); console.log(` - Matching scheduled shifts: ${matchingScheduledShifts.length}`);
if (assignmentResult) { if (assignmentResult) {
const assignments = assignmentResult.assignments[shiftPattern.id] || []; const assignments = assignmentResult.assignments[shiftPattern.id] || [];
console.log(` - Assignments: ${assignments.length} employees`); console.log(` - Assignments: ${assignments.length} employees`);
@@ -640,7 +694,7 @@ const ShiftPlanView: React.FC = () => {
const canPublish = () => { const canPublish = () => {
if (!shiftPlan || shiftPlan.status === 'published') return false; if (!shiftPlan || shiftPlan.status === 'published') return false;
// Check if all active employees have set their availabilities // Check if all active employees have set their availabilities
const employeesWithoutAvailabilities = employees.filter(emp => { const employeesWithoutAvailabilities = employees.filter(emp => {
const empAvailabilities = availabilities.filter(avail => avail.employeeId === emp.id); const empAvailabilities = availabilities.filter(avail => avail.employeeId === emp.id);
@@ -650,6 +704,20 @@ const ShiftPlanView: React.FC = () => {
return employeesWithoutAvailabilities.length === 0; return employeesWithoutAvailabilities.length === 0;
}; };
const canPublishAssignment = (): boolean => {
if (!assignmentResult) return false;
// Check if assignment was successful
if (assignmentResult.success === false) return false;
// Check if there are any critical violations
const hasCriticalViolations = assignmentResult.violations.some(v =>
v.includes('ERROR:') || v.includes('KRITISCH:')
);
return !hasCriticalViolations;
};
const getAvailabilityStatus = () => { const getAvailabilityStatus = () => {
const totalEmployees = employees.length; const totalEmployees = employees.length;
const employeesWithAvailabilities = new Set( const employeesWithAvailabilities = new Set(
@@ -666,23 +734,23 @@ const ShiftPlanView: React.FC = () => {
const reloadAvailabilities = async () => { const reloadAvailabilities = async () => {
try { try {
console.log('🔄 Lade Verfügbarkeiten neu...'); console.log('🔄 Lade Verfügbarkeiten neu...');
// Load availabilities for all employees // Load availabilities for all employees
const availabilityPromises = employees const availabilityPromises = employees
.filter(emp => emp.isActive) .filter(emp => emp.isActive)
.map(emp => employeeService.getAvailabilities(emp.id)); .map(emp => employeeService.getAvailabilities(emp.id));
const allAvailabilities = await Promise.all(availabilityPromises); const allAvailabilities = await Promise.all(availabilityPromises);
const flattenedAvailabilities = allAvailabilities.flat(); const flattenedAvailabilities = allAvailabilities.flat();
// Filter availabilities to only include those for the current shift plan // Filter availabilities to only include those for the current shift plan
const planAvailabilities = flattenedAvailabilities.filter( const planAvailabilities = flattenedAvailabilities.filter(
availability => availability.planId === id availability => availability.planId === id
); );
setAvailabilities(planAvailabilities); setAvailabilities(planAvailabilities);
console.log('✅ Verfügbarkeiten neu geladen:', planAvailabilities.length); console.log('✅ Verfügbarkeiten neu geladen:', planAvailabilities.length);
} catch (error) { } catch (error) {
console.error('❌ Fehler beim Neuladen der Verfügbarkeiten:', error); console.error('❌ Fehler beim Neuladen der Verfügbarkeiten:', error);
} }
@@ -690,26 +758,26 @@ const ShiftPlanView: React.FC = () => {
const getAssignmentsForScheduledShift = (scheduledShift: ScheduledShift): string[] => { const getAssignmentsForScheduledShift = (scheduledShift: ScheduledShift): string[] => {
if (!assignmentResult) return []; if (!assignmentResult) return [];
const dayOfWeek = getDayOfWeek(scheduledShift.date); const dayOfWeek = getDayOfWeek(scheduledShift.date);
// Find the corresponding shift pattern for this day and time slot // Find the corresponding shift pattern for this day and time slot
const shiftPattern = shiftPlan?.shifts?.find(shift => const shiftPattern = shiftPlan?.shifts?.find(shift =>
shift.dayOfWeek === dayOfWeek && shift.dayOfWeek === dayOfWeek &&
shift.timeSlotId === scheduledShift.timeSlotId shift.timeSlotId === scheduledShift.timeSlotId
); );
if (shiftPattern && assignmentResult.assignments[shiftPattern.id]) { if (shiftPattern && assignmentResult.assignments[shiftPattern.id]) {
console.log(`✅ Found assignments for shift pattern ${shiftPattern.id}:`, assignmentResult.assignments[shiftPattern.id]); console.log(`✅ Found assignments for shift pattern ${shiftPattern.id}:`, assignmentResult.assignments[shiftPattern.id]);
return assignmentResult.assignments[shiftPattern.id]; return assignmentResult.assignments[shiftPattern.id];
} }
// Fallback: Check if there's a direct match with scheduled shift ID (unlikely) // Fallback: Check if there's a direct match with scheduled shift ID (unlikely)
if (assignmentResult.assignments[scheduledShift.id]) { if (assignmentResult.assignments[scheduledShift.id]) {
console.log(`⚠️ Using direct scheduled shift assignment for ${scheduledShift.id}`); console.log(`⚠️ Using direct scheduled shift assignment for ${scheduledShift.id}`);
return assignmentResult.assignments[scheduledShift.id]; return assignmentResult.assignments[scheduledShift.id];
} }
console.warn(`❌ No assignments found for scheduled shift ${scheduledShift.id} (Day ${dayOfWeek}, TimeSlot ${scheduledShift.timeSlotId})`); console.warn(`❌ No assignments found for scheduled shift ${scheduledShift.id} (Day ${dayOfWeek}, TimeSlot ${scheduledShift.timeSlotId})`);
return []; return [];
}; };
@@ -820,13 +888,10 @@ const ShiftPlanView: React.FC = () => {
<div style={{ fontSize: '14px', color: '#666' }}> <div style={{ fontSize: '14px', color: '#666' }}>
{formatTime(timeSlot.startTime)} - {formatTime(timeSlot.endTime)} {formatTime(timeSlot.startTime)} - {formatTime(timeSlot.endTime)}
</div> </div>
<div style={{ fontSize: '11px', color: '#999', marginTop: '4px' }}>
ID: {timeSlot.id.substring(0, 8)}...
</div>
</td> </td>
{days.map(weekday => { {days.map(weekday => {
const shift = timeSlot.shiftsByDay[weekday.id]; const shift = timeSlot.shiftsByDay[weekday.id];
if (!shift) { if (!shift) {
return ( return (
<td key={weekday.id} style={{ <td key={weekday.id} style={{
@@ -844,65 +909,115 @@ const ShiftPlanView: React.FC = () => {
// Validation: Check if shift has correct timeSlotId and dayOfWeek - SAME AS AVAILABILITYMANAGER // Validation: Check if shift has correct timeSlotId and dayOfWeek - SAME AS AVAILABILITYMANAGER
const isValidShift = shift.timeSlotId === timeSlot.id && shift.dayOfWeek === weekday.id; const isValidShift = shift.timeSlotId === timeSlot.id && shift.dayOfWeek === weekday.id;
let assignedEmployees: string[] = []; let assignedEmployees: string[] = [];
let displayText = ''; let displayContent: React.ReactNode = null;
// Helper function to create employee boxes
const createEmployeeBoxes = (employeeIds: string[]) => {
return employeeIds.map(empId => {
const employee = employees.find(emp => emp.id === empId);
if (!employee) return null;
// Determine background color based on employee role
let backgroundColor = '#642ab5'; // Default: non-trainee personnel (purple)
if (employee.isTrainee) {
backgroundColor = '#cda8f0'; // Trainee
} else if (employee.employeeType === 'manager') {
backgroundColor = '#CC0000'; // Manager
}
return (
<div
key={empId}
style={{
backgroundColor,
color: 'white',
padding: '4px 8px',
borderRadius: '4px',
marginBottom: '2px',
fontSize: '12px',
textAlign: 'center',
whiteSpace: 'nowrap',
overflow: 'hidden',
textOverflow: 'ellipsis'
}}
title={`${employee.firstname} ${employee.lastname}${employee.isTrainee ? ' (Trainee)' : ''}`}
>
{employee.firstname} {employee.lastname}
</div>
);
}).filter(Boolean);
};
// Helper function to get fallback content
const getFallbackContent = () => {
const shiftsForSlot = shiftPlan?.shifts?.filter(s =>
s.dayOfWeek === weekday.id &&
s.timeSlotId === timeSlot.id
) || [];
const totalRequired = shiftsForSlot.reduce((sum, s) => sum + s.requiredEmployees, 0);
return totalRequired === 0 ? '-' : `0/${totalRequired}`;
};
if (shiftPlan?.status === 'published') { if (shiftPlan?.status === 'published') {
// For published plans, use actual assignments from scheduled shifts // For published plans, use actual assignments from scheduled shifts
const scheduledShift = scheduledShifts.find(scheduled => { const scheduledShift = scheduledShifts.find(scheduled => {
const scheduledDayOfWeek = getDayOfWeek(scheduled.date); const scheduledDayOfWeek = getDayOfWeek(scheduled.date);
return scheduledDayOfWeek === weekday.id && return scheduledDayOfWeek === weekday.id &&
scheduled.timeSlotId === timeSlot.id; scheduled.timeSlotId === timeSlot.id;
}); });
if (scheduledShift) { if (scheduledShift) {
assignedEmployees = scheduledShift.assignedEmployees || []; assignedEmployees = scheduledShift.assignedEmployees || [];
// DEBUG: Log if we're still seeing old data // Log if we're still seeing old data
if (assignedEmployees.length > 0) { if (assignedEmployees.length > 0) {
console.warn(`⚠️ Found non-empty assignments for ${weekday.name} ${timeSlot.name}:`, assignedEmployees); console.warn(`⚠️ Found non-empty assignments for ${weekday.name} ${timeSlot.name}:`, assignedEmployees);
} }
displayText = assignedEmployees.map(empId => { const employeeBoxes = createEmployeeBoxes(assignedEmployees);
const employee = employees.find(emp => emp.id === empId); displayContent = employeeBoxes.length > 0 ? (
return employee ? `${employee.firstname} ${employee.lastname}` : 'Unbekannt'; <div style={{ display: 'flex', flexDirection: 'column', gap: '2px' }}>
}).join(', '); {employeeBoxes}
</div>
) : (
<div style={{ color: '#666', fontStyle: 'italic' }}>
{getFallbackContent()}
</div>
);
} }
} else if (assignmentResult) { } else if (assignmentResult) {
// For draft with preview, use assignment result // For draft with preview, use assignment result
const scheduledShift = scheduledShifts.find(scheduled => { const scheduledShift = scheduledShifts.find(scheduled => {
const scheduledDayOfWeek = getDayOfWeek(scheduled.date); const scheduledDayOfWeek = getDayOfWeek(scheduled.date);
return scheduledDayOfWeek === weekday.id && return scheduledDayOfWeek === weekday.id &&
scheduled.timeSlotId === timeSlot.id; scheduled.timeSlotId === timeSlot.id;
}); });
if (scheduledShift) { if (scheduledShift) {
assignedEmployees = getAssignmentsForScheduledShift(scheduledShift); assignedEmployees = getAssignmentsForScheduledShift(scheduledShift);
displayText = assignedEmployees.map(empId => { const employeeBoxes = createEmployeeBoxes(assignedEmployees);
const employee = employees.find(emp => emp.id === empId); displayContent = employeeBoxes.length > 0 ? (
return employee ? `${employee.firstname} ${employee.lastname}` : 'Unbekannt'; <div style={{ display: 'flex', flexDirection: 'column', gap: '2px' }}>
}).join(', '); {employeeBoxes}
</div>
) : (
<div style={{ color: '#666', fontStyle: 'italic' }}>
{getFallbackContent()}
</div>
);
} }
} }
// If no assignments yet, show empty or required count // If no display content set yet, use fallback
if (!displayText) { if (!displayContent) {
const shiftsForSlot = shiftPlan?.shifts?.filter(s => displayContent = (
s.dayOfWeek === weekday.id && <div style={{ color: '#666', fontStyle: 'italic' }}>
s.timeSlotId === timeSlot.id {getFallbackContent()}
) || []; </div>
);
const totalRequired = shiftsForSlot.reduce((sum, s) =>
sum + s.requiredEmployees, 0);
// Show "0/2" instead of just "0" to indicate it's empty
displayText = `0/${totalRequired}`;
// Optional: Show empty state more clearly
if (totalRequired === 0) {
displayText = '-';
}
} }
return ( return (
@@ -931,24 +1046,22 @@ const ShiftPlanView: React.FC = () => {
alignItems: 'center', alignItems: 'center',
justifyContent: 'center' justifyContent: 'center'
}} }}
title={`Shift Validierung: timeSlotId=${shift.timeSlotId}, dayOfWeek=${shift.dayOfWeek}`} title={`Shift Validierung: timeSlotId=${shift.timeSlotId}, dayOfWeek=${shift.dayOfWeek}`}
> >
</div> </div>
)} )}
{displayText} {displayContent}
{/* Shift debug info - SAME AS AVAILABILITYMANAGER */} {/* Shift debug info - SAME AS AVAILABILITYMANAGER */}
<div style={{ <div style={{
fontSize: '10px', fontSize: '10px',
color: '#666', color: '#666',
marginTop: '4px', marginTop: '4px',
textAlign: 'left', textAlign: 'left',
fontFamily: 'monospace' fontFamily: 'monospace'
}}> }}>
<div>Shift: {shift.id.substring(0, 6)}...</div>
<div>Day: {shift.dayOfWeek}</div>
{!isValidShift && ( {!isValidShift && (
<div style={{ color: '#e74c3c', fontWeight: 'bold' }}> <div style={{ color: '#e74c3c', fontWeight: 'bold' }}>
VALIDATION ERROR VALIDATION ERROR
@@ -963,7 +1076,6 @@ const ShiftPlanView: React.FC = () => {
</tbody> </tbody>
</table> </table>
</div> </div>
</div> </div>
); );
}; };
@@ -978,20 +1090,20 @@ const ShiftPlanView: React.FC = () => {
return ( return (
<div style={{ padding: '20px' }}> <div style={{ padding: '20px' }}>
{/* Header with Plan Information and Actions */} {/* Header with Plan Information and Actions */}
<div style={{ <div style={{
display: 'flex', display: 'flex',
justifyContent: 'space-between', justifyContent: 'space-between',
alignItems: 'flex-start', alignItems: 'flex-start',
marginBottom: '20px' marginBottom: '20px'
}}> }}>
<div> <div>
<h1>{shiftPlan.name}</h1> <h1>{shiftPlan.name}</h1>
<p style={{ color: '#666', margin: 0 }}> <p style={{ color: '#666', margin: 0 }}>
{shiftPlan.startDate && shiftPlan.endDate && {shiftPlan.startDate && shiftPlan.endDate &&
`Zeitraum: ${formatDate(shiftPlan.startDate)} - ${formatDate(shiftPlan.endDate)}` `Zeitraum: ${formatDate(shiftPlan.startDate)} - ${formatDate(shiftPlan.endDate)}`
} }
</p> </p>
<div style={{ <div style={{
display: 'inline-block', display: 'inline-block',
padding: '4px 12px', padding: '4px 12px',
backgroundColor: shiftPlan.status === 'published' ? '#2ecc71' : '#f1c40f', backgroundColor: shiftPlan.status === 'published' ? '#2ecc71' : '#f1c40f',
@@ -1004,8 +1116,9 @@ const ShiftPlanView: React.FC = () => {
{shiftPlan.status === 'published' ? 'Veröffentlicht' : 'Entwurf'} {shiftPlan.status === 'published' ? 'Veröffentlicht' : 'Entwurf'}
</div> </div>
</div> </div>
<div style={{ display: 'flex', gap: '10px', alignItems: 'center' }}> <div style={{ display: 'flex', gap: '10px', alignItems: 'center' }}>
{shiftPlan.status === 'published' && hasRole(['admin', 'maintenance']) && ( {/* "Zuweisungen neu berechnen" button */}
{shiftPlan.status === 'published' && hasRole(['admin', 'maintenance']) && (
<button <button
onClick={handleRecreateAssignments} onClick={handleRecreateAssignments}
disabled={recreating} disabled={recreating}
@@ -1022,7 +1135,7 @@ const ShiftPlanView: React.FC = () => {
{recreating ? 'Lösche Zuweisungen...' : 'Zuweisungen neu berechnen'} {recreating ? 'Lösche Zuweisungen...' : 'Zuweisungen neu berechnen'}
</button> </button>
)} )}
<button <button
onClick={() => navigate('/shift-plans')} onClick={() => navigate('/shift-plans')}
style={{ style={{
@@ -1057,15 +1170,15 @@ const ShiftPlanView: React.FC = () => {
<div style={{ fontSize: '18px', fontWeight: 'bold' }}> <div style={{ fontSize: '18px', fontWeight: 'bold' }}>
{availabilityStatus.completed} / {availabilityStatus.total} Mitarbeiter {availabilityStatus.completed} / {availabilityStatus.total} Mitarbeiter
</div> </div>
<div style={{ <div style={{
width: '200px', width: '200px',
height: '8px', height: '8px',
backgroundColor: '#e0e0e0', backgroundColor: '#e0e0e0',
borderRadius: '4px', borderRadius: '4px',
marginTop: '5px', marginTop: '5px',
overflow: 'hidden' overflow: 'hidden'
}}> }}>
<div <div
style={{ style={{
width: `${availabilityStatus.percentage}%`, width: `${availabilityStatus.percentage}%`,
height: '100%', height: '100%',
@@ -1075,7 +1188,7 @@ const ShiftPlanView: React.FC = () => {
/> />
</div> </div>
</div> </div>
{hasRole(['admin', 'maintenance']) && ( {hasRole(['admin', 'maintenance']) && (
<div> <div>
<button <button
@@ -1093,11 +1206,11 @@ const ShiftPlanView: React.FC = () => {
> >
{publishing ? 'Berechne...' : 'Automatisch zuweisen'} {publishing ? 'Berechne...' : 'Automatisch zuweisen'}
</button> </button>
{!canPublish() && ( {!canPublish() && (
<div style={{ fontSize: '12px', color: '#666', marginTop: '5px' }}> <div style={{ fontSize: '12px', color: '#666', marginTop: '5px' }}>
{availabilityStatus.percentage === 100 {availabilityStatus.percentage === 100
? 'Bereit zur Berechnung' ? 'Bereit zur Berechnung'
: `${availabilityStatus.total - availabilityStatus.completed} Mitarbeiter müssen noch Verfügbarkeit eintragen`} : `${availabilityStatus.total - availabilityStatus.completed} Mitarbeiter müssen noch Verfügbarkeit eintragen`}
</div> </div>
)} )}
@@ -1142,7 +1255,7 @@ const ShiftPlanView: React.FC = () => {
width: '90%' width: '90%'
}}> }}>
<h2>Wochenmuster-Zuordnung</h2> <h2>Wochenmuster-Zuordnung</h2>
{/* Detaillierter Reparatur-Bericht anzeigen */} {/* Detaillierter Reparatur-Bericht anzeigen */}
{assignmentResult?.resolutionReport && ( {assignmentResult?.resolutionReport && (
<div style={{ <div style={{
@@ -1158,15 +1271,15 @@ const ShiftPlanView: React.FC = () => {
<h4 style={{ color: '#2c3e50', marginTop: 0, display: 'flex', alignItems: 'center', gap: '10px' }}> <h4 style={{ color: '#2c3e50', marginTop: 0, display: 'flex', alignItems: 'center', gap: '10px' }}>
<span>📋</span> Detaillierter Reparatur-Bericht <span>📋</span> Detaillierter Reparatur-Bericht
</h4> </h4>
<div style={{ <div style={{
fontFamily: 'monospace', fontFamily: 'monospace',
fontSize: '12px', fontSize: '12px',
lineHeight: '1.4' lineHeight: '1.4'
}}> }}>
{assignmentResult.resolutionReport.map((line, index) => { {assignmentResult.resolutionReport.map((line, index) => {
let color = '#2c3e50'; let color = '#2c3e50';
let fontWeight = 'normal'; let fontWeight = 'normal';
if (line.includes('✅') || line.includes('ALLES KRITISCHEN PROBLEME BEHOBEN')) { if (line.includes('✅') || line.includes('ALLES KRITISCHEN PROBLEME BEHOBEN')) {
color = '#2ecc71'; color = '#2ecc71';
fontWeight = 'bold'; fontWeight = 'bold';
@@ -1181,9 +1294,9 @@ const ShiftPlanView: React.FC = () => {
} else if (line.startsWith(' •') || line.startsWith(' -')) { } else if (line.startsWith(' •') || line.startsWith(' -')) {
color = '#7f8c8d'; color = '#7f8c8d';
} }
return ( return (
<div key={index} style={{ <div key={index} style={{
color, color,
fontWeight, fontWeight,
marginBottom: line === '' ? '5px' : '2px', marginBottom: line === '' ? '5px' : '2px',
@@ -1196,16 +1309,14 @@ const ShiftPlanView: React.FC = () => {
</div> </div>
</div> </div>
)} )}
{/* KORRIGIERTE ZUSAMMENFASSUNG */} {/* ZUSAMMENFASSUNG */}
{assignmentResult && ( {assignmentResult && (
<div style={{ marginBottom: '20px' }}> <div style={{ marginBottom: '20px' }}>
<h4>Zusammenfassung:</h4> <h4>Zusammenfassung:</h4>
{/* Entscheidung basierend auf tatsächlichen kritischen Problemen */} {/* Entscheidung basierend auf tatsächlichen kritischen Problemen */}
{assignmentResult.violations.filter(v => {(assignmentResult.violations.length === 0) || assignmentResult.success == true ? (
v.includes('ERROR:') || v.includes('❌ KRITISCH:')
).length === 0 ? (
<div style={{ <div style={{
padding: '15px', padding: '15px',
backgroundColor: '#d4edda', backgroundColor: '#d4edda',
@@ -1243,7 +1354,7 @@ const ShiftPlanView: React.FC = () => {
</ul> </ul>
</div> </div>
)} )}
{/* Warnungen separat anzeigen - NUR wenn welche vorhanden sind */} {/* Warnungen separat anzeigen - NUR wenn welche vorhanden sind */}
{assignmentResult.violations.some(v => v.includes('WARNING:') || v.includes('⚠️')) && ( {assignmentResult.violations.some(v => v.includes('WARNING:') || v.includes('⚠️')) && (
<div style={{ <div style={{
@@ -1287,34 +1398,26 @@ const ShiftPlanView: React.FC = () => {
> >
Abbrechen Abbrechen
</button> </button>
{/* KORRIGIERTER BUTTON MIT TYPESCRIPT-FIX */} {/* BUTTON zum publishen */}
<button <button
onClick={handlePublish} onClick={handlePublish}
disabled={publishing || (assignmentResult ? assignmentResult.violations.filter(v => disabled={publishing || !canPublishAssignment()}
v.includes('ERROR:') || v.includes('❌ KRITISCH:')
).length > 0 : true)}
style={{ style={{
padding: '10px 20px', padding: '10px 20px',
backgroundColor: assignmentResult ? (assignmentResult.violations.filter(v => backgroundColor: canPublishAssignment() ? '#2ecc71' : '#95a5a6',
v.includes('ERROR:') || v.includes('❌ KRITISCH:')
).length === 0 ? '#2ecc71' : '#95a5a6') : '#95a5a6',
color: 'white', color: 'white',
border: 'none', border: 'none',
borderRadius: '4px', borderRadius: '4px',
cursor: assignmentResult ? (assignmentResult.violations.filter(v => cursor: canPublishAssignment() ? 'pointer' : 'not-allowed',
v.includes('ERROR:') || v.includes('❌ KRITISCH:')
).length === 0 ? 'pointer' : 'not-allowed') : 'not-allowed',
fontWeight: 'bold', fontWeight: 'bold',
fontSize: '16px' fontSize: '16px'
}} }}
> >
{publishing ? 'Veröffentliche...' : ( {publishing ? 'Veröffentliche...' : (
assignmentResult ? ( assignmentResult ? (
assignmentResult.violations.filter(v => canPublishAssignment()
v.includes('ERROR:') || v.includes('❌ KRITISCH:') ? 'Schichtplan veröffentlichen'
).length === 0
? 'Schichtplan veröffentlichen'
: 'Kritische Probleme müssen behoben werden' : 'Kritische Probleme müssen behoben werden'
) : 'Lade Zuordnungen...' ) : 'Lade Zuordnungen...'
)} )}
@@ -1322,7 +1425,7 @@ const ShiftPlanView: React.FC = () => {
</div> </div>
</div> </div>
</div> </div>
)} )}
{/* Timetable */} {/* Timetable */}
<div style={{ <div style={{
@@ -1332,13 +1435,71 @@ const ShiftPlanView: React.FC = () => {
boxShadow: '0 2px 4px rgba(0,0,0,0.1)' boxShadow: '0 2px 4px rgba(0,0,0,0.1)'
}}> }}>
<h3> <h3>
Schichtplan Schichtplan
{shiftPlan.status === 'published' && ' (Aktuelle Zuweisungen)'} {shiftPlan.status === 'published' && ' (Aktuelle Zuweisungen)'}
{assignmentResult && shiftPlan.status === 'draft' && ' (Exemplarische Woche)'} {assignmentResult && shiftPlan.status === 'draft' && ' (Exemplarische Woche)'}
</h3> </h3>
{renderTimetable()} {renderTimetable()}
{shiftPlan.status === 'published' && hasRole(['admin', 'maintenance']) && (
<div style={{
display: 'flex',
alignItems: 'center',
justifyContent: 'flex-end',
marginTop: '20px',
gap: '10px'
}}>
{/* Export Dropdown Container */}
<div
ref={dropdownRef}
style={{
transform: exportType ? `translateX(-${dropdownWidth}px)` : 'translateX(0)',
transition: 'transform 0.3s ease-in-out',
position: 'relative'
}}
>
<select
value={exportType || ''}
onChange={(e) => setExportType(e.target.value as 'pdf' | 'excel' | null)}
style={{
padding: '10px 20px',
backgroundColor: 'white',
border: '1px solid #ddd',
borderRadius: '4px',
cursor: 'pointer',
minWidth: '120px'
}}
>
<option value="">Export</option>
<option value="pdf">PDF</option>
<option value="excel">Excel</option>
</select>
</div>
{/* Export Button - erscheint nur wenn eine Option ausgewählt ist */}
{exportType && (
<button
onClick={handleExport}
disabled={exporting}
style={{
padding: '10px 20px',
backgroundColor: '#51258f',
color: 'white',
border: 'none',
borderRadius: '4px',
cursor: exporting ? 'not-allowed' : 'pointer',
fontWeight: 'bold',
opacity: exporting ? 0.7 : 1,
transition: 'opacity 0.2s ease'
}}
>
{exporting ? '🔄 Exportiert...' : 'EXPORT'}
</button>
)}
</div>
)}
{/* Summary */} {/* Summary */}
{days.length > 0 && ( {days.length > 0 && (
<div style={{ <div style={{
@@ -1350,11 +1511,11 @@ const ShiftPlanView: React.FC = () => {
fontSize: '14px' fontSize: '14px'
}}> }}>
<strong>Legende:</strong> { <strong>Legende:</strong> {
shiftPlan.status === 'published' shiftPlan.status === 'published'
? 'Angezeigt werden die aktuell zugewiesenen Mitarbeiter' ? 'Angezeigt werden die aktuell zugewiesenen Mitarbeiter'
: assignmentResult : assignmentResult
? 'Angezeigt werden die vorgeschlagenen Mitarbeiter für eine exemplarische Woche' ? 'Angezeigt werden die vorgeschlagenen Mitarbeiter für eine exemplarische Woche'
: 'Angezeigt wird "zugewiesene/benötigte Mitarbeiter" pro Schicht und Wochentag' : 'Angezeigt wird "zugewiesene/benötigte Mitarbeiter" pro Schicht und Wochentag'
} }
</div> </div>
)} )}

View File

@@ -0,0 +1,123 @@
import React, { useState } from 'react';
import { ICONS, addIconButton, addTextButton, cancelTextButton } from '../../../utils/buttonStyles';
import Modal from '../../../components/Modal/Modal';
interface DayOption {
id: number;
name: string;
}
interface AddDayButtonProps {
activeDays: number[];
onAddDay: (dayOfWeek: number) => void;
disabled?: boolean;
}
const ALL_DAYS: DayOption[] = [
{ id: 1, name: 'Montag' },
{ id: 2, name: 'Dienstag' },
{ id: 3, name: 'Mittwoch' },
{ id: 4, name: 'Donnerstag' },
{ id: 5, name: 'Freitag' },
{ id: 6, name: 'Samstag' },
{ id: 7, name: 'Sonntag' },
];
const AddDayButton: React.FC<AddDayButtonProps> = ({
activeDays,
onAddDay,
disabled = false
}) => {
const [showModal, setShowModal] = useState(false);
const [selectedDay, setSelectedDay] = useState<number | null>(null);
const availableDays = ALL_DAYS.filter(day => !activeDays.includes(day.id));
const handleAddDay = () => {
if (selectedDay !== null) {
onAddDay(selectedDay);
setShowModal(false);
setSelectedDay(null);
}
};
const isDisabled = disabled || availableDays.length === 0;
if (availableDays.length === 0) {
return null;
}
return (
<>
<button
onClick={() => setShowModal(true)}
style={addIconButton(isDisabled)}
disabled={isDisabled}
title="Tag hinzufügen"
>
{ICONS.add}
</button>
<Modal
isOpen={showModal}
onClose={() => {
setShowModal(false);
setSelectedDay(null);
}}
title="Tag hinzufügen"
width="350px"
>
<div style={{ marginBottom: '16px' }}>
<label style={{
display: 'block',
marginBottom: '8px',
fontWeight: 'bold',
fontSize: '14px',
color: '#2c3e50'
}}>
Wählen Sie einen Tag:
</label>
<select
value={selectedDay ?? ''}
onChange={(e) => setSelectedDay(e.target.value ? Number(e.target.value) : null)}
style={{
width: '100%',
padding: '10px',
borderRadius: '4px',
border: '1px solid #ddd',
fontSize: '14px',
}}
>
<option value="">-- Tag auswählen --</option>
{availableDays.map(day => (
<option key={day.id} value={day.id}>
{day.name}
</option>
))}
</select>
</div>
<div style={{ display: 'flex', gap: '8px', justifyContent: 'flex-end' }}>
<button
onClick={handleAddDay}
disabled={selectedDay === null}
style={addTextButton(selectedDay === null)}
>
{ICONS.add} Hinzufügen
</button>
<button
onClick={() => {
setShowModal(false);
setSelectedDay(null);
}}
style={cancelTextButton(false)}
>
Abbrechen
</button>
</div>
</Modal>
</>
);
};
export default AddDayButton;

View File

@@ -0,0 +1,234 @@
import React, { useState, useEffect } from 'react';
import { Shift } from '../../../models/ShiftPlan';
import {
ICONS,
addTextButton,
deleteTextButton,
cancelTextButton,
BUTTON_COLORS,
} from '../../../utils/buttonStyles';
import Modal from '../../../components/Modal/Modal';
interface ShiftCellProps {
shift: Shift | null;
dayOfWeek: number;
timeSlotId: string;
onAdd: (dayOfWeek: number, timeSlotId: string, requiredEmployees: number, color: string) => void;
onEdit: (shift: Shift, requiredEmployees: number, color: string) => void;
onDelete: (shiftId: string) => void;
disabled?: boolean;
}
const COLORS = [
'#3498db', // Blue (default)
'#27ae60', // Green
'#e74c3c', // Red
'#f39c12', // Orange
'#9b59b6', // Purple
'#1abc9c', // Teal
'#e91e63', // Pink
'#795548', // Brown
];
const ShiftCell: React.FC<ShiftCellProps> = ({
shift,
dayOfWeek,
timeSlotId,
onAdd,
onEdit,
onDelete,
disabled = false
}) => {
const [showModal, setShowModal] = useState(false);
const [requiredEmployees, setRequiredEmployees] = useState(shift?.requiredEmployees || 2);
const [selectedColor, setSelectedColor] = useState(shift?.color || '#3498db');
const [isHovered, setIsHovered] = useState(false);
useEffect(() => {
if (shift) {
setRequiredEmployees(shift.requiredEmployees);
setSelectedColor(shift.color || '#3498db');
} else {
setRequiredEmployees(2);
setSelectedColor('#3498db');
}
}, [shift]);
const handleCellClick = () => {
if (disabled) return;
setShowModal(true);
};
const handleSave = () => {
if (shift) {
onEdit(shift, requiredEmployees, selectedColor);
} else {
onAdd(dayOfWeek, timeSlotId, requiredEmployees, selectedColor);
}
setShowModal(false);
};
const handleDelete = () => {
if (shift) {
onDelete(shift.id);
}
setShowModal(false);
};
const handleClose = () => {
if (shift) {
setRequiredEmployees(shift.requiredEmployees);
setSelectedColor(shift.color || '#3498db');
} else {
setRequiredEmployees(2);
setSelectedColor('#3498db');
}
setShowModal(false);
};
const cellStyle: React.CSSProperties = {
padding: '8px',
textAlign: 'center',
cursor: disabled ? 'not-allowed' : 'pointer',
minWidth: '80px',
height: '60px',
verticalAlign: 'middle',
transition: 'all 0.2s ease',
border: '1px solid #dee2e6',
...(shift ? {
backgroundColor: shift.color ? `${shift.color}20` : '#d5f4e6',
borderColor: shift.color || '#27ae60',
borderWidth: '2px',
} : {
backgroundColor: isHovered ? '#f0fff4' : '#f8f9fa',
borderStyle: 'dashed',
borderColor: isHovered ? BUTTON_COLORS.add : '#dee2e6',
}),
opacity: disabled ? 0.6 : 1,
};
const inputStyle: React.CSSProperties = {
width: '100%',
padding: '10px',
borderRadius: '4px',
border: '1px solid #ddd',
fontSize: '14px',
boxSizing: 'border-box',
};
const labelStyle: React.CSSProperties = {
display: 'block',
marginBottom: '6px',
fontWeight: 'bold',
fontSize: '14px',
color: '#2c3e50',
};
return (
<>
<td
style={cellStyle}
onClick={handleCellClick}
onMouseEnter={() => setIsHovered(true)}
onMouseLeave={() => setIsHovered(false)}
>
{shift ? (
<div>
<div style={{
width: '28px',
height: '28px',
borderRadius: '50%',
backgroundColor: shift.color || '#27ae60',
margin: '0 auto 4px',
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
}}>
<span style={{ color: 'white', fontSize: '12px', fontWeight: 'bold' }}>
{shift.requiredEmployees}
</span>
</div>
<span style={{ fontSize: '11px', color: '#666' }}>
Mitarbeiter
</span>
</div>
) : (
<div style={{
color: BUTTON_COLORS.add,
fontSize: '24px',
opacity: isHovered ? 1 : 0.4,
transition: 'opacity 0.2s ease',
}}>
{ICONS.add}
</div>
)}
</td>
<Modal
isOpen={showModal}
onClose={handleClose}
title={shift ? 'Schicht bearbeiten' : 'Schicht hinzufügen'}
width="380px"
>
<div style={{ marginBottom: '16px' }}>
<label style={labelStyle}>Benötigte Mitarbeiter *</label>
<input
type="number"
min="1"
max="99"
value={requiredEmployees}
onChange={(e) => setRequiredEmployees(parseInt(e.target.value) || 1)}
style={inputStyle}
/>
</div>
<div style={{ marginBottom: '20px' }}>
<label style={labelStyle}>Farbe</label>
<div style={{ display: 'flex', gap: '8px', flexWrap: 'wrap' }}>
{COLORS.map((color) => (
<button
key={color}
onClick={() => setSelectedColor(color)}
style={{
width: '36px',
height: '36px',
borderRadius: '6px',
backgroundColor: color,
border: selectedColor === color ? '3px solid #2c3e50' : '2px solid transparent',
cursor: 'pointer',
transition: 'transform 0.1s ease',
}}
title={color}
/>
))}
</div>
</div>
<div style={{ display: 'flex', gap: '8px', justifyContent: 'flex-end' }}>
<button
onClick={handleSave}
style={{ ...addTextButton(false), flex: 1 }}
>
{shift ? 'Speichern' : `${ICONS.add} Hinzufügen`}
</button>
{shift && (
<button
onClick={handleDelete}
style={deleteTextButton(false)}
>
{ICONS.delete} Löschen
</button>
)}
<button
onClick={handleClose}
style={cancelTextButton(false)}
>
Abbrechen
</button>
</div>
</Modal>
</>
);
};
export default ShiftCell;

View File

@@ -0,0 +1,199 @@
import React, { useState, useEffect } from 'react';
import { TimeSlot } from '../../../models/ShiftPlan';
import {
ICONS,
addTextButton,
deleteTextButton,
cancelTextButton,
borderlessEditButton,
} from '../../../utils/buttonStyles';
import Modal from '../../../components/Modal/Modal';
interface TimeSlotEditorProps {
slot: TimeSlot;
onUpdate: (slot: TimeSlot, name: string, startTime: string, endTime: string, description?: string) => void;
onDelete: (slotId: string) => void;
shiftsCount: number;
disabled?: boolean;
}
const TimeSlotEditor: React.FC<TimeSlotEditorProps> = ({
slot,
onUpdate,
onDelete,
shiftsCount,
disabled = false
}) => {
const [showModal, setShowModal] = useState(false);
const [name, setName] = useState(slot.name);
const [startTime, setStartTime] = useState(slot.startTime);
const [endTime, setEndTime] = useState(slot.endTime);
const [description, setDescription] = useState(slot.description || '');
useEffect(() => {
setName(slot.name);
setStartTime(slot.startTime);
setEndTime(slot.endTime);
setDescription(slot.description || '');
}, [slot]);
const handleEditClick = () => {
if (disabled) return;
setShowModal(true);
};
const handleSave = () => {
onUpdate(slot, name, startTime, endTime, description || undefined);
setShowModal(false);
};
const handleDelete = () => {
onDelete(slot.id);
setShowModal(false);
};
const handleClose = () => {
setName(slot.name);
setStartTime(slot.startTime);
setEndTime(slot.endTime);
setDescription(slot.description || '');
setShowModal(false);
};
const formatTime = (time: string) => {
return time.substring(0, 5);
};
const inputStyle: React.CSSProperties = {
width: '100%',
padding: '10px',
borderRadius: '4px',
border: '1px solid #ddd',
fontSize: '14px',
boxSizing: 'border-box',
};
const labelStyle: React.CSSProperties = {
display: 'block',
marginBottom: '6px',
fontWeight: 'bold',
fontSize: '14px',
color: '#2c3e50',
};
return (
<>
<div style={{
display: 'flex',
alignItems: 'center',
gap: '8px',
}}>
<button
onClick={handleEditClick}
style={borderlessEditButton(disabled)}
title="Zeit-Slot bearbeiten"
disabled={disabled}
>
{ICONS.edit}
</button>
<div>
<div style={{ fontWeight: 'bold', fontSize: '14px', color: '#2c3e50' }}>
{slot.name}
</div>
<div style={{ fontSize: '12px', color: '#666' }}>
{formatTime(slot.startTime)} - {formatTime(slot.endTime)}
</div>
</div>
</div>
<Modal
isOpen={showModal}
onClose={handleClose}
title="Zeit-Slot bearbeiten"
width="400px"
>
<div style={{ marginBottom: '16px' }}>
<label style={labelStyle}>Name *</label>
<input
type="text"
value={name}
onChange={(e) => setName(e.target.value)}
style={inputStyle}
placeholder="z.B. Vormittag"
/>
</div>
<div style={{ display: 'grid', gridTemplateColumns: '1fr 1fr', gap: '16px', marginBottom: '16px' }}>
<div>
<label style={labelStyle}>Startzeit *</label>
<input
type="time"
value={startTime}
onChange={(e) => setStartTime(e.target.value)}
style={inputStyle}
/>
</div>
<div>
<label style={labelStyle}>Endzeit *</label>
<input
type="time"
value={endTime}
onChange={(e) => setEndTime(e.target.value)}
style={inputStyle}
/>
</div>
</div>
<div style={{ marginBottom: '20px' }}>
<label style={labelStyle}>Beschreibung (optional)</label>
<input
type="text"
value={description}
onChange={(e) => setDescription(e.target.value)}
style={inputStyle}
placeholder="Optionale Beschreibung"
/>
</div>
{shiftsCount > 0 && (
<div style={{
marginBottom: '16px',
padding: '12px',
backgroundColor: '#fff3cd',
borderRadius: '4px',
fontSize: '13px',
color: '#856404',
border: '1px solid #ffc107',
}}>
Dieser Zeit-Slot enthält {shiftsCount} Schicht(en). Beim Löschen werden alle zugehörigen Schichten entfernt.
</div>
)}
<div style={{ display: 'flex', gap: '8px', justifyContent: 'flex-end' }}>
<button
onClick={handleSave}
disabled={!name}
style={addTextButton(!name)}
>
Speichern
</button>
<button
onClick={handleDelete}
style={deleteTextButton(false)}
title={shiftsCount > 0 ? `Enthält ${shiftsCount} Schicht(en)` : undefined}
>
{ICONS.delete} Löschen
</button>
<button
onClick={handleClose}
style={cancelTextButton(false)}
>
Abbrechen
</button>
</div>
</Modal>
</>
);
};
export default TimeSlotEditor;

View File

@@ -26,7 +26,7 @@ export class ApiClient {
return token ? { 'Authorization': `Bearer ${token}` } : {}; return token ? { 'Authorization': `Bearer ${token}` } : {};
} }
private async handleApiResponse<T>(response: Response): Promise<T> { private async handleApiResponse<T>(response: Response, responseType: 'json' | 'blob' = 'json'): Promise<T> {
if (!response.ok) { if (!response.ok) {
let errorData; let errorData;
@@ -61,7 +61,12 @@ export class ApiClient {
); );
} }
// For successful responses, try to parse as JSON // Handle blob responses (for file downloads)
if (responseType === 'blob') {
return response.blob() as Promise<T>;
}
// For successful JSON responses, try to parse as JSON
try { try {
const responseText = await response.text(); const responseText = await response.text();
return responseText ? JSON.parse(responseText) : {} as T; return responseText ? JSON.parse(responseText) : {} as T;
@@ -71,7 +76,7 @@ export class ApiClient {
} }
} }
async request<T>(endpoint: string, options: RequestInit = {}): Promise<T> { async request<T>(endpoint: string, options: RequestInit = {}, responseType: 'json' | 'blob' = 'json'): Promise<T> {
const url = `${this.baseURL}${endpoint}`; const url = `${this.baseURL}${endpoint}`;
const config: RequestInit = { const config: RequestInit = {
@@ -85,7 +90,7 @@ export class ApiClient {
try { try {
const response = await fetch(url, config); const response = await fetch(url, config);
return await this.handleApiResponse<T>(response); return await this.handleApiResponse<T>(response, responseType);
} catch (error) { } catch (error) {
// Re-throw the error to be caught by useBackendValidation // Re-throw the error to be caught by useBackendValidation
if (error instanceof ApiError) { if (error instanceof ApiError) {

View File

@@ -1,7 +1,34 @@
import { ShiftPlan, CreateShiftPlanRequest } from '../models/ShiftPlan'; import { ShiftPlan, CreateShiftPlanRequest, TimeSlot, Shift } from '../models/ShiftPlan';
import { TEMPLATE_PRESETS } from '../models/defaults/shiftPlanDefaults'; import { TEMPLATE_PRESETS } from '../models/defaults/shiftPlanDefaults';
import { apiClient } from './apiClient'; import { apiClient } from './apiClient';
// Request types for time slot and shift operations
export interface CreateTimeSlotRequest {
name: string;
startTime: string;
endTime: string;
description?: string;
}
export interface UpdateTimeSlotRequest {
name?: string;
startTime?: string;
endTime?: string;
description?: string;
}
export interface CreateShiftRequest {
timeSlotId: string;
dayOfWeek: number;
requiredEmployees: number;
color?: string;
}
export interface UpdateShiftRequest {
requiredEmployees?: number;
color?: string;
}
export const shiftPlanService = { export const shiftPlanService = {
async getShiftPlans(): Promise<ShiftPlan[]> { async getShiftPlans(): Promise<ShiftPlan[]> {
try { try {
@@ -126,4 +153,140 @@ export const shiftPlanService = {
throw error; throw error;
} }
}, },
async exportShiftPlanToExcel(planId: string): Promise<Blob> {
try {
console.log('📊 Exporting shift plan to Excel:', planId);
// Use the apiClient with blob response handling
const blob = await apiClient.request<Blob>(`/shift-plans/${planId}/export/excel`, {
method: 'GET',
}, 'blob');
console.log('✅ Excel export successful');
return blob;
} catch (error: any) {
console.error('❌ Error exporting to Excel:', error);
if (error.statusCode === 401) {
localStorage.removeItem('token');
localStorage.removeItem('employee');
throw new Error('Nicht authorisiert - bitte erneut anmelden');
}
if (error.statusCode === 404) {
throw new Error('Schichtplan nicht gefunden');
}
throw new Error('Fehler beim Excel-Export des Schichtplans');
}
},
async exportShiftPlanToPDF(planId: string): Promise<Blob> {
try {
console.log('📄 Exporting shift plan to PDF:', planId);
// Use the apiClient with blob response handling
const blob = await apiClient.request<Blob>(`/shift-plans/${planId}/export/pdf`, {
method: 'GET',
}, 'blob');
console.log('✅ PDF export successful');
return blob;
} catch (error: any) {
console.error('❌ Error exporting to PDF:', error);
if (error.statusCode === 401) {
localStorage.removeItem('token');
localStorage.removeItem('employee');
throw new Error('Nicht authorisiert - bitte erneut anmelden');
}
if (error.statusCode === 404) {
throw new Error('Schichtplan nicht gefunden');
}
throw new Error('Fehler beim PDF-Export des Schichtplans');
}
},
// Time Slot operations
async addTimeSlot(planId: string, timeSlot: CreateTimeSlotRequest): Promise<TimeSlot> {
try {
return await apiClient.post<TimeSlot>(`/shift-plans/${planId}/time-slots`, timeSlot);
} catch (error: any) {
if (error.statusCode === 401) {
localStorage.removeItem('token');
localStorage.removeItem('employee');
throw new Error('Nicht authorisiert - bitte erneut anmelden');
}
throw new Error('Fehler beim Hinzufügen des Zeit-Slots');
}
},
async updateTimeSlot(planId: string, slotId: string, data: UpdateTimeSlotRequest): Promise<TimeSlot> {
try {
return await apiClient.put<TimeSlot>(`/shift-plans/${planId}/time-slots/${slotId}`, data);
} catch (error: any) {
if (error.statusCode === 401) {
localStorage.removeItem('token');
localStorage.removeItem('employee');
throw new Error('Nicht authorisiert - bitte erneut anmelden');
}
throw new Error('Fehler beim Aktualisieren des Zeit-Slots');
}
},
async deleteTimeSlot(planId: string, slotId: string): Promise<void> {
try {
await apiClient.delete(`/shift-plans/${planId}/time-slots/${slotId}`);
} catch (error: any) {
if (error.statusCode === 401) {
localStorage.removeItem('token');
localStorage.removeItem('employee');
throw new Error('Nicht authorisiert - bitte erneut anmelden');
}
throw new Error('Fehler beim Löschen des Zeit-Slots');
}
},
// Shift operations
async addShift(planId: string, shift: CreateShiftRequest): Promise<Shift> {
try {
return await apiClient.post<Shift>(`/shift-plans/${planId}/shifts`, shift);
} catch (error: any) {
if (error.statusCode === 401) {
localStorage.removeItem('token');
localStorage.removeItem('employee');
throw new Error('Nicht authorisiert - bitte erneut anmelden');
}
throw new Error('Fehler beim Hinzufügen der Schicht');
}
},
async updateShift(planId: string, shiftId: string, data: UpdateShiftRequest): Promise<Shift> {
try {
return await apiClient.patch<Shift>(`/shift-plans/${planId}/shifts/${shiftId}`, data);
} catch (error: any) {
if (error.statusCode === 401) {
localStorage.removeItem('token');
localStorage.removeItem('employee');
throw new Error('Nicht authorisiert - bitte erneut anmelden');
}
throw new Error('Fehler beim Aktualisieren der Schicht');
}
},
async deleteShift(planId: string, shiftId: string): Promise<void> {
try {
await apiClient.delete(`/shift-plans/${planId}/shifts/${shiftId}`);
} catch (error: any) {
if (error.statusCode === 401) {
localStorage.removeItem('token');
localStorage.removeItem('employee');
throw new Error('Nicht authorisiert - bitte erneut anmelden');
}
throw new Error('Fehler beim Löschen der Schicht');
}
},
}; };

View File

@@ -0,0 +1,150 @@
// Unified button styles for consistent UI across the application
import React from 'react';
// Color palette
export const BUTTON_COLORS = {
delete: '#e74c3c',
add: '#27ae60',
edit: '#f39c12',
cancel: '#95a5a6',
info: '#3498db',
primary: '#2c3e50',
};
// Icon constants for uniform usage
export const ICONS = {
delete: '-',
add: '+',
edit: '✎',
close: '✕',
calendar: '📅',
};
// Base button style
const baseButtonStyle: React.CSSProperties = {
border: 'none',
borderRadius: '4px',
cursor: 'pointer',
fontWeight: 'bold',
transition: 'opacity 0.2s ease',
};
// Icon button (small, square) - for inline actions
export const iconButtonStyle = (
color: string,
disabled = false
): React.CSSProperties => ({
...baseButtonStyle,
padding: '6px 8px',
backgroundColor: color,
color: 'white',
fontSize: '14px',
minWidth: '32px',
height: '32px',
display: 'inline-flex',
alignItems: 'center',
justifyContent: 'center',
cursor: disabled ? 'not-allowed' : 'pointer',
opacity: disabled ? 0.5 : 1,
});
// Small inline icon button (for table cells, headers)
export const smallIconButtonStyle = (
color: string,
disabled = false
): React.CSSProperties => ({
...baseButtonStyle,
padding: '4px 8px',
backgroundColor: color,
color: 'white',
fontSize: '12px',
minWidth: '24px',
height: '24px',
display: 'inline-flex',
alignItems: 'center',
justifyContent: 'center',
cursor: disabled ? 'not-allowed' : 'pointer',
opacity: disabled ? 0.5 : 1,
});
// Text button with icon prefix
export const textButtonStyle = (
color: string,
disabled = false
): React.CSSProperties => ({
...baseButtonStyle,
padding: '8px 16px',
backgroundColor: color,
color: 'white',
fontSize: '14px',
cursor: disabled ? 'not-allowed' : 'pointer',
opacity: disabled ? 0.6 : 1,
});
// Outline/dashed button for "add new" actions
export const outlineButtonStyle = (
color: string,
disabled = false
): React.CSSProperties => ({
...baseButtonStyle,
padding: '10px 20px',
backgroundColor: 'transparent',
color: color,
border: `2px dashed ${color}`,
fontSize: '14px',
width: '100%',
cursor: disabled ? 'not-allowed' : 'pointer',
opacity: disabled ? 0.6 : 1,
});
// Borderless icon button (for minimal UI elements)
export const borderlessIconButtonStyle = (
color: string,
disabled = false
): React.CSSProperties => ({
background: 'none',
border: 'none',
color: color,
cursor: disabled ? 'not-allowed' : 'pointer',
fontSize: '16px',
padding: '4px 8px',
opacity: disabled ? 0.5 : 1,
display: 'inline-flex',
alignItems: 'center',
justifyContent: 'center',
});
// Preset button styles for common actions
export const deleteIconButton = (disabled = false) =>
iconButtonStyle(BUTTON_COLORS.delete, disabled);
export const addIconButton = (disabled = false) =>
iconButtonStyle(BUTTON_COLORS.add, disabled);
export const editIconButton = (disabled = false) =>
iconButtonStyle(BUTTON_COLORS.edit, disabled);
export const deleteTextButton = (disabled = false) =>
textButtonStyle(BUTTON_COLORS.delete, disabled);
export const addTextButton = (disabled = false) =>
textButtonStyle(BUTTON_COLORS.add, disabled);
export const cancelTextButton = (disabled = false) =>
textButtonStyle(BUTTON_COLORS.cancel, disabled);
export const addOutlineButton = (disabled = false) =>
outlineButtonStyle(BUTTON_COLORS.add, disabled);
export const smallDeleteButton = (disabled = false) =>
smallIconButtonStyle(BUTTON_COLORS.delete, disabled);
export const smallAddButton = (disabled = false) =>
smallIconButtonStyle(BUTTON_COLORS.add, disabled);
export const borderlessDeleteButton = (disabled = false) =>
borderlessIconButtonStyle(BUTTON_COLORS.delete, disabled);
export const borderlessEditButton = (disabled = false) =>
borderlessIconButtonStyle(BUTTON_COLORS.edit, disabled);

5511
package-lock.json generated

File diff suppressed because it is too large Load Diff

View File

@@ -3,7 +3,7 @@
"private": true, "private": true,
"workspaces": [ "workspaces": [
"frontend", "frontend",
"backend", "backend",
"premium" "premium"
], ],
"scripts": { "scripts": {
@@ -12,7 +12,7 @@
"build:all": "npm run build --workspace=backend && npm run build --workspace=frontend", "build:all": "npm run build --workspace=backend && npm run build --workspace=frontend",
"dev": "concurrently \"npm run dev:backend\" \"npm run dev:frontend\"", "dev": "concurrently \"npm run dev:backend\" \"npm run dev:frontend\"",
"dev:frontend": "cd frontend && npm run dev", "dev:frontend": "cd frontend && npm run dev",
"dev:backend": "cd backend && npm run dev:single" "dev:backend": "cd backend && npm run dev:all"
}, },
"devDependencies": { "devDependencies": {
"typescript": "^5.3.3", "typescript": "^5.3.3",