mirror of
https://github.com/donpat1to/Schichtenplaner.git
synced 2025-12-01 06:55:45 +01:00
Compare commits
4 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| cae2b83649 | |||
| a69e934075 | |||
| 3ad497dd76 | |||
| b302c447f8 |
@@ -756,8 +756,8 @@ export const changePassword = async (req: AuthRequest, res: Response): Promise<v
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
// For non-admin users, verify current password
|
// Verify current password
|
||||||
if (currentUser?.role !== 'admin') {
|
if (employee) {
|
||||||
const isValidPassword = await bcrypt.compare(currentPassword, employee.password);
|
const isValidPassword = await bcrypt.compare(currentPassword, employee.password);
|
||||||
if (!isValidPassword) {
|
if (!isValidPassword) {
|
||||||
res.status(400).json({ error: 'Current password is incorrect' });
|
res.status(400).json({ error: 'Current password is incorrect' });
|
||||||
@@ -766,8 +766,8 @@ export const changePassword = async (req: AuthRequest, res: Response): Promise<v
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Validate new password
|
// Validate new password
|
||||||
if (!newPassword || newPassword.length < 6) {
|
if (!newPassword || newPassword.length < 8) {
|
||||||
res.status(400).json({ error: 'New password must be at least 6 characters long' });
|
res.status(400).json({ error: 'New password must be at least 8 characters long' });
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -75,8 +75,8 @@ export const setupAdmin = async (req: Request, res: Response): Promise<void> =>
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Password length validation
|
// Password length validation
|
||||||
if (password.length < 6) {
|
if (password.length < 8) {
|
||||||
res.status(400).json({ error: 'Das Passwort muss mindestens 6 Zeichen lang sein' });
|
res.status(400).json({ error: 'Das Passwort muss mindestens 8 Zeichen lang sein' });
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -23,7 +23,7 @@
|
|||||||
### \[CREATE\] Employee
|
### \[CREATE\] Employee
|
||||||
* `firstname` 1-100 characters and must not be empty
|
* `firstname` 1-100 characters and must not be empty
|
||||||
* `lastname` 1-100 characters and must not be empty
|
* `lastname` 1-100 characters and must not be empty
|
||||||
* `password` must be at least 6 characters (in create mode)
|
* `password` must be at least 8 characters (in create mode)
|
||||||
* `employeeType` must be `manager`, `personell`, `apprentice`, or `guest`
|
* `employeeType` must be `manager`, `personell`, `apprentice`, or `guest`
|
||||||
* `canWorkAlone` optional boolean
|
* `canWorkAlone` optional boolean
|
||||||
* `isTrainee` optional boolean
|
* `isTrainee` optional boolean
|
||||||
|
|||||||
@@ -209,7 +209,7 @@ export const validateChangePassword = [
|
|||||||
.isLength({ min: 1 })
|
.isLength({ min: 1 })
|
||||||
.withMessage('Current password is required for self-password change'),
|
.withMessage('Current password is required for self-password change'),
|
||||||
|
|
||||||
body('password')
|
body('newPassword')
|
||||||
.isLength({ min: 8 })
|
.isLength({ min: 8 })
|
||||||
.withMessage('Password must be at least 8 characters')
|
.withMessage('Password must be at least 8 characters')
|
||||||
.matches(/^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[!@#$%^&*()_+\-=\[\]{};':"\\|,.<>\/?])/)
|
.matches(/^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[!@#$%^&*()_+\-=\[\]{};':"\\|,.<>\/?])/)
|
||||||
@@ -217,7 +217,7 @@ export const validateChangePassword = [
|
|||||||
|
|
||||||
body('confirmPassword')
|
body('confirmPassword')
|
||||||
.custom((value, { req }) => {
|
.custom((value, { req }) => {
|
||||||
if (value !== req.body.password) {
|
if (value !== req.body.newPassword) {
|
||||||
throw new Error('Passwords do not match');
|
throw new Error('Passwords do not match');
|
||||||
}
|
}
|
||||||
return true;
|
return true;
|
||||||
|
|||||||
@@ -22,8 +22,8 @@ function generateEmail(firstname: string, lastname: string): string {
|
|||||||
export function validateEmployeeData(employee: CreateEmployeeRequest): string[] {
|
export function validateEmployeeData(employee: CreateEmployeeRequest): string[] {
|
||||||
const errors: string[] = [];
|
const errors: string[] = [];
|
||||||
|
|
||||||
if (employee.password?.length < 6) {
|
if (employee.password?.length < 8) {
|
||||||
errors.push('Password must be at least 6 characters long');
|
errors.push('Password must be at least 8 characters long');
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!employee.firstname?.trim() || employee.firstname.trim().length < 2) {
|
if (!employee.firstname?.trim() || employee.firstname.trim().length < 2) {
|
||||||
|
|||||||
@@ -28,18 +28,18 @@ const router = express.Router();
|
|||||||
router.use(authMiddleware);
|
router.use(authMiddleware);
|
||||||
|
|
||||||
// Employee CRUD Routes
|
// Employee CRUD Routes
|
||||||
router.get('/', validatePagination, handleValidationErrors, getEmployees);
|
router.get('/', validatePagination, handleValidationErrors, authMiddleware, getEmployees);
|
||||||
router.get('/:id', validateId, handleValidationErrors, requireRole(['admin', 'maintenance']), getEmployee);
|
router.get('/:id', validateId, handleValidationErrors, requireRole(['admin', 'maintenance']), getEmployee);
|
||||||
router.post('/', validateEmployee, handleValidationErrors, requireRole(['admin']), createEmployee);
|
router.post('/', validateEmployee, handleValidationErrors, requireRole(['admin']), createEmployee);
|
||||||
router.put('/:id', validateId, validateEmployeeUpdate, handleValidationErrors, requireRole(['admin', 'maintenance']), updateEmployee);
|
router.put('/:id', validateId, validateEmployeeUpdate, handleValidationErrors, requireRole(['admin', 'maintenance']), updateEmployee);
|
||||||
router.delete('/:id', validateId, handleValidationErrors, requireRole(['admin']), deleteEmployee);
|
router.delete('/:id', validateId, handleValidationErrors, requireRole(['admin']), deleteEmployee);
|
||||||
|
|
||||||
// Password & Login Routes
|
// Password & Login Routes
|
||||||
router.put('/:id/password', validateId, validateChangePassword, handleValidationErrors, changePassword);
|
router.put('/:id/password', validateId, validateChangePassword, handleValidationErrors, authMiddleware, changePassword);
|
||||||
router.put('/:id/last-login', validateId, handleValidationErrors, updateLastLogin);
|
router.put('/:id/last-login', validateId, handleValidationErrors, authMiddleware, updateLastLogin);
|
||||||
|
|
||||||
// Availability Routes
|
// Availability Routes
|
||||||
router.get('/:employeeId/availabilities', validateEmployeeId, handleValidationErrors, getAvailabilities);
|
router.get('/:employeeId/availabilities', validateEmployeeId, handleValidationErrors, authMiddleware, getAvailabilities);
|
||||||
router.put('/:employeeId/availabilities', validateEmployeeId, validateAvailabilities, handleValidationErrors, updateAvailabilities);
|
router.put('/:employeeId/availabilities', validateEmployeeId, validateAvailabilities, handleValidationErrors, authMiddleware, updateAvailabilities);
|
||||||
|
|
||||||
export default router;
|
export default router;
|
||||||
@@ -65,7 +65,7 @@ export async function initializeDatabase(): Promise<void> {
|
|||||||
|
|
||||||
console.log('Existing tables found:', existingTables.map(t => t.name).join(', ') || 'none');
|
console.log('Existing tables found:', existingTables.map(t => t.name).join(', ') || 'none');
|
||||||
|
|
||||||
// UPDATED: Drop tables in correct dependency order for new schema
|
// Drop tables in correct dependency order for new schema
|
||||||
const tablesToDrop = [
|
const tablesToDrop = [
|
||||||
'employee_availability',
|
'employee_availability',
|
||||||
'shift_assignments',
|
'shift_assignments',
|
||||||
@@ -95,16 +95,40 @@ export async function initializeDatabase(): Promise<void> {
|
|||||||
// Continue with schema creation even if table dropping fails
|
// Continue with schema creation even if table dropping fails
|
||||||
}
|
}
|
||||||
|
|
||||||
// Execute schema creation in a transaction
|
// NEU: PRAGMA-Anweisungen außerhalb der Transaktion ausführen
|
||||||
await db.run('BEGIN EXCLUSIVE TRANSACTION');
|
console.log('Executing PRAGMA statements outside transaction...');
|
||||||
|
const pragmaStatements = schema
|
||||||
// Execute each statement separately for better error reporting
|
|
||||||
const statements = schema
|
|
||||||
.split(';')
|
.split(';')
|
||||||
.map(stmt => stmt.trim())
|
.map(stmt => stmt.trim())
|
||||||
.filter(stmt => stmt.length > 0)
|
.filter(stmt => stmt.length > 0)
|
||||||
|
.filter(stmt => stmt.toUpperCase().startsWith('PRAGMA'))
|
||||||
|
.map(stmt => {
|
||||||
|
return stmt.split('\n')
|
||||||
|
.filter(line => !line.trim().startsWith('--'))
|
||||||
|
.join('\n')
|
||||||
|
.trim();
|
||||||
|
});
|
||||||
|
|
||||||
|
for (const statement of pragmaStatements) {
|
||||||
|
try {
|
||||||
|
console.log('Executing PRAGMA:', statement);
|
||||||
|
await db.run(statement);
|
||||||
|
} catch (error) {
|
||||||
|
console.warn('PRAGMA statement might have failed:', statement, error);
|
||||||
|
// Continue even if PRAGMA fails
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Schema-Erstellung in Transaktion
|
||||||
|
await db.run('BEGIN EXCLUSIVE TRANSACTION');
|
||||||
|
|
||||||
|
// Nur die CREATE TABLE und andere Anweisungen (ohne PRAGMA)
|
||||||
|
const schemaStatements = schema
|
||||||
|
.split(';')
|
||||||
|
.map(stmt => stmt.trim())
|
||||||
|
.filter(stmt => stmt.length > 0)
|
||||||
|
.filter(stmt => !stmt.toUpperCase().startsWith('PRAGMA'))
|
||||||
.map(stmt => {
|
.map(stmt => {
|
||||||
// Remove any single-line comments
|
|
||||||
return stmt.split('\n')
|
return stmt.split('\n')
|
||||||
.filter(line => !line.trim().startsWith('--'))
|
.filter(line => !line.trim().startsWith('--'))
|
||||||
.join('\n')
|
.join('\n')
|
||||||
@@ -112,7 +136,7 @@ export async function initializeDatabase(): Promise<void> {
|
|||||||
})
|
})
|
||||||
.filter(stmt => stmt.length > 0);
|
.filter(stmt => stmt.length > 0);
|
||||||
|
|
||||||
for (const statement of statements) {
|
for (const statement of schemaStatements) {
|
||||||
try {
|
try {
|
||||||
console.log('Executing statement:', statement.substring(0, 50) + '...');
|
console.log('Executing statement:', statement.substring(0, 50) + '...');
|
||||||
await db.run(statement);
|
await db.run(statement);
|
||||||
@@ -124,7 +148,7 @@ export async function initializeDatabase(): Promise<void> {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// UPDATED: Insert default data in correct order
|
// Insert default data in correct order
|
||||||
try {
|
try {
|
||||||
console.log('Inserting default employee types...');
|
console.log('Inserting default employee types...');
|
||||||
await db.run(`INSERT OR IGNORE INTO employee_types (type, category, has_contract_type) VALUES ('manager', 'internal', 1)`);
|
await db.run(`INSERT OR IGNORE INTO employee_types (type, category, has_contract_type) VALUES ('manager', 'internal', 1)`);
|
||||||
|
|||||||
@@ -33,35 +33,19 @@ export const useBackendValidation = () => {
|
|||||||
const result = await apiCall();
|
const result = await apiCall();
|
||||||
return result;
|
return result;
|
||||||
} catch (error: any) {
|
} catch (error: any) {
|
||||||
if (error.validationErrors) {
|
if (error.validationErrors && Array.isArray(error.validationErrors)) {
|
||||||
setValidationErrors(error.validationErrors);
|
setValidationErrors(error.validationErrors);
|
||||||
|
|
||||||
// Show specific validation error messages
|
// Show specific validation error messages from backend
|
||||||
if (error.validationErrors.length > 0) {
|
error.validationErrors.forEach((validationError: ValidationError, index: number) => {
|
||||||
// Show the first validation error as the main notification
|
setTimeout(() => {
|
||||||
const firstError = error.validationErrors[0];
|
|
||||||
showNotification({
|
showNotification({
|
||||||
type: 'error',
|
type: 'error',
|
||||||
title: 'Validierungsfehler',
|
title: 'Validierungsfehler',
|
||||||
message: firstError.message
|
message: `${validationError.field ? `${validationError.field}: ` : ''}${validationError.message}`
|
||||||
});
|
});
|
||||||
|
}, index * 500); // Stagger the notifications
|
||||||
// If there are multiple errors, show additional notifications for each
|
|
||||||
if (error.validationErrors.length > 1) {
|
|
||||||
// Wait a bit before showing additional notifications to avoid overlap
|
|
||||||
setTimeout(() => {
|
|
||||||
error.validationErrors.slice(1).forEach((validationError: ValidationError, index: number) => {
|
|
||||||
setTimeout(() => {
|
|
||||||
showNotification({
|
|
||||||
type: 'error',
|
|
||||||
title: 'Weiterer Fehler',
|
|
||||||
message: validationError.message
|
|
||||||
});
|
});
|
||||||
}, index * 300); // Stagger the notifications
|
|
||||||
});
|
|
||||||
}, 500);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
} else {
|
} else {
|
||||||
// Show notification for other errors
|
// Show notification for other errors
|
||||||
showNotification({
|
showNotification({
|
||||||
|
|||||||
@@ -22,8 +22,8 @@ function generateEmail(firstname: string, lastname: string): string {
|
|||||||
export function validateEmployeeData(employee: CreateEmployeeRequest): string[] {
|
export function validateEmployeeData(employee: CreateEmployeeRequest): string[] {
|
||||||
const errors: string[] = [];
|
const errors: string[] = [];
|
||||||
|
|
||||||
if (employee.password?.length < 6) {
|
if (employee.password?.length < 8) {
|
||||||
errors.push('Password must be at least 6 characters long');
|
errors.push('Password must be at least 8 characters long');
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!employee.firstname?.trim() || employee.firstname.trim().length < 2) {
|
if (!employee.firstname?.trim() || employee.firstname.trim().length < 2) {
|
||||||
|
|||||||
@@ -343,7 +343,8 @@ const useEmployeeForm = (mode: 'create' | 'edit', employee?: Employee) => {
|
|||||||
await executeWithValidation(() =>
|
await executeWithValidation(() =>
|
||||||
employeeService.changePassword(employee.id, {
|
employeeService.changePassword(employee.id, {
|
||||||
currentPassword: '',
|
currentPassword: '',
|
||||||
newPassword: passwordForm.newPassword
|
newPassword: passwordForm.newPassword,
|
||||||
|
confirmPassword: passwordForm.confirmPassword
|
||||||
})
|
})
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,8 +1,9 @@
|
|||||||
// frontend/src/pages/Settings/Settings.tsx - UPDATED WITH NEW STYLES
|
// frontend/src/pages/Settings/Settings.tsx - UPDATED WITH VALIDATION STRATEGY
|
||||||
import React, { useState, useEffect, useRef } from 'react';
|
import React, { useState, useEffect, useRef } from 'react';
|
||||||
import { useAuth } from '../../contexts/AuthContext';
|
import { useAuth } from '../../contexts/AuthContext';
|
||||||
import { employeeService } from '../../services/employeeService';
|
import { employeeService } from '../../services/employeeService';
|
||||||
import { useNotification } from '../../contexts/NotificationContext';
|
import { useNotification } from '../../contexts/NotificationContext';
|
||||||
|
import { useBackendValidation } from '../../hooks/useBackendValidation';
|
||||||
import AvailabilityManager from '../Employees/components/AvailabilityManager';
|
import AvailabilityManager from '../Employees/components/AvailabilityManager';
|
||||||
import { Employee } from '../../models/Employee';
|
import { Employee } from '../../models/Employee';
|
||||||
import { styles } from './type/SettingsType';
|
import { styles } from './type/SettingsType';
|
||||||
@@ -10,11 +11,12 @@ import { styles } from './type/SettingsType';
|
|||||||
const Settings: React.FC = () => {
|
const Settings: React.FC = () => {
|
||||||
const { user: currentUser, updateUser } = useAuth();
|
const { user: currentUser, updateUser } = useAuth();
|
||||||
const { showNotification } = useNotification();
|
const { showNotification } = useNotification();
|
||||||
|
const { executeWithValidation, clearErrors, isSubmitting } = useBackendValidation();
|
||||||
|
|
||||||
const [activeTab, setActiveTab] = useState<'profile' | 'password' | 'availability'>('profile');
|
const [activeTab, setActiveTab] = useState<'profile' | 'password' | 'availability'>('profile');
|
||||||
const [loading, setLoading] = useState(false);
|
|
||||||
const [showAvailabilityManager, setShowAvailabilityManager] = useState(false);
|
const [showAvailabilityManager, setShowAvailabilityManager] = useState(false);
|
||||||
|
|
||||||
// Profile form state - updated for firstname/lastname
|
// Profile form state
|
||||||
const [profileForm, setProfileForm] = useState({
|
const [profileForm, setProfileForm] = useState({
|
||||||
firstname: currentUser?.firstname || '',
|
firstname: currentUser?.firstname || '',
|
||||||
lastname: currentUser?.lastname || ''
|
lastname: currentUser?.lastname || ''
|
||||||
@@ -73,7 +75,7 @@ const Settings: React.FC = () => {
|
|||||||
}));
|
}));
|
||||||
};
|
};
|
||||||
|
|
||||||
// Password visibility handlers for current password
|
// Password visibility handlers
|
||||||
const handleCurrentPasswordMouseDown = () => {
|
const handleCurrentPasswordMouseDown = () => {
|
||||||
currentPasswordTimeoutRef.current = setTimeout(() => {
|
currentPasswordTimeoutRef.current = setTimeout(() => {
|
||||||
setShowCurrentPassword(true);
|
setShowCurrentPassword(true);
|
||||||
@@ -88,7 +90,6 @@ const Settings: React.FC = () => {
|
|||||||
setShowCurrentPassword(false);
|
setShowCurrentPassword(false);
|
||||||
};
|
};
|
||||||
|
|
||||||
// Password visibility handlers for new password
|
|
||||||
const handleNewPasswordMouseDown = () => {
|
const handleNewPasswordMouseDown = () => {
|
||||||
newPasswordTimeoutRef.current = setTimeout(() => {
|
newPasswordTimeoutRef.current = setTimeout(() => {
|
||||||
setShowNewPassword(true);
|
setShowNewPassword(true);
|
||||||
@@ -103,7 +104,6 @@ const Settings: React.FC = () => {
|
|||||||
setShowNewPassword(false);
|
setShowNewPassword(false);
|
||||||
};
|
};
|
||||||
|
|
||||||
// Password visibility handlers for confirm password
|
|
||||||
const handleConfirmPasswordMouseDown = () => {
|
const handleConfirmPasswordMouseDown = () => {
|
||||||
confirmPasswordTimeoutRef.current = setTimeout(() => {
|
confirmPasswordTimeoutRef.current = setTimeout(() => {
|
||||||
setShowConfirmPassword(true);
|
setShowConfirmPassword(true);
|
||||||
@@ -129,7 +129,6 @@ const Settings: React.FC = () => {
|
|||||||
cleanup();
|
cleanup();
|
||||||
};
|
};
|
||||||
|
|
||||||
// Prevent context menu
|
|
||||||
const handleContextMenu = (e: React.MouseEvent) => {
|
const handleContextMenu = (e: React.MouseEvent) => {
|
||||||
e.preventDefault();
|
e.preventDefault();
|
||||||
};
|
};
|
||||||
@@ -138,40 +137,46 @@ const Settings: React.FC = () => {
|
|||||||
e.preventDefault();
|
e.preventDefault();
|
||||||
if (!currentUser) return;
|
if (!currentUser) return;
|
||||||
|
|
||||||
// Validation
|
// BASIC FRONTEND VALIDATION: Only check required fields
|
||||||
if (!profileForm.firstname.trim() || !profileForm.lastname.trim()) {
|
if (!profileForm.firstname.trim()) {
|
||||||
showNotification({
|
showNotification({
|
||||||
type: 'error',
|
type: 'error',
|
||||||
title: 'Fehler',
|
title: 'Fehler',
|
||||||
message: 'Vorname und Nachname sind erforderlich'
|
message: 'Vorname ist erforderlich'
|
||||||
|
});
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!profileForm.lastname.trim()) {
|
||||||
|
showNotification({
|
||||||
|
type: 'error',
|
||||||
|
title: 'Fehler',
|
||||||
|
message: 'Nachname ist erforderlich'
|
||||||
});
|
});
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
try {
|
try {
|
||||||
setLoading(true);
|
// Use executeWithValidation to handle backend validation
|
||||||
await employeeService.updateEmployee(currentUser.id, {
|
await executeWithValidation(async () => {
|
||||||
|
const updatedEmployee = await employeeService.updateEmployee(currentUser.id, {
|
||||||
firstname: profileForm.firstname.trim(),
|
firstname: profileForm.firstname.trim(),
|
||||||
lastname: profileForm.lastname.trim()
|
lastname: profileForm.lastname.trim()
|
||||||
});
|
});
|
||||||
|
|
||||||
// Update the auth context with new user data
|
// Update the auth context with new user data
|
||||||
const updatedUser = await employeeService.getEmployee(currentUser.id);
|
updateUser(updatedEmployee);
|
||||||
updateUser(updatedUser);
|
|
||||||
|
|
||||||
showNotification({
|
showNotification({
|
||||||
type: 'success',
|
type: 'success',
|
||||||
title: 'Erfolg',
|
title: 'Erfolg',
|
||||||
message: 'Profil erfolgreich aktualisiert'
|
message: 'Profil erfolgreich aktualisiert'
|
||||||
});
|
});
|
||||||
} catch (error: any) {
|
|
||||||
showNotification({
|
|
||||||
type: 'error',
|
|
||||||
title: 'Fehler',
|
|
||||||
message: error.message || 'Profil konnte nicht aktualisiert werden'
|
|
||||||
});
|
});
|
||||||
} finally {
|
} catch (error) {
|
||||||
setLoading(false);
|
// Backend validation errors are already handled by executeWithValidation
|
||||||
|
// We only need to handle unexpected errors here
|
||||||
|
console.error('Unexpected error:', error);
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -179,12 +184,30 @@ const Settings: React.FC = () => {
|
|||||||
e.preventDefault();
|
e.preventDefault();
|
||||||
if (!currentUser) return;
|
if (!currentUser) return;
|
||||||
|
|
||||||
// Validation
|
// BASIC FRONTEND VALIDATION: Only check minimum requirements
|
||||||
if (passwordForm.newPassword.length < 6) {
|
if (!passwordForm.currentPassword) {
|
||||||
showNotification({
|
showNotification({
|
||||||
type: 'error',
|
type: 'error',
|
||||||
title: 'Fehler',
|
title: 'Fehler',
|
||||||
message: 'Das neue Passwort muss mindestens 6 Zeichen lang sein'
|
message: 'Aktuelles Passwort ist erforderlich'
|
||||||
|
});
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!passwordForm.newPassword) {
|
||||||
|
showNotification({
|
||||||
|
type: 'error',
|
||||||
|
title: 'Fehler',
|
||||||
|
message: 'Neues Passwort ist erforderlich'
|
||||||
|
});
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (passwordForm.newPassword.length < 8) {
|
||||||
|
showNotification({
|
||||||
|
type: 'error',
|
||||||
|
title: 'Fehler',
|
||||||
|
message: 'Das neue Passwort muss mindestens 8 Zeichen lang sein'
|
||||||
});
|
});
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
@@ -199,12 +222,12 @@ const Settings: React.FC = () => {
|
|||||||
}
|
}
|
||||||
|
|
||||||
try {
|
try {
|
||||||
setLoading(true);
|
// Use executeWithValidation to handle backend validation
|
||||||
|
await executeWithValidation(async () => {
|
||||||
// Use the actual password change endpoint
|
|
||||||
await employeeService.changePassword(currentUser.id, {
|
await employeeService.changePassword(currentUser.id, {
|
||||||
currentPassword: passwordForm.currentPassword,
|
currentPassword: passwordForm.currentPassword,
|
||||||
newPassword: passwordForm.newPassword
|
newPassword: passwordForm.newPassword,
|
||||||
|
confirmPassword: passwordForm.confirmPassword
|
||||||
});
|
});
|
||||||
|
|
||||||
showNotification({
|
showNotification({
|
||||||
@@ -219,14 +242,10 @@ const Settings: React.FC = () => {
|
|||||||
newPassword: '',
|
newPassword: '',
|
||||||
confirmPassword: ''
|
confirmPassword: ''
|
||||||
});
|
});
|
||||||
} catch (error: any) {
|
|
||||||
showNotification({
|
|
||||||
type: 'error',
|
|
||||||
title: 'Fehler',
|
|
||||||
message: error.message || 'Passwort konnte nicht geändert werden'
|
|
||||||
});
|
});
|
||||||
} finally {
|
} catch (error) {
|
||||||
setLoading(false);
|
// Backend validation errors are already handled by executeWithValidation
|
||||||
|
console.error('Unexpected error:', error);
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -243,6 +262,12 @@ const Settings: React.FC = () => {
|
|||||||
setShowAvailabilityManager(false);
|
setShowAvailabilityManager(false);
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// Clear validation errors when switching tabs
|
||||||
|
const handleTabChange = (tab: 'profile' | 'password' | 'availability') => {
|
||||||
|
clearErrors();
|
||||||
|
setActiveTab(tab);
|
||||||
|
};
|
||||||
|
|
||||||
if (!currentUser) {
|
if (!currentUser) {
|
||||||
return <div style={{
|
return <div style={{
|
||||||
textAlign: 'center',
|
textAlign: 'center',
|
||||||
@@ -273,7 +298,7 @@ const Settings: React.FC = () => {
|
|||||||
|
|
||||||
<div style={styles.tabs}>
|
<div style={styles.tabs}>
|
||||||
<button
|
<button
|
||||||
onClick={() => setActiveTab('profile')}
|
onClick={() => handleTabChange('profile')}
|
||||||
style={{
|
style={{
|
||||||
...styles.tab,
|
...styles.tab,
|
||||||
...(activeTab === 'profile' ? styles.tabActive : {})
|
...(activeTab === 'profile' ? styles.tabActive : {})
|
||||||
@@ -301,7 +326,7 @@ const Settings: React.FC = () => {
|
|||||||
</button>
|
</button>
|
||||||
|
|
||||||
<button
|
<button
|
||||||
onClick={() => setActiveTab('password')}
|
onClick={() => handleTabChange('password')}
|
||||||
style={{
|
style={{
|
||||||
...styles.tab,
|
...styles.tab,
|
||||||
...(activeTab === 'password' ? styles.tabActive : {})
|
...(activeTab === 'password' ? styles.tabActive : {})
|
||||||
@@ -329,7 +354,7 @@ const Settings: React.FC = () => {
|
|||||||
</button>
|
</button>
|
||||||
|
|
||||||
<button
|
<button
|
||||||
onClick={() => setActiveTab('availability')}
|
onClick={() => handleTabChange('availability')}
|
||||||
style={{
|
style={{
|
||||||
...styles.tab,
|
...styles.tab,
|
||||||
...(activeTab === 'availability' ? styles.tabActive : {})
|
...(activeTab === 'availability' ? styles.tabActive : {})
|
||||||
@@ -480,28 +505,28 @@ const Settings: React.FC = () => {
|
|||||||
<div style={styles.actions}>
|
<div style={styles.actions}>
|
||||||
<button
|
<button
|
||||||
type="submit"
|
type="submit"
|
||||||
disabled={loading || !profileForm.firstname.trim() || !profileForm.lastname.trim()}
|
disabled={isSubmitting || !profileForm.firstname.trim() || !profileForm.lastname.trim()}
|
||||||
style={{
|
style={{
|
||||||
...styles.button,
|
...styles.button,
|
||||||
...styles.buttonPrimary,
|
...styles.buttonPrimary,
|
||||||
...((loading || !profileForm.firstname.trim() || !profileForm.lastname.trim()) ? styles.buttonDisabled : {})
|
...((isSubmitting || !profileForm.firstname.trim() || !profileForm.lastname.trim()) ? styles.buttonDisabled : {})
|
||||||
}}
|
}}
|
||||||
onMouseEnter={(e) => {
|
onMouseEnter={(e) => {
|
||||||
if (!loading && profileForm.firstname.trim() && profileForm.lastname.trim()) {
|
if (!isSubmitting && profileForm.firstname.trim() && profileForm.lastname.trim()) {
|
||||||
e.currentTarget.style.background = styles.buttonPrimaryHover.background;
|
e.currentTarget.style.background = styles.buttonPrimaryHover.background;
|
||||||
e.currentTarget.style.transform = styles.buttonPrimaryHover.transform;
|
e.currentTarget.style.transform = styles.buttonPrimaryHover.transform;
|
||||||
e.currentTarget.style.boxShadow = styles.buttonPrimaryHover.boxShadow;
|
e.currentTarget.style.boxShadow = styles.buttonPrimaryHover.boxShadow;
|
||||||
}
|
}
|
||||||
}}
|
}}
|
||||||
onMouseLeave={(e) => {
|
onMouseLeave={(e) => {
|
||||||
if (!loading && profileForm.firstname.trim() && profileForm.lastname.trim()) {
|
if (!isSubmitting && profileForm.firstname.trim() && profileForm.lastname.trim()) {
|
||||||
e.currentTarget.style.background = styles.buttonPrimary.background;
|
e.currentTarget.style.background = styles.buttonPrimary.background;
|
||||||
e.currentTarget.style.transform = 'none';
|
e.currentTarget.style.transform = 'none';
|
||||||
e.currentTarget.style.boxShadow = styles.buttonPrimary.boxShadow;
|
e.currentTarget.style.boxShadow = styles.buttonPrimary.boxShadow;
|
||||||
}
|
}
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
{loading ? '⏳ Wird gespeichert...' : 'Profil aktualisieren'}
|
{isSubmitting ? '⏳ Wird gespeichert...' : 'Profil aktualisieren'}
|
||||||
</button>
|
</button>
|
||||||
</div>
|
</div>
|
||||||
</form>
|
</form>
|
||||||
@@ -575,9 +600,9 @@ const Settings: React.FC = () => {
|
|||||||
value={passwordForm.newPassword}
|
value={passwordForm.newPassword}
|
||||||
onChange={handlePasswordChange}
|
onChange={handlePasswordChange}
|
||||||
required
|
required
|
||||||
minLength={6}
|
minLength={8}
|
||||||
style={styles.fieldInputWithIcon}
|
style={styles.fieldInputWithIcon}
|
||||||
placeholder="Mindestens 6 Zeichen"
|
placeholder="Mindestens 8 Zeichen"
|
||||||
onFocus={(e) => {
|
onFocus={(e) => {
|
||||||
e.target.style.borderColor = '#1a1325';
|
e.target.style.borderColor = '#1a1325';
|
||||||
e.target.style.boxShadow = '0 0 0 3px rgba(26, 19, 37, 0.1)';
|
e.target.style.boxShadow = '0 0 0 3px rgba(26, 19, 37, 0.1)';
|
||||||
@@ -606,7 +631,7 @@ const Settings: React.FC = () => {
|
|||||||
</button>
|
</button>
|
||||||
</div>
|
</div>
|
||||||
<div style={styles.fieldHint}>
|
<div style={styles.fieldHint}>
|
||||||
Das Passwort muss mindestens 6 Zeichen lang sein.
|
Das Passwort muss mindestens 8 Zeichen lang sein.
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
@@ -657,28 +682,28 @@ const Settings: React.FC = () => {
|
|||||||
<div style={styles.actions}>
|
<div style={styles.actions}>
|
||||||
<button
|
<button
|
||||||
type="submit"
|
type="submit"
|
||||||
disabled={loading || !passwordForm.currentPassword || !passwordForm.newPassword || !passwordForm.confirmPassword}
|
disabled={isSubmitting || !passwordForm.currentPassword || !passwordForm.newPassword || !passwordForm.confirmPassword}
|
||||||
style={{
|
style={{
|
||||||
...styles.button,
|
...styles.button,
|
||||||
...styles.buttonPrimary,
|
...styles.buttonPrimary,
|
||||||
...((loading || !passwordForm.currentPassword || !passwordForm.newPassword || !passwordForm.confirmPassword) ? styles.buttonDisabled : {})
|
...((isSubmitting || !passwordForm.currentPassword || !passwordForm.newPassword || !passwordForm.confirmPassword) ? styles.buttonDisabled : {})
|
||||||
}}
|
}}
|
||||||
onMouseEnter={(e) => {
|
onMouseEnter={(e) => {
|
||||||
if (!loading && passwordForm.currentPassword && passwordForm.newPassword && passwordForm.confirmPassword) {
|
if (!isSubmitting && passwordForm.currentPassword && passwordForm.newPassword && passwordForm.confirmPassword) {
|
||||||
e.currentTarget.style.background = styles.buttonPrimaryHover.background;
|
e.currentTarget.style.background = styles.buttonPrimaryHover.background;
|
||||||
e.currentTarget.style.transform = styles.buttonPrimaryHover.transform;
|
e.currentTarget.style.transform = styles.buttonPrimaryHover.transform;
|
||||||
e.currentTarget.style.boxShadow = styles.buttonPrimaryHover.boxShadow;
|
e.currentTarget.style.boxShadow = styles.buttonPrimaryHover.boxShadow;
|
||||||
}
|
}
|
||||||
}}
|
}}
|
||||||
onMouseLeave={(e) => {
|
onMouseLeave={(e) => {
|
||||||
if (!loading && passwordForm.currentPassword && passwordForm.newPassword && passwordForm.confirmPassword) {
|
if (!isSubmitting && passwordForm.currentPassword && passwordForm.newPassword && passwordForm.confirmPassword) {
|
||||||
e.currentTarget.style.background = styles.buttonPrimary.background;
|
e.currentTarget.style.background = styles.buttonPrimary.background;
|
||||||
e.currentTarget.style.transform = 'none';
|
e.currentTarget.style.transform = 'none';
|
||||||
e.currentTarget.style.boxShadow = styles.buttonPrimary.boxShadow;
|
e.currentTarget.style.boxShadow = styles.buttonPrimary.boxShadow;
|
||||||
}
|
}
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
{loading ? '⏳ Wird geändert...' : 'Passwort ändern'}
|
{isSubmitting ? '⏳ Wird geändert...' : 'Passwort ändern'}
|
||||||
</button>
|
</button>
|
||||||
</div>
|
</div>
|
||||||
</form>
|
</form>
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
// frontend/src/pages/Settings/type/SettingsType.tsx - CORRECTED
|
// frontend/src/pages/Settings/type/SettingsType.tsx
|
||||||
export const styles = {
|
export const styles = {
|
||||||
container: {
|
container: {
|
||||||
display: 'flex',
|
display: 'flex',
|
||||||
|
|||||||
@@ -62,8 +62,8 @@ const useSetup = () => {
|
|||||||
};
|
};
|
||||||
|
|
||||||
const validateStep2 = (): boolean => {
|
const validateStep2 = (): boolean => {
|
||||||
if (formData.password.length < 6) {
|
if (formData.password.length < 8) {
|
||||||
setError('Das Passwort muss mindestens 6 Zeichen lang sein.');
|
setError('Das Passwort muss mindestens 8 Zeichen lang sein.');
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
if (formData.password !== formData.confirmPassword) {
|
if (formData.password !== formData.confirmPassword) {
|
||||||
@@ -186,7 +186,7 @@ const useSetup = () => {
|
|||||||
const isStepCompleted = (stepIndex: number): boolean => {
|
const isStepCompleted = (stepIndex: number): boolean => {
|
||||||
switch (stepIndex) {
|
switch (stepIndex) {
|
||||||
case 0:
|
case 0:
|
||||||
return formData.password.length >= 6 &&
|
return formData.password.length >= 8 &&
|
||||||
formData.password === formData.confirmPassword;
|
formData.password === formData.confirmPassword;
|
||||||
case 1:
|
case 1:
|
||||||
return !!formData.firstname.trim() && !!formData.lastname.trim();
|
return !!formData.firstname.trim() && !!formData.lastname.trim();
|
||||||
@@ -342,7 +342,7 @@ const Step2Content: React.FC<StepContentProps> = ({
|
|||||||
fontSize: '1rem',
|
fontSize: '1rem',
|
||||||
transition: 'border-color 0.3s ease'
|
transition: 'border-color 0.3s ease'
|
||||||
}}
|
}}
|
||||||
placeholder="Mindestens 6 Zeichen"
|
placeholder="Mindestens 8 Zeichen"
|
||||||
required
|
required
|
||||||
autoComplete="new-password"
|
autoComplete="new-password"
|
||||||
/>
|
/>
|
||||||
|
|||||||
@@ -1,5 +1,7 @@
|
|||||||
// frontend/src/services/authService.ts
|
// frontend/src/services/authService.ts - UPDATED
|
||||||
import { Employee } from '../models/Employee';
|
import { Employee } from '../models/Employee';
|
||||||
|
import { ErrorService } from './errorService';
|
||||||
|
|
||||||
const API_BASE_URL = import.meta.env.VITE_API_URL || '/api';
|
const API_BASE_URL = import.meta.env.VITE_API_URL || '/api';
|
||||||
|
|
||||||
export interface LoginRequest {
|
export interface LoginRequest {
|
||||||
@@ -23,6 +25,23 @@ export interface AuthResponse {
|
|||||||
class AuthService {
|
class AuthService {
|
||||||
private token: string | null = null;
|
private token: string | null = null;
|
||||||
|
|
||||||
|
private async handleApiResponse<T>(response: Response): Promise<T> {
|
||||||
|
if (!response.ok) {
|
||||||
|
const errorData = await response.json().catch(() => ({}));
|
||||||
|
const validationErrors = ErrorService.extractValidationErrors(errorData);
|
||||||
|
|
||||||
|
if (validationErrors.length > 0) {
|
||||||
|
const error = new Error('Validation failed');
|
||||||
|
(error as any).validationErrors = validationErrors;
|
||||||
|
throw error;
|
||||||
|
}
|
||||||
|
|
||||||
|
throw new Error(errorData.error || errorData.message || 'Authentication failed');
|
||||||
|
}
|
||||||
|
|
||||||
|
return response.json();
|
||||||
|
}
|
||||||
|
|
||||||
async login(credentials: LoginRequest): Promise<AuthResponse> {
|
async login(credentials: LoginRequest): Promise<AuthResponse> {
|
||||||
const response = await fetch(`${API_BASE_URL}/auth/login`, {
|
const response = await fetch(`${API_BASE_URL}/auth/login`, {
|
||||||
method: 'POST',
|
method: 'POST',
|
||||||
@@ -30,12 +49,7 @@ class AuthService {
|
|||||||
body: JSON.stringify(credentials)
|
body: JSON.stringify(credentials)
|
||||||
});
|
});
|
||||||
|
|
||||||
if (!response.ok) {
|
const data = await this.handleApiResponse<AuthResponse>(response);
|
||||||
const errorData = await response.json();
|
|
||||||
throw new Error(errorData.error || 'Login fehlgeschlagen');
|
|
||||||
}
|
|
||||||
|
|
||||||
const data: AuthResponse = await response.json();
|
|
||||||
this.token = data.token;
|
this.token = data.token;
|
||||||
localStorage.setItem('token', data.token);
|
localStorage.setItem('token', data.token);
|
||||||
localStorage.setItem('employee', JSON.stringify(data.employee));
|
localStorage.setItem('employee', JSON.stringify(data.employee));
|
||||||
@@ -49,11 +63,7 @@ class AuthService {
|
|||||||
body: JSON.stringify(userData)
|
body: JSON.stringify(userData)
|
||||||
});
|
});
|
||||||
|
|
||||||
if (!response.ok) {
|
const data = await this.handleApiResponse<AuthResponse>(response);
|
||||||
const errorData = await response.json();
|
|
||||||
throw new Error(errorData.error || 'Registrierung fehlgeschlagen');
|
|
||||||
}
|
|
||||||
|
|
||||||
return this.login({
|
return this.login({
|
||||||
email: userData.email,
|
email: userData.email,
|
||||||
password: userData.password
|
password: userData.password
|
||||||
@@ -95,6 +105,7 @@ class AuthService {
|
|||||||
this.token = null;
|
this.token = null;
|
||||||
localStorage.removeItem('token');
|
localStorage.removeItem('token');
|
||||||
localStorage.removeItem('user');
|
localStorage.removeItem('user');
|
||||||
|
localStorage.removeItem('employee');
|
||||||
}
|
}
|
||||||
|
|
||||||
getToken(): string | null {
|
getToken(): string | null {
|
||||||
|
|||||||
@@ -24,7 +24,7 @@ export class EmployeeService {
|
|||||||
throw error;
|
throw error;
|
||||||
}
|
}
|
||||||
|
|
||||||
throw new Error(errorData.error || `HTTP error! status: ${response.status}`);
|
throw new Error(errorData.error || errorData.message || `HTTP error! status: ${response.status}`);
|
||||||
}
|
}
|
||||||
|
|
||||||
return response.json();
|
return response.json();
|
||||||
@@ -59,11 +59,7 @@ export class EmployeeService {
|
|||||||
headers: getAuthHeaders(),
|
headers: getAuthHeaders(),
|
||||||
});
|
});
|
||||||
|
|
||||||
if (!response.ok) {
|
return this.handleApiResponse<Employee>(response);
|
||||||
throw new Error('Failed to fetch employee');
|
|
||||||
}
|
|
||||||
|
|
||||||
return response.json();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
async createEmployee(employee: CreateEmployeeRequest): Promise<Employee> {
|
async createEmployee(employee: CreateEmployeeRequest): Promise<Employee> {
|
||||||
@@ -103,11 +99,7 @@ export class EmployeeService {
|
|||||||
headers: getAuthHeaders(),
|
headers: getAuthHeaders(),
|
||||||
});
|
});
|
||||||
|
|
||||||
if (!response.ok) {
|
return this.handleApiResponse<EmployeeAvailability[]>(response);
|
||||||
throw new Error('Failed to fetch availabilities');
|
|
||||||
}
|
|
||||||
|
|
||||||
return response.json();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
async updateAvailabilities(employeeId: string, data: { planId: string, availabilities: Omit<EmployeeAvailability, 'id' | 'employeeId'>[] }): Promise<EmployeeAvailability[]> {
|
async updateAvailabilities(employeeId: string, data: { planId: string, availabilities: Omit<EmployeeAvailability, 'id' | 'employeeId'>[] }): Promise<EmployeeAvailability[]> {
|
||||||
@@ -118,25 +110,17 @@ export class EmployeeService {
|
|||||||
body: JSON.stringify(data),
|
body: JSON.stringify(data),
|
||||||
});
|
});
|
||||||
|
|
||||||
if (!response.ok) {
|
return this.handleApiResponse<EmployeeAvailability[]>(response);
|
||||||
const error = await response.json();
|
|
||||||
throw new Error(error.error || 'Failed to update availabilities');
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return response.json();
|
async changePassword(id: string, data: { currentPassword: string, newPassword: string, confirmPassword: string }): Promise<void> {
|
||||||
}
|
|
||||||
|
|
||||||
async changePassword(id: string, data: { currentPassword: string, newPassword: string }): Promise<void> {
|
|
||||||
const response = await fetch(`${API_BASE_URL}/employees/${id}/password`, {
|
const response = await fetch(`${API_BASE_URL}/employees/${id}/password`, {
|
||||||
method: 'PUT',
|
method: 'PUT',
|
||||||
headers: getAuthHeaders(),
|
headers: getAuthHeaders(),
|
||||||
body: JSON.stringify(data),
|
body: JSON.stringify(data),
|
||||||
});
|
});
|
||||||
|
|
||||||
if (!response.ok) {
|
return this.handleApiResponse<void>(response);
|
||||||
const error = await response.json();
|
|
||||||
throw new Error(error.error || 'Failed to change password');
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
async updateLastLogin(employeeId: string): Promise<void> {
|
async updateLastLogin(employeeId: string): Promise<void> {
|
||||||
|
|||||||
Reference in New Issue
Block a user